Uh oh!
There was an error while loading. Please reload this page.
Setup Job: reword locked-dependencies log line to use lockfile language - #4550
Merged
ericsciple merged 2 commits intoJul 10, 2026
Merged
Conversation
Copy-only follow-up to actions#4546. Product feedback preferred lockfile wording over pinning/pinned language, and a reviewer asked to avoid an uppercase "Action". The Set up job line now reads "Using locked actions versions from the workflow's lockfile". Updates the matching positive and negative test assertions and the preceding comment. No behavior change.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Set up job user-facing log copy to use “lockfile” language when action dependency locking is in effect, and updates the corresponding L0 test assertions and nearby comment to match.
Changes:
- Reword the
JobExtension.InitializeJoboutput line for locked action dependency behavior to use lockfile terminology. - Update L0 assertions to match the new log line text.
- Adjust the preceding comment to align with the lockfile wording.
Show a summary per file
| File | Description |
|---|---|
| src/Runner.Worker/JobExtension.cs | Updates the emitted log line (and adjacent comment) to reference the workflow lockfile. |
| src/Test/L0/Worker/JobExtensionL0.cs | Updates L0 assertions to validate the updated log message text. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Low
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The log string read "locked actions versions" while the adjacent comment and reviewer feedback used the grammatically correct singular "locked action versions". Align the string and both L0 assertions to the singular form.
ericsciple
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy-only follow-up to #4546.
That PR shipped a Set up job log line announcing when a job runs with locked action dependencies. Based on follow-up feedback we're adjusting the wording only:
Change
The line in
src/Runner.Worker/JobExtension.csnow reads:(previously "Running with locked dependencies")
This updates:
src/Test/L0/Worker/JobExtensionL0.cs(positive + negative), andNo behavior change — copy only.
Refs: github/actions-dispatch#567