Uh oh!
There was an error while loading. Please reload this page.
Add support for JDKs with JavaFX - #19
Conversation
Also changes the toolcache to 'fx-jdk' for JDKs with JavaFX and 'jdk' for JDKs without JavaFX
rmannibucau
commented
Sep 4, 2019
Hi, can it be integrated please? |
airsquared
commented
Sep 4, 2019
What do you mean by "integrated"? |
rmannibucau
commented
Sep 4, 2019
Merged, it prevents me to use gh actions and i'd like to avoid to fork the download logic again. |
giltene
commented
Nov 3, 2019
I've created a separate pull request #27 that covers the requested feature but with a different syntax than the one proposed here: The change introduces a new java-package option that supports jre, jdk, and jdk+fx as accepted values (defaults to jdk and retains current behavior unless jre or jdk+fx is specified). I believe that this syntax (a single option to cover current and possible future package types) is preferable to having individual booleans per package type. The action is available for testing as foo-actions/setup-java@master |
konradpabjan
commented
Nov 22, 2019
Support for JavaFx was added with the following PR: #27 The README has also been updated with some information about how to use it. I've also updated the releases tag so as long as you're using |
I've tested this on my own repository, and it works well.
I wasn't sure what to set the name of the toolcache to, so I just changed it to
'fx-jdk'for JDKs with JavaFX and'jdk'for JDKs without JavaFX (you might want to change this to something else).To use this, just do:
Closes#18.