Add support for Liberica JDK

[RazorNd]

Description:
Add support for Liberica JDK distribution.

Related issue:
#70

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[dchuyko]

Hi. Daniil, a nice PR for Actions. Can we assist somehow? Workflows are awaiting approval for some time, probably should ping maintainers/owners. @chrispat@giltene any advice?

[maxim-lobanov]

Hey,
We will take a look at this PR.
cc: @dmitry-shibanov@MaksimZhukov

[maxim-lobanov]

@RazorNd, I have left a couple of nitpicks. If you can fix them and pull latest main / rebuild code, it would be awesome.
Also, I think @dmitry-shibanov@MaksimZhukov can help with e2e testing of these changes since their team owns this action for now.

[RazorNd]

@RazorNd, I have left a couple of nitpicks. If you can fix them and pull latest main / rebuild code, it would be awesome. Also, I think @dmitry-shibanov@MaksimZhukov can help with e2e testing of these changes since their team owns this action for now.

Thanks for your corrections. I fixed them. I pulled main 6 days ago. This PR is up to date.

[dchuyko]

@dmitry-shibanov Are there any issues? Anything that blocks approving the workflows?

[dmitry-shibanov]

Hello @RazorNd. Thank you for your pull request. Could you please add e2e tests. I've tested your changes and got error during java installation. I've used such workflow as:

name: Test java
on: [push]
jobs:
run:
name: Test java ${{ matrix.version }} ${{ matrix.java-package }} ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-18.04, macos-latest, windows-latest]
version: [ '8', '11', '13', '15', '16', '13-ea', '15-ea', '16-ea' ]
java-package: ['jdk', 'jre']
steps:
- name: Checkout
uses: actions/checkout@v2
- uses: RazorNd/setup-java@liberica
with:
java-version: ${{ matrix.version }}
distribution: liberica
java-package: ${{ matrix.java-package }}
- name: Java version
shell: pwsh
run: java -version

[RazorNd]

@dmitry-shibanov thanks for the hint. I fixed the errors that occurred during e2e testing. build example Also I tried adding e2e test in current workflow. Update for worflow. Add these changes to the current PR?

[dchuyko]

@RazorNd As far as I can see other recent additions (openj9) included e2e-versions.yml changes.

[dmitry-shibanov]

Hello @RazorNd. Thank you for updating branch with e2e tests. I've tested your changes from my side. In general it works as expected, but I have one minor question:

• Does Liberica jdk provide ea versions ? I've tried to install couple of early access versions, but array of possible versions was empty.

[RazorNd]

@dchuyko I was not sure if changing the pipeline for a non-owner is a good idea. But as a last resort I'll revert my changes.

[RazorNd]

Hello @RazorNd. Thank you for updating branch with e2e tests. I've tested your changes from my side. In general it works as expected, but I have one minor question:

• Does Liberica jdk provide ea versions ? I've tried to install couple of early access versions, but array of possible versions was empty.

@dmitry-shibanov I also noticed this yesterday. But if you look in API, Liberica has only 2 early access builds for Java 8. @dchuyko you don't release anymore early access builds? Or am I doing something wrong? API Request Example

[dchuyko]

• Does Liberica jdk provide ea versions ? I've tried to install couple of early access versions, but array of possible versions was empty.

Currently EA is not among public artifacts (new versions). But it may appear again.

[Hampedude]

Yeah very good n smart

[dmitry-shibanov]

Hello @giltene. If you do not mind, could you please take a look on this pull request ?

[MaksimZhukov]

Hello @RazorNd! Thank you for the contribution!
Overall looks good to me! I've left a few minor comments

[RazorNd]

@MaksimZhukov thanks for you comments. I have resolved all the problems you are reporting.

[dmitry-shibanov]

Hello @RazorNd. We want to describe our next steps. We will merge your pull request and release a new version next week. We will notify you when we release a new version and update the tag v2.
Thanks for your pull request!