Skip to content

Revert "Add support for Oracle JDK" - #421

Merged
dmitry-shibanov merged 1 commit into
mainfrom
revert-401-oracle-jdk
Dec 5, 2022
Merged

Revert "Add support for Oracle JDK"#421
dmitry-shibanov merged 1 commit into
mainfrom
revert-401-oracle-jdk

Conversation

@dmitry-shibanov

@dmitry-shibanovdmitry-shibanov commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Reverts #401

@fniephaus

fniephaus commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

What's the reason for reverting #401?

@brcrista

brcrista commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

@fniephaus unfortunately, we're not able to support Oracle JDK in setup-java. I'm sorry for the confusion. We should have caught it sooner on the PR and relevant issue.

@fniephaus

fniephaus commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Thanks for the info, @brcrista. Can you elaborate on why Oracle JDK cannot be supported? This action already supports a number of other JDK distributions.

@brcrista

brcrista commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

If you'd like to send me an email at brcrista at github.com, I'd be happy to discuss the blockers with you in more detail.

@dmitry-shibanov
dmitry-shibanov merged commit c3ac5dd into mainDec 5, 2022
@brcrista
brcrista deleted the revert-401-oracle-jdk branch December 5, 2022 16:46
@carimura

carimura commented Dec 5, 2022

Copy link
Copy Markdown

@brcrista@fniephaus i'd like to join this conversation. Will follow up by email.

@Gakk

Gakk commented Dec 6, 2022•
edited
Loading

Copy link
Copy Markdown

Reverting functionality is fine, but doing this by removing version 3.7.0 (#422) was not ideal.

I hope you can push a new release 3.8.0 as soon as possible. We are using Dependabot to update our workflows, and have already updated a lot of repositories to version 3.7.0, which now is failing.

Please issue a new version 3.8.0 that contains the revert of #401, and then basically is equal to versjon 3.6.0. This way all normal upgrade routines for actions and packages will fix all builds.

@brcrista

brcrista commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @Gakk, we'll have a look

@dmitry-shibanov

dmitry-shibanov commented Dec 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Hello @Gakk. Thank you for your report. We've released a new version v3.8.0. The major tag will be updated later.

@Gakk

Gakk commented Dec 6, 2022•
edited
Loading

Copy link
Copy Markdown

We've released a new version v3.8.0

Thank you all for responding so quickly 🚀
After a friendly nudge, Dependabot produced a PR bumping to 3.8.0, and all checks passed 👍

This was referenced Dec 6, 2022
Open
Closed
@php-coderphp-coder mentioned this pull request Dec 8, 2022
Closed
e-korolevskii pushed a commit to e-korolevskii/setup-java that referenced this pull request Dec 9, 2022
@dmitry-shibanov@ascopes@brcrista
Add fix for major coretto version and ea. (#1)
a7975de
* Fix typo in README.md (actions#419)
`diractory` -> `directory`
* Revert "Add support for Oracle JDK (actions#401)" (actions#421)
This reverts commit 6cdf39a.
Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
* adding check for prerelease
* add debug lines
* add minor fix
* expand e2e tests with corretto
Co-authored-by: Ashley <73482956+ascopes@users.noreply.github.com>
Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
sormuras added a commit to sormuras/command-line-interface that referenced this pull request Dec 9, 2022
@sormuras
Back to Oracle's actions
3f59542
actions/setup-java#421
forax pushed a commit to sormuras/command-line-interface that referenced this pull request Dec 9, 2022
@sormuras@forax
Back to Oracle's actions
a9be677
actions/setup-java#421
dmitry-shibanov added a commit that referenced this pull request Feb 7, 2023
@dmitry-shibanov
Revert "Revert "Add support for Oracle JDK (#401)" (#421)"
2f42f7c
This reverts commit c3ac5dd.
@dmitry-shibanovdmitry-shibanov mentioned this pull request Feb 7, 2023
Merged
dmitry-shibanov added a commit that referenced this pull request Feb 7, 2023
@dmitry-shibanov
Revert "Revert "Add support for Oracle JDK (#401)" (#421)" (#450)
3f07048
This reverts commit c3ac5dd.
fniephaus pushed a commit to graalvm/setup-java that referenced this pull request Jun 20, 2023
@dmitry-shibanov@fniephaus
Revert "Revert "Add support for Oracle JDK (actions#401)" (actions#421)…
e865fb9
…" (actions#450)
This reverts commit c3ac5dd.
tdfacer pushed a commit to ifit/setup-java that referenced this pull request Oct 7, 2025
@dmitry-shibanov@brcrista
Revert "Add support for Oracle JDK (actions#401)" (actions#421)
98bafdc
This reverts commit e414b30.
Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
tdfacer pushed a commit to ifit/setup-java that referenced this pull request Oct 7, 2025
@dmitry-shibanov
Revert "Revert "Add support for Oracle JDK (actions#401)" (actions#421)…
92fcf0e
…" (actions#450)
This reverts commit 98bafdc.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@brcristabrcristabrcrista approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dmitry-shibanov@fniephaus@brcrista@carimura@Gakk