add support for alibaba dragonwell by Accelerator1996 · Pull Request #444 · actions/setup-java

Accelerator1996 · 2023-01-12T08:00:20Z

Description:
Add support for Alibaba Dragonwell JDK.

Related issue:
Issue #443

Check list:

README.md
docs/advanced-usage.md
src/distributions/distribution-factory.ts
src/distributions/dragonwell/installer.ts
src/distributions/dragonwell/models.ts
tests/data/dragonwell.json
tests/distributors/dragonwell-installer.test.ts

panticmilos · 2023-01-12T09:15:14Z

hi @Accelerator1996, thank you for the PR, we will take a look at it

Accelerator1996 · 2023-01-28T02:11:13Z

hi @Accelerator1996, thank you for the PR, we will take a look at it

Hello, @panticmilos ! Could you please help me to review the PR? I tested it locally and it was fine. Thank you very much!

Accelerator1996 · 2023-02-06T06:14:34Z

Hi, @panticmilos ! There has been no reply for a long time. I want to know your opinions about this PR. If there is something inappropriate in my PR, I will revise it in time according to your opinions. Thank you so much!

IvanZosimov · 2023-02-06T13:35:11Z

Hi, @Accelerator1996 👋 Currently, we are investigating licenses of the Alibaba Dragonwell JDK. As soon as we finish we will get back to your PR.

Accelerator1996 · 2023-02-06T14:23:41Z

Hi, @Accelerator1996 👋 Currently, we are investigating licenses of the Alibaba Dragonwell JDK. As soon as we finish we will get back to your PR.

Thank you very much!

Accelerator1996 · 2023-02-09T02:52:48Z

I resolve the merge conflict and the local workflow works fine

Accelerator1996 · 2023-02-20T03:51:44Z

Hi, @IvanZosimov! How is the progress of the investigation? Some of our customers hope to simplify the process of deploying JDK through setup-java as soon as possible, and we are very eager to join your project. Thanks!

IvanZosimov · 2023-02-22T14:02:10Z

Hi, @Accelerator1996, unfortunately, we are still in the process. Don't worry, as soon as it's done, we will let you know 😉

Accelerator1996 · 2023-03-10T08:42:22Z

I solved the merge conflict and action workflow passed.

Accelerator1996 · 2023-03-20T07:26:02Z

Hi, @IvanZosimov . How is the progress of the investigation license? if possible, we are willing to provide relevant information to reduce your investigation work.

gdams · 2023-06-16T10:25:24Z

@IvanZosimov can you elaborate on what the licensing concerns are here? Dragonwell is shipped under the same GPL V2 (+ classpath exception) that the other OpenJDK distributions are.

IvanZosimov · 2023-08-25T09:37:05Z

Hi, @Accelerator1996 and @gdams. The question of licenses is solved, and we are starting to review and test the PR.

IvanZosimov · 2023-08-25T12:06:45Z

+ majorVersion = splits[0];
+ version = splits.length >= 3 ? splits.slice(0, 3).join('.') : version;
+ }
+ const edition = majorVersion == '17' ? 'Standard' : 'Extended';


Could you please describe what is the difference between Standard and Extended version of the JDK. Also, I see that all versions have Standard and Extended editions but you have limited 17 to Standard only.

Could you please describe what is the difference between Standard and Extended version of the JDK. Also, I see that all versions have Standard and Extended editions but you have limited 17 to Standard only.
Alibaba Dragonwell Standard Edition: OpenJDK upstream based and have more enhancements, including bug-fixing, security patches, tooling support, etc.
Alibaba Dragonwell Extended Edition: everything in the standard edition, plus: extra customized/significant features optimized for the cloud and widely used in Alibaba's production environment.
And dragonwell17 only has standard edition.

IvanZosimov · 2023-08-25T12:08:40Z

+ const resolvedVersion = matchVersions.length > 0 ? matchVersions[0] : null;
+ if (!resolvedVersion) {
+ const versionsMsg = core.isDebug()
+ ? ' Available versions: ${availableVersions}'
+ : '';
+ throw new Error(
+ `Cannot find satisfied version for ${version}.${versionsMsg}`
+ );
+ }


I'd suggest to compile all these lines into one piece of code with the logic such as: If length of mathedVersions array is 0 -> throw; If not -> take the first satisfied version.

I'd suggest to compile all these lines into one piece of code with the logic such as: If length of mathedVersions array is 0 -> throw; If not -> take the first satisfied version.
But I should return the value of resolvedVersion, so I need to define it as above.

IvanZosimov · 2023-08-25T12:12:39Z

+ if (['8', '11', '17'].includes(majorVersion) != true) {
+ throw new Error('Support dragonwell versions: 8, 11, 17');
+ }


Are we going to change these lines of code when a new version of the Dragonwell revealed? I believe throwing the error after the version matching operation is enough.

I think this is the pre-operation of the full check. If there is an invalid majorVersion, it can reduce the frequency of request to the website.

IvanZosimov · 2023-08-25T12:15:50Z

+ arch = arch.includes('x86') ? 'x64' : arch;
+
+ const availableVersionsUrl =
+ 'https://dragonwell-jdk.io/map_with_checksum.json';


Currently this link doesn't work and it didn't yesterday. The whole https://dragonwell-jdk.io is down. I have concerns about reliability of this API. What do you think?

Currently this link doesn't work and it didn't yesterday. The whole https://dragonwell-jdk.io is down. I have concerns about reliability of this API. What do you think?
Sorry, our website is closed for a few days for some reason. I redeployed this morning.

Accelerator1996 · 2023-08-28T11:30:10Z

@IvanZosimov Hello! I have modified the code according to your opinion, and verified it with actions, but this error is not caused by dragonwell. I hope you can help me to review again when you are free. Thank you very much!

Accelerator1996 · 2023-08-29T02:01:08Z

@IvanZosimov Sorry, I've update code to fix the bug about 'arch' is never reassigned.

Accelerator1996 requested a review from a team as a code owner January 12, 2023 08:00

Accelerator1996 changed the title ~~add dragonwell~~add support for alibaba dragonwellJan 17, 2023

dsame approved these changes Feb 6, 2023
View reviewed changes

Accelerator1996 force-pushed the main branch from db3caec to 5431304Compare February 9, 2023 02:41

mstoodle mentioned this pull request Mar 7, 2023
IBM Semeru (OpenJ9) Support #289
Merged
2 tasks

Accelerator1996 force-pushed the main branch 8 times, most recently from e87f68d to cd9a559Compare March 10, 2023 08:10

Accelerator1996 force-pushed the main branch 3 times, most recently from 383c264 to 40c66d5Compare March 23, 2023 03:22

This was linked to issues Jul 3, 2023
Add Alibaba Dragonwell JDK #443
Closed
Add support for Dragonwell binaries #71
Closed

IvanZosimov suggested changes Aug 25, 2023
View reviewed changes

Comment threadsrc/distributions/dragonwell/installer.ts Outdated

Accelerator1996 force-pushed the main branch 2 times, most recently from 318a89e to 631bb99Compare August 28, 2023 11:16

add support for dragonwell
57d158e

Accelerator1996 force-pushed the main branch from 631bb99 to 57d158eCompare August 28, 2023 11:22

Accelerator1996 closed this Aug 29, 2023

Accelerator1996 mentioned this pull request Aug 29, 2023
add support for dragonwell #532
Merged

Uh oh!

Conversation

Accelerator1996 commented Jan 12, 2023

Uh oh!

panticmilos commented Jan 12, 2023

Uh oh!

Accelerator1996 commented Jan 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Accelerator1996 commented Feb 6, 2023

Uh oh!

IvanZosimov commented Feb 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Accelerator1996 commented Feb 6, 2023

Uh oh!

Accelerator1996 commented Feb 9, 2023

Uh oh!

Accelerator1996 commented Feb 20, 2023

Uh oh!

IvanZosimov commented Feb 22, 2023

Uh oh!

Accelerator1996 commented Mar 10, 2023

Uh oh!

Accelerator1996 commented Mar 20, 2023

Uh oh!

gdams commented Jun 16, 2023

Uh oh!

IvanZosimov commented Aug 25, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Accelerator1996 commented Aug 28, 2023

Uh oh!

Accelerator1996 commented Aug 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Accelerator1996 commented Jan 28, 2023•
edited
Loading

IvanZosimov commented Feb 6, 2023•
edited
Loading