Add cache-key as output

[alexdunae]

Description:
Adds cache-key as an output

Related issue:

• Expose "cache-key" as an output of cache-restore #1129
• provide cache datails as outputs #1181
• Output more information about the cache to support overriding default cache eviction policy #1152

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[ramblingenzyme]

Hi @alexdunae, happy to see this PR.

However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key.

[alexdunae]

Hi @alexdunae, happy to see this PR.

However, I don't think this would close off #1152, as it doesn't capture if the key of the restored cache is different from the primary key.

Correct, it was just related but not closing that issue entirely.

I’m happy to add that extra output if it’s of interest?

[alexdunae]

@ramblingenzyme I've added cache-matched-key as well

[ramblingenzyme]

@alexdunae only just seeing this now, I hadn't made the distinction between "relates" and "closes off" when I read the PR description originally.

Thanks for adding the second key though, much appreciated. 🙇🏽

[alexdunae]

@ramblingenzyme no problem. Anything you need to get this merged?

[ramblingenzyme]

LGTM! 🙇🏽

[alexdunae]

Is it possible to get the second review so this can merge?

[alexdunae]

Circling back on this @ramblingenzyme is there any way to ping another codeowner to get a second review?

[ramblingenzyme]

@alexdunae sorry, I'm not actually a codeowner, not sure how to get their attention either. 😢

[aparnajyothi-y]

Hello @alexdunae, Thank you for this Pull request. We will review and get back to you once we have some feedback on this :)

[mschfh]

Hello @aparnajyothi-y, is there any update on this PR?

[gowridurgad]

Hi @alexdunae,
Thank you for your contribution. It looks like there are some merge conflicts in this PR. Could you please resolve them and ensure your changes are up to date with the latest codebase? This will help us review and merge your PR smoothly.

[gowridurgad]

Hi @alexdunae, just a gentle reminder to resolve the merge conflicts and update this PR with the latest changes when you have a chance. Thanks!

[gowridurgad]

Hi @alexdunae, since this PR has been inactive for some time, we proceeded with implementing the required changes separately in PR #1577, which has now been merged into main.

As the changes are already available through the merged PR, we are closing this one.

Thank you for your contribution and understanding.

[alexdunae]

@gowridurgad sounds great