Skip to content

Check for NODE_AUTH_TOKEN overwritten - #205

Merged
maxim-lobanov merged 10 commits into
actions:mainfrom
zodman:main
Dec 16, 2020
Merged

Check for NODE_AUTH_TOKEN overwritten#205
maxim-lobanov merged 10 commits into
actions:mainfrom
zodman:main

Conversation

@zodman

@zodmanzodman commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

the updated version of #83

If i set the NODE_AUTH_TOKEN and then execute the àctions/setup-node the NODE_AUTH_TOKEN was overwriten with XXXXX and lost my variable value.

What actually fix this:

 - run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV
- name: Use Node.js 12.x
uses: actions/setup-node@v2.1.2
with:
node-version: 12.x
registry-url: https://npm.pkg.github.com/
scope: '@foo'
- run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV

With the patch

 - run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV
- name: Use Node.js 12.x
uses: actions/setup-node@v2.1.2
with:
node-version: 12.x
registry-url: https://npm.pkg.github.com/
scope: '@foo'

@zodmanzodman changed the title adding test for NODE_AUTH_TOKEN overwrittenCheck for NODE_AUTH_TOKEN overwrittenOct 22, 2020
@nikita-bykov

nikita-bykov commented Dec 14, 2020

Copy link
Copy Markdown

Hello @zodman! Thank you for your contribution! We apologize that the review takes too long.
Your changes generally look good for us. Please pull the latest changes from the main branch, rebuild dist file and after that we can merge the PR.

@zodman

Copy link
Copy Markdown
ContributorAuthor

@maxim-lobanov pulled last changes ..

@maxim-lobanov
maxim-lobanov merged commit d06286d into actions:mainDec 16, 2020
@maxim-lobanov

Copy link
Copy Markdown
Contributor

@zodman thank you for contribution!

This was referenced Mar 15, 2021
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
@coderabbitaicoderabbitaiBot mentioned this pull request Mar 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zodman@nikita-bykov@maxim-lobanov@MaksimZhukov