Support .nvmrc by hkaur008 · Pull Request #338 · actions/setup-node

hkaur008 · 2021-09-30T19:38:01Z

Description

In scope of this pull request we add Node.js version file support. This pull request introduces new optional input: node-version-file, that accepts path (relative to repository root) to file containing Node.js version (for example .nvmrc).

The action will search for the Node.js version file and read the Node.js version if the file exists. If both inputs node-version and node-version-file are specified, the action will throw a warning and the node-version input will be used.

Example of yml

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2with:
node-version-file: '.nvmrc'
- run: npm install
- run: npm test

Related issue: #32

What's done:

- Adding Node.js version file support
- Adding tests
- Updating documentation

… '.nvmrc'

This reverts commit 820128a.

… pull209

hkaur008 · 2021-10-04T23:20:35Z

Is this reviewable now @Xlient I think we did all the tasks !

added link to README * migrated contents of version-file-workflow.yml to versions.yml * further refactored parseNodeVersionFile() & tests * removed type annotations in catch ()

* added fail-fast to strategy in versions.yml * refactored logic in main that was causing test to fail

* fix grammar in README & Advance usage docs * update example in action.yml

Since actions/setup-node#338, GH's setup-node Action understands `.nvmrc` files. This makes our `guardian/actions-setup-node` fork somewhat redundant now. Move to GH's Action so we can deprecate our fork.

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.2 to 4.5.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.5.2...v4.5.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

TJMcCarthy95and others added 3 commits November 1, 2020 17:30

Implemented support for repository defined node version files such as…
c3812bd
… '.nvmrc'

Expand node version file support to include lts based codenames
a0d376d

fixed missing brackets and merged main
75c8584

hkaur008 marked this pull request as draft September 30, 2021 19:41

hkaur008 changed the title ~~Pull 209~~Support .nvmrcSep 30, 2021

Xlientand others added 13 commits September 30, 2021 20:22

test commit ignore
820128a

Revert "test commit ignore"
ac10981
This reverts commit 820128a.

fixed merge conflicts
bca2818

Refactored code and removed redundant logic
82441b3

created test workflow & nvmrc file
052bc8b

updated nvmrc & added ignore paths
7f7335c

fixed error in workflow file
1f26500

Update version-file-workflow.yml
510ffc9

fixed merge conflicts
2579409

Merge branch 'pull209' ofhttps://github.com/hkaur008/setup-nodeinto…
1650600
… pull209

refactored installer.test.ts
2fb803b

deleted node-version-file
42c8cd4

code syntax matched
e471f47

Xlient suggested changes Oct 5, 2021
View reviewed changes

Comment threadsrc/installer.ts Outdated
Comment thread__tests__/installer.test.ts Outdated

Xlient added 2 commits October 5, 2021 15:01

moved node version section in README to advanced usage
b1ed0c3
added link to README * migrated contents of version-file-workflow.yml to versions.yml * further refactored parseNodeVersionFile() & tests * removed type annotations in catch ()

removed test logic in ParseNodeVersionFile for lts and partial matching
c178bbb

Xlient force-pushed the pull209 branch from 7988930 to c178bbbCompare October 5, 2021 16:58

hkaur008and others added 7 commits October 5, 2021 23:00

removed extra tabs (versions.yml)
eb7c472

removed extra tabs (versions.yml)
7fb46ef

removed unnessary test
ec979d0
* added fail-fast to strategy in versions.yml * refactored logic in main that was causing test to fail

Delete index.js
fe30936

added correct path to version file
7d40f6c

build successful
6e5214f

build successful
5b7f417

konradpabjan approved these changes Nov 16, 2021
View reviewed changes

Comment threaddocs/advanced-usage.md Outdated
Comment threaddocs/advanced-usage.md Outdated
Comment threadREADME.md Outdated
Comment threadsrc/main.ts Outdated
Comment threadaction.yml Outdated

adds path to error output
4e4d327
* fix grammar in README & Advance usage docs * update example in action.yml

bryanmacfarlane reviewed Nov 17, 2021
View reviewed changes

Comment threadsrc/main.ts

bryanmacfarlane reviewed Nov 17, 2021
View reviewed changes

Comment threadsrc/main.ts

hkaur008 added 4 commits November 22, 2021 18:27

import os = require('os'); moved back
a2b4d83

Merge remote-tracking branch 'refs/remotes/origin/pull209' into pull209
e75d7c1

build
0f9cdab

removed n-node-version file
a7ed1ce

MaksimZhukov approved these changes Nov 28, 2021
View reviewed changes

MaksimZhukov merged commit d08cf22 into actions:mainNov 29, 2021

jameswald mentioned this pull request Nov 30, 2021
Support .nvmrc #32
Closed

travi mentioned this pull request Nov 30, 2021
simplify use of the nvmrc file form8ion/github-actions-node-ci#479
Closed

ganta mentioned this pull request Dec 2, 2021
Add support for asdf format as Node.js version file #373
Merged
2 tasks

y-nk mentioned this pull request Dec 10, 2021
Implicit set of node-version based on .nvmrc #377
Closed

akash1810 mentioned this pull request Jan 5, 2022
Use GitHub Actions for CI guardian/gateway#1349
Merged

This was referenced Jan 10, 2022
Update actions/setup-node to v2 hashicorp/vscode-terraform#897
Merged
use node-version-file with actions/setup-node@v2 hashicorp/js-releases#14
Merged

akash1810 mentioned this pull request Jan 20, 2022
Adds generic sbt node snyk workflow guardian/.github#11
Merged

akash1810 mentioned this pull request Jan 27, 2022
chore(ci): Use GH's setup-node Action guardian/cdk#1062
Merged

revolunet mentioned this pull request Mar 7, 2022
ci: switch from gitlab to github SocialGouv/cdtn-admin#723
Merged

jablko mentioned this pull request May 2, 2022
Support lts/-n aliases #481
Merged
2 tasks

pepopowitz mentioned this pull request Jun 17, 2022
fix: resolve broken builds by updating package-lock and specify node version via .nvmrc camunda/camunda-docs#976
Merged

pepopowitz mentioned this pull request Jun 28, 2022
Synchronize node version between CI & local camunda/camunda-docs#997
Closed
2 tasks

sndrs mentioned this pull request Oct 10, 2022
retire guardian/actions-setup-nodeguardian/actions-setup-node#9
Closed

stefafafan mentioned this pull request Dec 6, 2022
Suggestion: perl-version-file input support? shogo82148/actions-setup-perl#1359
Closed

stephenkao mentioned this pull request Mar 7, 2023
Update to Node 18.15 CDCgov/prime-reportstream#8631
Merged

ahukkanen mentioned this pull request Mar 21, 2023
Use node-version-file configuration for the CI decidim/documentation#119
Merged

chenrui333 mentioned this pull request Dec 21, 2023
feat: bump to use node20 runtime peaceiris/actions-hugo#641
Merged

Navigation Menu

Uh oh!

Support .nvmrc - #338

Support .nvmrc#338
MaksimZhukov merged 67 commits into
actions:mainfrom
hkaur008:pull209

hkaur008 commented Sep 30, 2021•
edited by MaksimZhukov
Loading

Uh oh!

hkaur008 commented Oct 4, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

hkaur008 commented Sep 30, 2021• edited by MaksimZhukov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Example of yml

Related issue: #32

What's done:

Uh oh!

hkaur008 commented Oct 4, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

hkaur008 commented Sep 30, 2021•
edited by MaksimZhukov
Loading