Skip to content

Log npm & yarn versions - #76

Closed
Andarist wants to merge 1 commit into
actions:mainfrom
Andarist:log-npm-yarn-versions
Closed

Log npm & yarn versions#76
Andarist wants to merge 1 commit into
actions:mainfrom
Andarist:log-npm-yarn-versions

Conversation

@Andarist

Copy link
Copy Markdown

This is helpful debug info - IMHO makes sense to always include it.

@milesj

Copy link
Copy Markdown

Was just looking for this. Was hoping this action would log info similar to actions/checkout.

@bryanmacfarlane

Copy link
Copy Markdown
Contributor

I think we should protect the outputting of the version(s) with io.which call. e.g. yarn may or may not be installed. even in the case where a version spec could not be met it may not be installed. could make into a common function execIfexist(tool, arg).

@bryanmacfarlanebryanmacfarlane added the enhancement New feature or request label Jan 20, 2021
@Andarist
Andaristforce-pushed the log-npm-yarn-versions branch from 6a1871c to f69d468CompareApril 8, 2022 07:54
@Andarist
Andarist changed the base branch from master to mainApril 8, 2022 07:54
@Andarist
Andarist requested a review from a teamApril 8, 2022 07:54
@Andarist

Copy link
Copy Markdown
Author

@bryanmacfarlane i've implemented your suggested changes. Could you take another look at this PR?

@dmitry-shibanov

Copy link
Copy Markdown
Contributor

Hello everyone. I'm going to close the pull request in favour of this #368

deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
…ions#76)
Bumps [all-contributors-cli](https://github.com/all-contributors/all-contributors-cli) from 6.17.2 to 6.19.0.
- [Release notes](https://github.com/all-contributors/all-contributors-cli/releases)
- [Commits](all-contributors/cli@v6.17.2...v6.19.0)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Andarist@milesj@bryanmacfarlane@dmitry-shibanov