Skip to content

Add poetry caching support - #281

Merged
brcrista merged 15 commits into
actions:mainfrom
patrick91:feature/poetry-caching
Mar 31, 2022
Merged

Add poetry caching support#281
brcrista merged 15 commits into
actions:mainfrom
patrick91:feature/poetry-caching

Conversation

@patrick91

@patrick91patrick91 commented Nov 24, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Description:
A continuation of #266 to add support for caching poetry's virtualenv

This is still draft, I need to implement the actual caching, but it is good to start running the tests early :)

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@patrick91
patrick91force-pushed the feature/poetry-caching branch from 7dc18af to 63a127cCompareNovember 24, 2021 19:58
patrick91
patrick91 commented Nov 24, 2021
View reviewed changes
Comment thread__tests__/cache-restore.test.ts
Comment threadsrc/cache-distributions/poetry-cache.ts
Comment thread.github/workflows/e2e-cache.yml
@patrick91
patrick91force-pushed the feature/poetry-caching branch from f1b64ab to 63a127cCompareNovember 27, 2021 11:27
@patrick91
patrick91 marked this pull request as ready for review November 27, 2021 17:20
@patrick91

patrick91 commented Nov 27, 2021

Copy link
Copy Markdown
ContributorAuthor

I've tested this here: https://github.com/patrick91/test-action-poetry-cache/runs/4341929604?check_suite_focus=true

@patrick91
patrick91force-pushed the feature/poetry-caching branch from da28c46 to 99a5f2bCompareNovember 27, 2021 17:20
@nikita-bykovnikita-bykov mentioned this pull request Dec 15, 2021
Closed
@floatingpurr

floatingpurr commented Dec 22, 2021

Copy link
Copy Markdown

Great improvement!

@browniebrokebrowniebroke mentioned this pull request Jan 14, 2022
Closed
@dimaqq

dimaqq commented Jan 20, 2022

Copy link
Copy Markdown

Keep going! :)

@Zxilly

Zxilly commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Any update on this?

@patrick91
patrick91force-pushed the feature/poetry-caching branch from 99a5f2b to 0f8afe0CompareJanuary 31, 2022 14:39
@patrick91

patrick91 commented Jan 31, 2022

Copy link
Copy Markdown
ContributorAuthor

Any update on this?

I've rebased the PR, but we have to wait the mainteners to review the PR. They are probably busy with other priorities so we'll probably have to wait a bit 😊

@DMRobertsonDMRobertson mentioned this pull request Feb 2, 2022
Merged
dmitry-shibanov
dmitry-shibanov reviewed Feb 18, 2022
View reviewed changes
Comment thread.github/workflows/e2e-cache.yml Outdated
Comment thread__tests__/data/.tool-versions Outdated
Comment threadsrc/cache-distributions/poetry-cache.ts Outdated
Comment threadsrc/cache-distributions/poetry-cache.ts Outdated
@dmitry-shibanov

dmitry-shibanov commented Feb 18, 2022

Copy link
Copy Markdown
Contributor

Could you please sync with the main branch ?

@patrick91
patrick91force-pushed the feature/poetry-caching branch from 0f8afe0 to 7f80679CompareFebruary 18, 2022 17:25
@patrick91

patrick91 commented Feb 18, 2022

Copy link
Copy Markdown
ContributorAuthor

I closed this by mistake :) @dmitry-shibanov the PR should be up to date now!

@patrick91patrick91 reopened this Feb 18, 2022
@dmitry-shibanov

dmitry-shibanov commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

Hello @patrick91. Could you please run these commands:

  • npm run build
  • npm run format

@patrick91

patrick91 commented Feb 21, 2022

Copy link
Copy Markdown
ContributorAuthor

@dmitry-shibanov done!

@patrick91
patrick91force-pushed the feature/poetry-caching branch from 92cd993 to a1cc6a7CompareFebruary 21, 2022 17:02
@patrick91

patrick91 commented Feb 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Not 100% sure why the CI failied, I'll try to take a look soon, maybe a rebase helps 😊

@patrick91
patrick91force-pushed the feature/poetry-caching branch 2 times, most recently from 57c8ee5 to a580a2dCompareFebruary 26, 2022 04:19
@patrick91

patrick91 commented Mar 7, 2022

Copy link
Copy Markdown
ContributorAuthor

Rebased this again :)

@patrick91
patrick91force-pushed the feature/poetry-caching branch from a580a2d to 86304bcCompareMarch 7, 2022 02:31
@m0ar

m0ar commented Mar 9, 2022

Copy link
Copy Markdown

Super stoked for this! Keep the good work up @patrick91 💘

@rc-mattschwager

rc-mattschwager commented Mar 25, 2022

Copy link
Copy Markdown

Friendly bump here, can a maintainer at least approve the CI workflows so the submitter can see if everything's still passing?

First-time contributors need a maintainer to approve running workflows.

@patrick91
patrick91force-pushed the feature/poetry-caching branch from 86304bc to aac0ef9CompareMarch 26, 2022 03:54
@patrick91
patrick91 requested a review from a teamMarch 26, 2022 03:54
@patrick91

patrick91 commented Mar 29, 2022

Copy link
Copy Markdown
ContributorAuthor

@dmitry-shibanov pipenv seems to fail on main too, shall I sent a PR to try and fix that?

Also I did rebase and ran npm run build && npm run format, but the check is still failing 🤔

image

@brcrista

brcrista commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

@patrick91 I looked at that failure briefly but couldn't figure it out. If you know what the issue is and want to submit a separate PR, that would be great. Otherwise, we don't need to block this on that.

What you do need to fix is the check-dist failure. You can just download the artifact from that run and check it in.

@patrick91

patrick91 commented Mar 30, 2022

Copy link
Copy Markdown
ContributorAuthor

@brcrista done 😊

brcrista
brcrista reviewed Mar 30, 2022
View reviewed changes
Comment threadsrc/cache-distributions/poetry-cache.ts Outdated
patrick91and others added 2 commits March 30, 2022 22:41
@patrick91@brcrista
Use \n instead of os.EOL
6c31eb3
Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
@patrick91
Update dist
7aa3e95
brcrista
brcrista approved these changes Mar 31, 2022
View reviewed changes

@brcristabrcrista left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @patrick91!

@brcrista
brcrista merged commit 6c56602 into actions:mainMar 31, 2022
@Zxilly

Zxilly commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

nice work

@patrick91
patrick91 deleted the feature/poetry-caching branch March 31, 2022 21:44
@m0ar

m0ar commented Apr 1, 2022

Copy link
Copy Markdown

@patrick91 Thank you! 🧁 💘

@tiwarishubtiwarishub mentioned this pull request Apr 1, 2022
Merged
2 tasks
@tonytony mentioned this pull request Apr 2, 2022
Merged
tony added a commit to vcs-python/libvcs that referenced this pull request Apr 2, 2022
@tony
ci(tests): Use poetry cache action (#316)
87163d0
As of yesterday, `@actions/setup-python@v3` supports this via v3.1.0: [Release](https://github.com/actions/setup-python/releases/tag/v3.1.0), [Tag](https://github.com/actions/setup-python/tree/v3.1.0), actions/setup-python#281
```yaml
steps:
- uses: actions/checkout@v3
- name: Install poetry
run: pipx install poetry
- uses: actions/setup-python@v3
with:
python-version: '3.9'
cache: 'poetry'
- run: poetry install
- run: poetry run pytest
```
See also: python-poetry/poetry#4205
tony added a commit to vcs-python/libvcs that referenced this pull request Apr 2, 2022
@tony
tests(ci): Fix python version with poetry caching and actions/setup-p…
5637efc
…ython@v3
poetry install will pick up the python binary at the time it was
installed (before actions/python ran) so it looks like poetry env needs
to be set manually.
https://github.com/actions/setup-python/releases/tag/v3.1.0https://github.com/actions/setup-python/tree/v3.1.0actions/setup-python#281
@tonytony mentioned this pull request Apr 3, 2022
Closed
5 tasks
@jaagutjaagut mentioned this pull request May 17, 2022
Closed
1 task
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
@brcrista
Merge pull requestactions#281from patrick91/feature/poetry-caching
f5e4caf
Add poetry caching support
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@dmitry-shibanovdmitry-shibanovdmitry-shibanov left review comments
@brcristabrcristabrcrista approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@patrick91@floatingpurr@dimaqq@Zxilly@dmitry-shibanov@m0ar@rc-mattschwager@brcrista