Skip to content

Rework pipenv caching test - #375

Merged
brcrista merged 7 commits into
actions:mainfrom
vsafonkin:v-vsafonkin/fix-pipenv-cache-test
Apr 4, 2022
Merged

Rework pipenv caching test#375
brcrista merged 7 commits into
actions:mainfrom
vsafonkin:v-vsafonkin/fix-pipenv-cache-test

Conversation

@vsafonkin

@vsafonkinvsafonkin commented Apr 3, 2022

Copy link
Copy Markdown

Description:
Pipenv cache tests are broken at the moment. Example of the failed run: link

In order to fix these tests:

  • Added Pipfile with numpy and pandas packages to avoid of creating new pipenv environment each time (pipenv creates new environment if Pipfile is not exist). The versions of numpy and pandas are hardcoded in the Pipfile to avoid regenerating cache.
  • Regenerated Pipfile.lock according new Pipfile
  • Added txt file for pipenv cache tests with dependency path
  • Bump to actions/checkout@v3

Test build: link

Related issue:
#376

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@vsafonkin
vsafonkin marked this pull request as ready for review April 4, 2022 10:43
@vsafonkin
vsafonkin requested a review from a teamApril 4, 2022 10:43
@brcrista
brcrista merged commit 7885ec3 into actions:mainApr 4, 2022
@vsafonkin
vsafonkin deleted the v-vsafonkin/fix-pipenv-cache-test branch April 4, 2022 13:39
adilosa added a commit to adilosa/setup-python that referenced this pull request Apr 19, 2022
* upstream/main: (33 commits)
Fix virtual-env toolcache links
Updated @actions/cache (actions#382)
ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (actions#379)
Cache hit output (actions#373)
Add pyton-version to setup PyPy output (actions#365)
Rework pipenv caching test (actions#375)
Update README.md to fix setup-python version in example (actions#368)
dist fix (actions#367)
Cache on ghes (actions#363)
Update dist
Use `\n` instead of `os.EOL`
Update dist
Initialise pyproject.toml
Build and format
Remove console.log
Remove unused file
Reduce test matrix
Parse values from poetry
Release
Add more tests
...
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
* Rework python-pipenv-dependencies-caching test
* Update Pipfile.lock hash in the tests
* Rework python-pipenv-dependencies-caching-path test
* Set location for pipenv test
* Remove requests package from tests
* Test pipenv without caching
* Enable pipenv cache
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vsafonkin@brcrista