Add support to .tool-version file format by elpic · Pull Request #588 · actions/setup-python

elpic · 2023-01-17T21:36:22Z

Create a function to parse tool-version (asdf-vm) format, add the associated tests, and updated the documentation

Ticket-ID: #571

Description:

Create a function to parse tool-version (asdf-vm) format, add the associated tests, and updated the documentation

Related issue:

#571

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

e-korolevskii · 2023-01-18T08:44:56Z

Hello @elpic!
Thanks for your contribution! Some workflows failed, let's try to complete them.
Could you please run the format and build commands?

elpic · 2023-01-20T13:15:42Z

Would it be possible for you @dmitry-shibanov to run the failing tests?

IvanZosimov · 2023-01-31T10:33:59Z

+ let pythonVersion: string | undefined;
+
+ // Try to find the version in tool-version file
+ const found = contents.match(/^(?:python\s+)?v?(?<version>[^\s]+)$/m);


I think that the regular expression we used in line 34 won't work with PyPy versions correctly. In the .tool-version, PyPy format doesn't have v: python pypy3.9-3.7.11, but the action's python-versioninput should include v before the PyPy version: python pypy3.9-v3.7.11. I think we can adapt the matched version of PyPy (basically just add v before the PyPy version) and add some e2e tests both for Python and PyPy installation from .tool-version.

From what I saw from pypy version of python in asdf-vm you have the following version
python pypy3.9-3.7.11
Is that not correct?

It's correct version syntax for .tool-version file, but incorrect python-version syntax for setup-python. Check the supported syntax here and, please, pay attention to the letter v.
.tool-version content your regex result setup-python requirement
python pypy3.9-3.7.11 pypy3.9-3.7.11 pypy3.9-v3.7.11

@elpic may be could add a if/else condition here https://github.com/actions/setup-python/pull/588/files#diff-0ac8bdebd0ca13af3640499ecf1203abc825161011f13f9ca45c734bfe80128eR51 so that we parse format only for .tool-verions file

dmitry-shibanov · 2023-02-21T09:14:45Z

Hello @elpic, just a gentle ping.

e-korolevskii · 2023-03-14T07:33:17Z

Hello @elpic, just a gentle ping.

elpic · 2023-03-14T11:01:57Z

Sorry I will take a look in a moment

plukevdh · 2023-04-08T05:02:15Z

Any chance this gets reviewed soon?

camflan · 2023-05-19T15:06:12Z

Any chance this gets reviewed soon?

Looks like there are a few checks failing that need addressed. @elpic any chance you have time to turn this PR green? 😅

Create a function to parse tool-version (asdf-vm) format, add the associated tests, and updated the documentation Ticket-ID: #571

Rollback a not abot advanced usage on how to use the file and not use the GITHUB_WORKSPACE since it was removed in a previous PR

Build the project using `npm run build` and run prettier using `npm run format`

elpic · 2023-05-31T12:03:55Z

Sorry for the delay. The code is formatted now

tanguyantoine · 2023-11-30T08:41:27Z

@elpic this is a great improvement for this action 👏

tanguyantoine · 2024-01-04T16:57:02Z

Can we get this merged?

aiwilliams · 2024-08-29T14:08:33Z

This would be a great addition.

1stvamp · 2024-11-13T12:00:50Z

Another +1 for merging this 🙏

edubacco · 2025-02-12T14:25:24Z

I'd love to have this merged 🙏

mahabaleshwars · 2025-02-13T03:37:58Z

Hello @elpic,
There are conflicts that need to be resolved before merging. Please resolve these conflicts and address any other issues. Once resolved, we will review it before merging.

mahabaleshwars · 2025-02-25T03:37:05Z

Hi @elpic,
Just a friendly reminder to resolve the conflicts when you get a chance. Once everything is addressed, we’ll be happy to review and merge. Let us know if you need any help!

mahabaleshwars · 2025-03-25T03:06:09Z

Hi @elpic,

We are closing this Pull Request as this feature is implemented in PR #1043.
Please feel free to reach out if you need any further assistance.

elpic requested a review from a team as a code owner January 17, 2023 21:36

elpic mentioned this pull request Jan 17, 2023
Unable to use asdf-vm based version-file #571
Closed
1 task

dmitry-shibanov reviewed Jan 18, 2023
View reviewed changes

Comment threadsrc/setup-python.ts Outdated

dmitry-shibanov reviewed Jan 18, 2023
View reviewed changes

Comment threaddocs/advanced-usage.md Outdated

elpic requested a review from dmitry-shibanov January 18, 2023 11:23

dmitry-shibanov reviewed Jan 18, 2023
View reviewed changes

Comment threaddocs/advanced-usage.md Outdated

elpic requested a review from dmitry-shibanov January 18, 2023 13:02

elpic force-pushed the main branch from 1c97928 to 730345fCompare January 18, 2023 14:22

IvanZosimov reviewed Jan 31, 2023
View reviewed changes

elpic force-pushed the main branch from 730345f to 73466ffCompare March 14, 2023 11:52

elpic force-pushed the main branch from 33dd2a1 to 73466ffCompare March 24, 2023 14:32

This was referenced May 19, 2023
feat: Utilize the.tool-versions file to set expected Go version actions/setup-go#375
Closed
Parse .tool-versions file to determine Go version actions/setup-go#376
Closed
utilize .tool-versions file to resolve terraform version hashicorp/setup-terraform#323
Open

elpic added 3 commits May 31, 2023 09:02

Add support to .tool-version file format
892baae
Create a function to parse tool-version (asdf-vm) format, add the associated tests, and updated the documentation Ticket-ID: #571

Fix suggestios done in code review
3d009a5
Rollback a not abot advanced usage on how to use the file and not use the GITHUB_WORKSPACE since it was removed in a previous PR

Fix style issues and build
59a7889
Build the project using `npm run build` and run prettier using `npm run format`

elpic force-pushed the main branch from 73466ff to 59a7889Compare May 31, 2023 12:02

dusan-trickovic linked an issue Jul 13, 2023 that may be closed by this pull request
Unable to use asdf-vm based version-file #571
Closed
1 task

9777410929 approved these changes Aug 18, 2023
View reviewed changes

devmotion mentioned this pull request Oct 2, 2023
[Feature Request] Support .tool-versions files julia-actions/setup-julia#167
Open

veimox mentioned this pull request Mar 13, 2025
feat: support reading version from mise.toml #1051
Closed
2 tasks

mahabaleshwars closed this Mar 25, 2025

Uh oh!

Conversation

elpic commented Jan 17, 2023

Uh oh!

e-korolevskii commented Jan 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elpic commented Jan 20, 2023

Uh oh!

IvanZosimovJan 31, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elpicMar 14, 2023

Choose a reason for hiding this comment

Uh oh!

IvanZosimovMar 14, 2023

Choose a reason for hiding this comment

Uh oh!

tanguyantoineNov 30, 2023

Choose a reason for hiding this comment

Uh oh!

dmitry-shibanov commented Feb 21, 2023

Uh oh!

e-korolevskii commented Mar 14, 2023

Uh oh!

elpic commented Mar 14, 2023

Uh oh!

plukevdh commented Apr 8, 2023

Uh oh!

camflan commented May 19, 2023

Uh oh!

elpic commented May 31, 2023

Uh oh!

tanguyantoine commented Nov 30, 2023

Uh oh!

tanguyantoine commented Jan 4, 2024

Uh oh!

aiwilliams commented Aug 29, 2024

Uh oh!

1stvamp commented Nov 13, 2024

Uh oh!

edubacco commented Feb 12, 2025

Uh oh!

mahabaleshwars commented Feb 13, 2025

Uh oh!

mahabaleshwars commented Feb 25, 2025

Uh oh!

mahabaleshwars commented Mar 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

IvanZosimovJan 31, 2023•
edited
Loading