Uh oh!
There was an error while loading. Please reload this page.
Add cache-save: false option - #762
Conversation
346329c to
59d62e4Compare59d62e4 to
8f0a0b0Compareakx
commented
Dec 12, 2023
Rebased on v5. @dmitry-shibanov Could you review this, please? |
ozancaglayan
commented
May 23, 2024
Could someone please take an action for this PR and release a new version? 🙏 |
ozancaglayan
commented
Oct 9, 2024
@akx can you request review from the maintainers here? @priya-kinthali@aparnajyothi-y@HarithaVattikuti |
akx
commented
Oct 10, 2024
@ozancaglayan As an external, I have no option to request a reviewer. GitHub does say "actions/setup-actions-team was requested for review"... |
Also remove setup-python caching hacks. Refs: actions/setup-python#807actions/setup-python#762actions/setup-python#751 Reverts: 662a97189d73b1e8ef6dbf65666c
Hello Everyone, Thank you for your contribution with this PR. We truly appreciate your understanding and patience, and we encourage you to continue sharing any further thoughts or suggestions you may have. |
aparnajyothi-y
commented
Jan 22, 2025
Hello @akx, Please let us know if you still need any more clarifications/concerns on the above. |
akx
commented
Jan 22, 2025
It's opt-in, for corner cases as described in the PR description.
Yes, perfectly on purpose, as described in the PR description.
Any change or improvement does that, really. Do note that this PR does have tests and documentation included. @aparnajyothi-y Feel free to close this if you still believe it's not welcome. |
medmunds
commented
Apr 4, 2025
This would also allow using the cache while avoiding cache poisoning vulnerabilities from PRs: - uses: actions/setup-python@v5with:
python-version: "3.13"cache: "pip"# For anything PR-related, treat the cache as restore-only:cache-save: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}Without this option, workflow security audits currently recommend removing |
akx
commented
Sep 16, 2025
For people following at home, |
Description
This PR adds a new
cache-save: falseoption to opt out of saving the cache. As described in the documentation:Related issue
I only found the related issue after implementing this: #751.
Check list