DOC: Is return necessary after setFailed?

[pllim]

Hello. If I decide to use core.setFailed(...) but there are code after that runs if it did not fail, do I need to also add a return or does setFailed automatically terminates the Action? It is not clear from the README.

Example logic:

import * as core from "@actions/core";

async function run() {
 if (condition1) {
 core.setFailed("You should not have done that");
 // Do I need return; here?
 }
 do_stuff_on_success();
}

[thboop]

Hey @pllim thanks for the information! setFailed does not automatically terminate the process, you need to do that manually. You can do that via a return, or following an example like our typescript actions

I think the docs here are good now, but if you have an idea for how to improve them, please submit a pr!