Skip to content

Add execution state information - #499

Merged
thboop merged 3 commits into
actions:masterfrom
8398a7:issue/371
Jun 26, 2020
Merged

Add execution state information#499
thboop merged 3 commits into
actions:masterfrom
8398a7:issue/371

Conversation

@8398a7

@8398a78398a7 commented Jun 14, 2020•
edited by thboop
Loading

Copy link
Copy Markdown
Contributor

I created a PR because I wanted this feature too.

I've been dealing with the following workaround, but it would be nice to be able to use it in the library.
https://github.com/8398a7/action-slack/blob/v3.1.0/src/client.ts#L143

Resolves: #371

@8398a78398a7 changed the title Add execution state information (#371)Add execution state informationJun 14, 2020
@8398a7

8398a7 commented Jun 14, 2020

Copy link
Copy Markdown
ContributorAuthor

I would like to add GITHUB_JOB as well, if that's OK with you.
https://github.com/8398a7/action-slack/blob/v3.1.0/src/client.ts#L150

thboop
thboop reviewed Jun 19, 2020
View reviewed changes
Comment threadpackages/github/src/context.ts Outdated
workflow: string
action: string
actor: string
runNumber: string

@thboopthboopJun 19, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @8398a7 , runNumber and runId are numbers in the rest api , we should match that here.

@8398a78398a7Jun 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.
I fixed it in 728bcb5.

@thboop

thboop commented Jun 25, 2020

Copy link
Copy Markdown
Collaborator

I would like to add GITHUB_JOB as well, if that's OK with you.

Sounds great! This PR looks good, do you want to open a separate pr for this, or amend this one?

thboop
thboop approved these changes Jun 25, 2020
View reviewed changes

@thboopthboop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@8398a7

8398a7 commented Jun 25, 2020

Copy link
Copy Markdown
ContributorAuthor

Sounds great! This PR looks good, do you want to open a separate pr for this, or amend this one?

Thank you. I've made some changes to this PR.

I made a mistake in the template for the commit message. I did a force push to fix it. Sorry.

thboop
thboop approved these changes Jun 26, 2020
View reviewed changes

@thboopthboop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job changes LGTM

@thboop
thboop merged commit 2d47f7b into actions:masterJun 26, 2020
@thboop

thboop commented Jun 26, 2020

Copy link
Copy Markdown
Collaborator

Going to include this in the 4.0.0 release. Thank you for the contribution!

#507

@dependabotdependabotBot mentioned this pull request Mar 12, 2021
Closed
@snyk-botsnyk-bot mentioned this pull request Jul 20, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Jul 27, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Dec 26, 2022
Open
@pllimpllim mentioned this pull request Dec 29, 2022
Merged
@Randyblo7Randyblo7 mentioned this pull request Aug 21, 2023
Open
@GanjahmanvenenodediosGanjahmanvenenodedios mentioned this pull request Oct 5, 2023
Open
@CxsLucyferCxsLucyfer mentioned this pull request Jan 29, 2024
Open
@DanyRay420DanyRay420 mentioned this pull request Feb 23, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thboopthboopthboop approved these changes
@bryanmacfarlanebryanmacfarlaneAwaiting requested review from bryanmacfarlane

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@actions/github should populate Run Number and Run ID

2 participants

@8398a7@thboop