Uh oh!
There was an error while loading. Please reload this page.
Use posix archive format - #533
Conversation
2657240 to
ca5af8eCompareSigned-off-by: Sora Morimoto <sora@morimoto.io>
ca5af8e to
2de8727Comparesmorimoto
commented
Jul 29, 2020
@aiqiaoy This should now be in a mergeable state. Could you review it? |
smorimoto
commented
Jul 31, 2020
CC: @joshmgross |
smorimoto
commented
Jul 31, 2020
Related issue: actions/cache#326 |
konradpabjan
left a comment
There was a problem hiding this comment.
Just a small request to change the package version to 1.0.2 in all the places. Overall looks good! Thanks for submitting this PR ❤️
CC @aiqiaoy
| } | ||
| } | ||
| const args = [ | ||
| '--posix', |
There was a problem hiding this comment.
I looked over the previous PR, I think this won't cause any compat issues. No objections from me 👍
There was a problem hiding this comment.
Yeah, this shouldn't cause any problems.
Uh oh!
There was an error while loading. Please reload this page.
1b2a3cd to
7737589CompareSigned-off-by: Sora Morimoto <sora@morimoto.io>
7737589 to
3be5c33Comparesmorimoto
commented
Aug 5, 2020
@konradpabjan Thanks for your review. |
aiqiaoy
commented
Aug 5, 2020
Yeah sorry I was on-call when I reviewed the original PR and completely forgot about following up. Looks good! |
konradpabjan
commented
Aug 5, 2020
Version |
smorimoto
commented
Aug 5, 2020
@konradpabjan Thanks again for your work :) |
smorimoto
commented
Aug 5, 2020
@aiqiaoy No worries! I sometimes do something similar to you. |
See #475 for details.
Closes: actions/cache#326