Uh oh!
There was an error while loading. Please reload this page.
Prefer using GNU tar - #553
Closed
dhadka wants to merge 1 commit into
Closed
Conversation
dhadka
commented
Aug 11, 2020
| if (filePath) { | ||
| return filePath | ||
| } | ||
| /** |
ContributorAuthor
There was a problem hiding this comment.
Most of the which method is now in findInPath. Most of the changes are just indentation...use the "hide whitespace changes" option for easier viewing.
6 tasks
| let versionOutput = '' | ||
| try { | ||
| await exec.exec(`${app} --version`, [], { | ||
| await exec.exec(`"${app}" --version`, [], { |
Contributor
There was a problem hiding this comment.
Suggested change
| awaitexec.exec(`"${app}" --version`,[],{ | |
| awaitexec.exec(app,['--version'],{ |
smorimoto
commented
Sep 24, 2020
Contributor
@dhadka Is there any progress on this? If you are busy, I can take over this. |
casey added a commit
to casey/bendy
that referenced
this pull request
Nov 19, 2020
The BSD Tar that ships with macOS has a bug that can cause it to create empty tar files, which can cause bad caches to be created on GitHub Actions. An example of this error is here: https://github.com/P3KI/bendy/pull/48/checks?check_run_id=1421741031#step:9:39 And here are a couple discussions: actions/cache#403actions/toolkit#553 As a workaround, this patch installs GNU Tar on macos in all jobs that use the cache. It also adds `0-` to all cache keys to make sure that future CI builds don't hit the old, corrupted cache. This can be removed once `Cargo.lock` changes.
dhadka
commented
May 3, 2021
ContributorAuthor
Closing for #610 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a variety of actions/cache issues related to differences between BSD and GNU tar.
The old
whichfunction already scanned the system path for the executable, but would return the first hit. This change moves most of this functionality into a new method,findInPath, which will return a list of all matches on the system path. This allows the cache module to scan all availabletarimplementations to find GNU tar.Fixes#552
Fixesactions/cache#362 - OS-agnostic caches miss on Windows due to different compression (caused by zstd issue)
Fixesactions/cache#315 - infinite recursion in
bsdtarcaused by junction points on windowsFixesactions/cache#301 -
zstdhangs when used withbsdtar