You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why: The suggestion identifies a potential logical error where AuditEnabled is only set when RuleTemplateName is non-empty, which could lead to missed configuration; moving it outside the conditional block improves reliability.
-// DB Service audit enabled+// DB Service Audit Enabled
AuditEnabled bool `json:"audit_enabled"`
Suggestion importance[1-10]: 3
__
Why: This suggestion only alters the comment’s capitalization to enhance style consistency, which is a minor improvement without affecting functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
issue:#489
Description
新增 AuditEnabled 控制审核总开关
为 SQLQueryConfig 添加模板字段
BizDBServiceArgs 增加审核参数
更新 swagger 定义及包路径
Changes diagram
Changes walkthrough 📝
db_service.go
添加审核配置字段internal/dms/biz/db_service.go
db_service.go
更新 API 模型字段pkg/dms-common/api/dms/v1/db_service.go
swagger.json
调整 swagger.json 定义api/swagger.json
swagger.yaml
调整 swagger.yaml 定义api/swagger.yaml