Uh oh!
There was an error while loading. Please reload this page.
fix: reject disabled and deleted users when adding project members - #671
Merged
Conversation
Validate membership eligibility before CreateMember so disabled or deleted users cannot be written via AddMember API. Co-authored-by: Cursor <cursoragent@cursor.com>
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Seechi-Yolo
approved these changes
Aug 21, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/dms-ee/issues/973
描述你的变更
EnsureUserEligibleForProjectMembershipto reject missing, deleted, or disabled users before project member createCreateMemberso AddMember API cannot persist ineligible users确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_docMade with Cursor
Description
调整项目成员添加逻辑
在 CreateMember 中调用新检验函数
新增 EnsureUserEligibleForProjectMembership 方法
Diagram Walkthrough
File Walkthrough
member.go
在 CreateMember 中增加用户资格验证internal/dms/biz/member.go
user.go
添加用户成员资格校验函数internal/dms/biz/user.go