Uh oh!
There was an error while loading. Please reload this page.
chore: bump version to 1.0.1 - #3
Merged
Merged
Conversation
Release contents: * fix: load-order — register IndexAsCalendar at gem-require time instead of `config.to_prepare`, so consuming engines that require AA resources from an initializer don't hit `NameError: uninitialized constant ActiveAdmin::Views::IndexAsCalendar`. (#1) * feat: ship npm twin (@activeadmin-plugins/activeadmin_calendar). The package.json / prepublishOnly layout mirrors sibling AA plugins; consumers on bundler-based asset pipelines (Vite, esbuild, cssbundling-rails) can now `@import` the CSS as an npm package instead of mirroring it locally. (#2)
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release contents:
fix: load-order — register IndexAsCalendar at gem-require time instead of
config.to_prepare, so consuming engines that require AA resources from an initializer don't hitNameError: uninitialized constant ActiveAdmin::Views::IndexAsCalendar. (fix: register IndexAsCalendar at gem-require time, not via to_prepare #1)feat: ship npm twin (@activeadmin-plugins/activeadmin_calendar). The package.json / prepublishOnly layout mirrors sibling AA plugins; consumers on bundler-based asset pipelines (Vite, esbuild, cssbundling-rails) can now
@importthe CSS as an npm package instead of mirroring it locally. (feat: ship npm twin (@activeadmin-plugins/activeadmin_calendar) #2)