Skip to content

Update: Use npm for install, update and uninstall where required (fixes #175) - #189

Open
oliverfoster wants to merge 11 commits into
masterfrom
issue/175
Open

Update: Use npm for install, update and uninstall where required (fixes #175)#189
oliverfoster wants to merge 11 commits into
masterfrom
issue/175

Conversation

@oliverfoster

@oliverfosteroliverfoster commented Mar 2, 2023•
edited
Loading

Copy link
Copy Markdown
Member

fixes#175
refs adaptlearning/adapt_framework#3370

New

  • install, devinstall, update, uninstall, register, unregister and rename using npm for v6

Notes

  • install, update, devinstall and uninstall seem to be working well
  • Register, unregister and rename are as yet untested

@oliverfosteroliverfoster self-assigned this Mar 2, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool reviewed Mar 3, 2023
View reviewed changes
Comment threadlib/integration/PluginManagement/npm.js Outdated
cahirodoherty-learningpool
cahirodoherty-learningpool reviewed Mar 3, 2023
View reviewed changes
Comment threadlib/integration/PluginManagement/npm.js Outdated
cahirodoherty-learningpool
cahirodoherty-learningpool reviewed Mar 3, 2023
View reviewed changes
Comment threadlib/integration/PluginManagement/npm.js Outdated
cahirodoherty-learningpool
cahirodoherty-learningpool reviewed Mar 3, 2023
View reviewed changes
Comment threadlib/integration/Target.js Outdated
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 6, 2023
View reviewed changes

@cahirodoherty-learningpoolcahirodoherty-learningpool left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

eleanor-heath
eleanor-heath reviewed Mar 10, 2023
View reviewed changes
Comment threadlib/integration/Target.js
@@ -158,26 +158,83 @@ export default class Target extends Plugin {

async install ({ clone = false } = {}) {

@eleanor-heatheleanor-heathMar 10, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the install function is quite lengthy, can any of this be separated out into individual functions?

@taylortomtaylortom moved this from Backlog to Assigned in adapt_framework: The TODO BoardMar 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eleanor-heatheleanor-heatheleanor-heath approved these changes
+1 more reviewer
@cahirodoherty-learningpoolcahirodoherty-learningpoolcahirodoherty-learningpool approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@oliverfosteroliverfoster

Labels

enhancement

Projects

adapt_framework: The TODO Board
Status: Assigned

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add npm layer

4 participants

@oliverfoster@cahirodoherty-learningpool@eleanor-heath@taylortom