Skip to content

Fix#8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addon-owner merged 3 commits into from
Oct 22, 2025
Merged

Fix #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9be4790
Merge main into develop
github-actions[bot] Oct 21, 2025
b5e8f31
refactor(background): streamline permission handling and improve erro…
addon-owner Oct 22, 2025
4c85ce9
refactor(background): remove trailing commas in error logging functions
addon-owner Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions plugin/background.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,6 @@ import {containsPermissions, getManifest, onInstalled, onPermissionsAdded, query

type Tab = chrome.tabs.Tab;
type Permissions = chrome.permissions.Permissions;
type ManifestPermissions = chrome.runtime.ManifestPermissions;

type ManifestContent = NonNullable<chrome.runtime.Manifest["content_scripts"]>[number];

Expand DownExpand Up@@ -75,11 +74,9 @@ const register = async (): Promise<void> => {
await Promise.allSettled(contents.map(executeContentScript));
};

const permissions: ManifestPermissions[] = ["tabs", "scripting"];

export default defineBackground({
permissions,
main: async () => {
permissions: ["tabs", "scripting"],
main: async ({permissions}) => {
onInstalled(async details => {
if (details.reason === "install") {
const origins = getContentsScripts()?.flatMap(content => content.matches || []);
Expand Down