fix: register skill with explicit source field - #2
Open
junyuyuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
apply()registers the runtime skill without asourcefield:DSH's
validateRuntimeSkilldoes not requiresourcefor runtime registrations (unlike provider candidates), so the catalog summary ends up withsource: undefined. Any consumer assumingsourceis a string then crashes — e.g.dsh-memory-evolve's skill manager (/skills-manager/api/skills) doesisProtectedSource(skill.source)→undefined.startsWith('project')→ TypeError → the entire skills listing API returns 500, and the web Skill Manager shows "0 skills" (the user's own skills included).Change
'bundled'matches the source value DSH already uses for skills shipped with a bundle.Verified
GET /skills-manager/api/skillsreturns 200 with the full catalog after this change; skills list renders normally. Closes#1.