Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Add base management command for projects - #73

Merged
c0rydoras merged 4 commits into
adfinis:mainfrom
c0rydoras:django-base-project-command
Oct 30, 2023
Merged

Add base management command for projects#73
c0rydoras merged 4 commits into
adfinis:mainfrom
c0rydoras:django-base-project-command

Conversation

@c0rydoras

Copy link
Copy Markdown
Collaborator

No description provided.

@c0rydorasc0rydoras added backend This issue or pull request is backend related enhancement This issue or pull request discusses non feature changes labels Aug 28, 2023
@c0rydorasc0rydoras self-assigned this Aug 28, 2023
@c0rydorasc0rydoras linked an issue Aug 28, 2023 that may be closed by this pull request
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch from 19bbf4d to cbd70e3CompareAugust 28, 2023 12:47
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch 3 times, most recently from f44333f to 02ec3f6CompareSeptember 5, 2023 09:16
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch from 02ec3f6 to 0be0163CompareOctober 4, 2023 12:27
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch from 0be0163 to 2b26d7aCompareOctober 24, 2023 11:39
@c0rydorasc0rydoras mentioned this pull request Oct 24, 2023
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch 4 times, most recently from cc75a69 to 6033236CompareOctober 30, 2023 09:54

@open-dynaMIXopen-dynaMIX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

Regarding commit names, it would be nice if they would more reflect a reasoning. For example the commit refacor(api): drop async in synchronizer: When reading the code change it's clear what was done. What's unclear is why was it done.

Comment threadapi/outdated/tests/test_commands.py Outdated
Comment threadapi/outdated/commands.py Outdated
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch 2 times, most recently from 4c6e7b7 to 07a7879CompareOctober 30, 2023 11:30
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch 3 times, most recently from fc22aac to 1ce83b6CompareOctober 30, 2023 11:42
Comment threadapi/outdated/commands.py Outdated
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch from 1ce83b6 to 6ebc920CompareOctober 30, 2023 12:12
@c0rydoras
c0rydorasforce-pushed the django-base-project-command branch from 6ebc920 to fc2df91CompareOctober 30, 2023 12:26
@c0rydoras
c0rydoras merged commit f6c1fc3 into adfinis:mainOct 30, 2023
@c0rydoras
c0rydoras deleted the django-base-project-command branch October 30, 2023 12:40
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backendThis issue or pull request is backend relatedenhancementThis issue or pull request discusses non feature changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project Base Management Command

2 participants

@c0rydoras@open-dynaMIX