Uh oh!
There was an error while loading. Please reload this page.
[CI] Fix the build - #45
Conversation
| - rvm: rbx-2.1.1 | ||
| env: | ||
| global: | ||
| - JRUBY_OPTS='--debug' |
There was a problem hiding this comment.
Are you still working on this? Or do you intend to keep this flag? (and if so, why?)
There was a problem hiding this comment.
Good q. This is not needed yet unless we have coveralls on, which we don't. Since it doesn't add value, I'll drop this.
Oh and yes, turns out I still have some commits to add.. coming soon!
e27836a to
e4b72e5Comparesfgeorge
commented
Aug 25, 2019
@bklang@lpradovera@gfaza Finally ready for review. Can you review this for me? |
@bklang@lpradovera@gfaza Sorry, not ready for review yet. My future intent is, once we've reviewed & settled on changes here, to have the However, my changes won't cleanly merge-up to I'm going to re-work this branch to incorporate @benlangfeld's changes so that it will merge |
Should get things passing on: - ruby-2.5.3 - jruby-9.1.17.0
…a supervision tree" See d9b806a
Makes it easier to ensure that the build stays green from the RSpec 2.99 -> RSpec 3.x transition.
This conversion is done by Transpec 3.4.0 with the following command:
transpec -f
* 65 conversions
from: obj.should
to: expect(obj).to
* 51 conversions
from: == expected
to: eq(expected)
* 8 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 6 conversions
from: obj.should_not
to: expect(obj).not_to
* 5 conversions
from: =~ /pattern/
to: match(/pattern/)
* 5 conversions
from: it { should_not ... }
to: it { is_expected.not_to ... }
* 3 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
* 2 conversions
from: be_false
to: be_falsey
* 2 conversions
from: its(:attr) { }
to: describe '#attr' do subject { super().attr }; it { } end
* 1 conversion
from: lambda { }.should
to: expect { }.to
* 1 conversion
from: mock('something')
to: double('something')
* 1 conversion
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 1 conversion
from: pending
to: skip
For more details: https://github.com/yujinakayama/transpec#supported-conversions...with a documented, supported argument matcher block to #receive. Unsupported in #with: rspec/rspec-mocks#377 (comment) Supported in #receive: https://github.com/rspec/rspec-mocks#arbitrary-handling
Convert specs to RSpec 3.8.2 syntax with Transpec This conversion is done by Transpec 3.4.0 with the following command: transpec -f * 2 conversions from: obj.stub(:message => value) to: allow(obj).to receive_messages(:message => value) For more details: https://github.com/yujinakayama/transpec#supported-conversions
This reverts commit a9d85a5.
sfgeorge
commented
Aug 25, 2019
@bklang@lpradovera@gfaza After a few tweaks this is ready for review 😊 😬 |
bklang
left a comment
There was a problem hiding this comment.
Wow, that was a lot of work! Thank you for your efforts here to modernize the test suite. Cheers! 🥂
bklang
commented
Aug 25, 2019
@sfgeorge merging because this is clearly useful & helpful. But I also noticed that this is on the |
lpradovera
commented
Aug 25, 2019
This is absolutely amazing! |
sfgeorge
commented
Aug 25, 2019
Thanks guys! You rock!
@bklang Absolutely. I wanted to 1st settle any potential PR changes, but you made it easy for me. I'll now open another PR to up-port the changes to the develop branch, settling some minor/inevitable git conflicts along the way. |
sfgeorge
commented
Aug 25, 2019
Also, thank you @benlangfeld for having made a bunch of these stabilization fixes. That would have been A LOT harder to do if I didn't have the benefit of plucking a bunch of the fixes you already made. 🙇 |
developbranchPlease forgive me this large commit in the midst:
...For what it's worth, I didn't add anything special to that commit beyond just letting
transpecdo its thing to automatically upgrade from RSpec 2.x to 3.x syntax, so no need to review that commit with a fine-toothed comb.