Instance methods are not usable inside grammars - #32

Open
wdrexler wants to merge 1 commit into
adhearsion:developfrom
wdrexler:feature/fix-nested-blocks
Open

Instance methods are not usable inside grammars#32
wdrexler wants to merge 1 commit into
adhearsion:developfrom
wdrexler:feature/fix-nested-blocks

Conversation

@wdrexler

@wdrexlerwdrexler commented Jun 20, 2014

Copy link
Copy Markdown

It seems that when there is a method inside a class that returns a grammar, and that grammar uses the return values of other methods inside the class, RubySpeech throws an error.

Code looks like this: https://gist.github.com/wdrexler/f0b229d7dfb7a9629dbe
The error returned is:

/Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:277:in `method_missing': undefined local variable or method `my_method' for <item/>:RubySpeech::GRXML::Item (NameError)
from ./rs_test.rb:14:in `block (3 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:14:in `block (2 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:13:in `block in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:25:in `block in draw'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `tap'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `draw'
from ./rs_test.rb:12:in `grammar'
from ./rs_test.rb:4:in `run'
from ./rs_test.rb:20:in `<main>'

This error does not occur when either:

  1. The methods are declared at the top level (i.e. outside of a class) or
  2. If a local variable is assigned to the return value of the method before the RubySpeech::GRXML.draw block starts

This was tested against latest develop.

@benlangfeld

benlangfeld commented Jun 20, 2014

Copy link
Copy Markdown
Member

So current theory is that while this fails...

RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doruleid: 'root',scope: 'public'doitem{my_method}endend

...this would work...

RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doitem{my_method}end

The existing test for this needs to be extended to cover invocation in a nested block.

@wdrexler

wdrexler commented Jun 20, 2014

Copy link
Copy Markdown
Author

So I've written a new test that covers invocation in a nested block. It fails, as expected. How would we fix this, @benlangfeld?

@benlangfeld

benlangfeld commented Jun 20, 2014

Copy link
Copy Markdown
Member

First off, submit the spec as a pull request to replace this issue (or convert this one).

As for a fix, either recursively walk up the tree in method_missing or directly grab the block context from the root of the tree. The latter is more efficient but the former more closely respects normal closure binding semantics. Thoughts?

houndci-bot
houndci-bot reviewed Jun 20, 2014
View reviewed changes
Comment threadspec/ruby_speech/grxml_spec.rb Outdated

@houndci-bothoundci-botJun 20, 2014

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.

@wdrexlerwdrexlerJun 20, 2014

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go ahead and use 1.9 syntax? The only reason I didn't in the first place was that the existing specs used 1.8 syntax.

@benlangfeldbenlangfeldJun 20, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all touched lines here, yeah. We should migrate piece by piece.

@wdrexler

wdrexler commented Jun 20, 2014

Copy link
Copy Markdown
Author

So I'm leaning towards walking up the tree instead of just grabbing the root element. Without knowing the actual performance impact of grabbing the block context of the root element (in, say, an Adhearsion app, is walking up the tree really going to be a bottleneck?), I'd say that we're better off going with the more semantically valid approach.

@benlangfeld

benlangfeld commented Jun 20, 2014

Copy link
Copy Markdown
Member

Go for it :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wdrexler@benlangfeld@houndci-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Instance methods are not usable inside grammars - #32
Open
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Open
Instance methods are not usable inside grammars#32
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Conversation
@wdrexler
@wdrexlerwdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

It seems that when there is a method inside a class that returns a grammar, and that grammar uses the return values of other methods inside the class, RubySpeech throws an error.
Code looks like this: https://gist.github.com/wdrexler/f0b229d7dfb7a9629dbe

The error returned is:
/Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:277:in `method_missing': undefined local variable or method `my_method' for <item/>:RubySpeech::GRXML::Item (NameError)
from ./rs_test.rb:14:in `block (3 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:14:in `block (2 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:13:in `block in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:25:in `block in draw'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `tap'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `draw'
from ./rs_test.rb:12:in `grammar'
from ./rs_test.rb:4:in `run'
from ./rs_test.rb:20:in `<main>'

This error does not occur when either:
  1. The methods are declared at the top level (i.e. outside of a class) or
  2. If a local variable is assigned to the return value of the method before the RubySpeech::GRXML.draw block starts
This was tested against latest develop.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
So current theory is that while this fails...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doruleid: 'root',scope: 'public'doitem{my_method}endend
...this would work...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doitem{my_method}end
The existing test for this needs to be extended to cover invocation in a nested block.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I've written a new test that covers invocation in a nested block. It fails, as expected. How would we fix this, @benlangfeld?
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
First off, submit the spec as a pull request to replace this issue (or convert this one).
As for a fix, either recursively walk up the tree in method_missing or directly grab the block context from the root of the tree. The latter is more efficient but the former more closely respects normal closure binding semantics. Thoughts?
houndci-bot
houndci-bot
reviewed
Jun 20, 2014
 View reviewed changes

Comment threadspec/ruby_speech/grxml_spec.rb
Outdated

@houndci-bothoundci-botJun 20, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
@wdrexlerwdrexlerJun 20, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go ahead and use 1.9 syntax? The only reason I didn't in the first place was that the existing specs used 1.8 syntax.
@benlangfeldbenlangfeldJun 20, 2014

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all touched lines here, yeah. We should migrate piece by piece.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I'm leaning towards walking up the tree instead of just grabbing the root element. Without knowing the actual performance impact of grabbing the block context of the root element (in, say, an Adhearsion app, is walking up the tree really going to be a bottleneck?), I'd say that we're better off going with the more semantically valid approach.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
Go for it :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wdrexler@benlangfeld@houndci-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Instance methods are not usable inside grammars - #32
Open
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Open
Instance methods are not usable inside grammars#32
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Conversation
@wdrexler
@wdrexlerwdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

It seems that when there is a method inside a class that returns a grammar, and that grammar uses the return values of other methods inside the class, RubySpeech throws an error.
Code looks like this: https://gist.github.com/wdrexler/f0b229d7dfb7a9629dbe

The error returned is:
/Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:277:in `method_missing': undefined local variable or method `my_method' for <item/>:RubySpeech::GRXML::Item (NameError)
from ./rs_test.rb:14:in `block (3 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:14:in `block (2 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:13:in `block in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:25:in `block in draw'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `tap'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `draw'
from ./rs_test.rb:12:in `grammar'
from ./rs_test.rb:4:in `run'
from ./rs_test.rb:20:in `<main>'

This error does not occur when either:
  1. The methods are declared at the top level (i.e. outside of a class) or
  2. If a local variable is assigned to the return value of the method before the RubySpeech::GRXML.draw block starts
This was tested against latest develop.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
So current theory is that while this fails...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doruleid: 'root',scope: 'public'doitem{my_method}endend
...this would work...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doitem{my_method}end
The existing test for this needs to be extended to cover invocation in a nested block.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I've written a new test that covers invocation in a nested block. It fails, as expected. How would we fix this, @benlangfeld?
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
First off, submit the spec as a pull request to replace this issue (or convert this one).
As for a fix, either recursively walk up the tree in method_missing or directly grab the block context from the root of the tree. The latter is more efficient but the former more closely respects normal closure binding semantics. Thoughts?
houndci-bot
houndci-bot
reviewed
Jun 20, 2014
 View reviewed changes

Comment threadspec/ruby_speech/grxml_spec.rb
Outdated

@houndci-bothoundci-botJun 20, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
@wdrexlerwdrexlerJun 20, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go ahead and use 1.9 syntax? The only reason I didn't in the first place was that the existing specs used 1.8 syntax.
@benlangfeldbenlangfeldJun 20, 2014

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all touched lines here, yeah. We should migrate piece by piece.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I'm leaning towards walking up the tree instead of just grabbing the root element. Without knowing the actual performance impact of grabbing the block context of the root element (in, say, an Adhearsion app, is walking up the tree really going to be a bottleneck?), I'd say that we're better off going with the more semantically valid approach.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
Go for it :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wdrexler@benlangfeld@houndci-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Instance methods are not usable inside grammars - #32
Open
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Open
Instance methods are not usable inside grammars#32
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Conversation
@wdrexler
@wdrexlerwdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

It seems that when there is a method inside a class that returns a grammar, and that grammar uses the return values of other methods inside the class, RubySpeech throws an error.
Code looks like this: https://gist.github.com/wdrexler/f0b229d7dfb7a9629dbe

The error returned is:
/Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:277:in `method_missing': undefined local variable or method `my_method' for <item/>:RubySpeech::GRXML::Item (NameError)
from ./rs_test.rb:14:in `block (3 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:14:in `block (2 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:13:in `block in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:25:in `block in draw'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `tap'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `draw'
from ./rs_test.rb:12:in `grammar'
from ./rs_test.rb:4:in `run'
from ./rs_test.rb:20:in `<main>'

This error does not occur when either:
  1. The methods are declared at the top level (i.e. outside of a class) or
  2. If a local variable is assigned to the return value of the method before the RubySpeech::GRXML.draw block starts
This was tested against latest develop.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
So current theory is that while this fails...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doruleid: 'root',scope: 'public'doitem{my_method}endend
...this would work...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doitem{my_method}end
The existing test for this needs to be extended to cover invocation in a nested block.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I've written a new test that covers invocation in a nested block. It fails, as expected. How would we fix this, @benlangfeld?
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
First off, submit the spec as a pull request to replace this issue (or convert this one).
As for a fix, either recursively walk up the tree in method_missing or directly grab the block context from the root of the tree. The latter is more efficient but the former more closely respects normal closure binding semantics. Thoughts?
houndci-bot
houndci-bot
reviewed
Jun 20, 2014
 View reviewed changes

Comment threadspec/ruby_speech/grxml_spec.rb
Outdated

@houndci-bothoundci-botJun 20, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
@wdrexlerwdrexlerJun 20, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go ahead and use 1.9 syntax? The only reason I didn't in the first place was that the existing specs used 1.8 syntax.
@benlangfeldbenlangfeldJun 20, 2014

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all touched lines here, yeah. We should migrate piece by piece.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I'm leaning towards walking up the tree instead of just grabbing the root element. Without knowing the actual performance impact of grabbing the block context of the root element (in, say, an Adhearsion app, is walking up the tree really going to be a bottleneck?), I'd say that we're better off going with the more semantically valid approach.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
Go for it :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wdrexler@benlangfeld@houndci-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Instance methods are not usable inside grammars - #32
Open
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Open
Instance methods are not usable inside grammars#32
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Conversation
@wdrexler
@wdrexlerwdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

It seems that when there is a method inside a class that returns a grammar, and that grammar uses the return values of other methods inside the class, RubySpeech throws an error.
Code looks like this: https://gist.github.com/wdrexler/f0b229d7dfb7a9629dbe

The error returned is:
/Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:277:in `method_missing': undefined local variable or method `my_method' for <item/>:RubySpeech::GRXML::Item (NameError)
from ./rs_test.rb:14:in `block (3 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:14:in `block (2 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:13:in `block in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:25:in `block in draw'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `tap'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `draw'
from ./rs_test.rb:12:in `grammar'
from ./rs_test.rb:4:in `run'
from ./rs_test.rb:20:in `<main>'

This error does not occur when either:
  1. The methods are declared at the top level (i.e. outside of a class) or
  2. If a local variable is assigned to the return value of the method before the RubySpeech::GRXML.draw block starts
This was tested against latest develop.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
So current theory is that while this fails...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doruleid: 'root',scope: 'public'doitem{my_method}endend
...this would work...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doitem{my_method}end
The existing test for this needs to be extended to cover invocation in a nested block.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I've written a new test that covers invocation in a nested block. It fails, as expected. How would we fix this, @benlangfeld?
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
First off, submit the spec as a pull request to replace this issue (or convert this one).
As for a fix, either recursively walk up the tree in method_missing or directly grab the block context from the root of the tree. The latter is more efficient but the former more closely respects normal closure binding semantics. Thoughts?
houndci-bot
houndci-bot
reviewed
Jun 20, 2014
 View reviewed changes

Comment threadspec/ruby_speech/grxml_spec.rb
Outdated

@houndci-bothoundci-botJun 20, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
@wdrexlerwdrexlerJun 20, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go ahead and use 1.9 syntax? The only reason I didn't in the first place was that the existing specs used 1.8 syntax.
@benlangfeldbenlangfeldJun 20, 2014

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all touched lines here, yeah. We should migrate piece by piece.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I'm leaning towards walking up the tree instead of just grabbing the root element. Without knowing the actual performance impact of grabbing the block context of the root element (in, say, an Adhearsion app, is walking up the tree really going to be a bottleneck?), I'd say that we're better off going with the more semantically valid approach.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
Go for it :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wdrexler@benlangfeld@houndci-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Instance methods are not usable inside grammars - #32
Open
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Open
Instance methods are not usable inside grammars#32
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Conversation
@wdrexler
@wdrexlerwdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

It seems that when there is a method inside a class that returns a grammar, and that grammar uses the return values of other methods inside the class, RubySpeech throws an error.
Code looks like this: https://gist.github.com/wdrexler/f0b229d7dfb7a9629dbe

The error returned is:
/Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:277:in `method_missing': undefined local variable or method `my_method' for <item/>:RubySpeech::GRXML::Item (NameError)
from ./rs_test.rb:14:in `block (3 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:14:in `block (2 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:13:in `block in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:25:in `block in draw'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `tap'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `draw'
from ./rs_test.rb:12:in `grammar'
from ./rs_test.rb:4:in `run'
from ./rs_test.rb:20:in `<main>'

This error does not occur when either:
  1. The methods are declared at the top level (i.e. outside of a class) or
  2. If a local variable is assigned to the return value of the method before the RubySpeech::GRXML.draw block starts
This was tested against latest develop.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
So current theory is that while this fails...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doruleid: 'root',scope: 'public'doitem{my_method}endend
...this would work...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doitem{my_method}end
The existing test for this needs to be extended to cover invocation in a nested block.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I've written a new test that covers invocation in a nested block. It fails, as expected. How would we fix this, @benlangfeld?
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
First off, submit the spec as a pull request to replace this issue (or convert this one).
As for a fix, either recursively walk up the tree in method_missing or directly grab the block context from the root of the tree. The latter is more efficient but the former more closely respects normal closure binding semantics. Thoughts?
houndci-bot
houndci-bot
reviewed
Jun 20, 2014
 View reviewed changes

Comment threadspec/ruby_speech/grxml_spec.rb
Outdated

@houndci-bothoundci-botJun 20, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
@wdrexlerwdrexlerJun 20, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go ahead and use 1.9 syntax? The only reason I didn't in the first place was that the existing specs used 1.8 syntax.
@benlangfeldbenlangfeldJun 20, 2014

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all touched lines here, yeah. We should migrate piece by piece.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I'm leaning towards walking up the tree instead of just grabbing the root element. Without knowing the actual performance impact of grabbing the block context of the root element (in, say, an Adhearsion app, is walking up the tree really going to be a bottleneck?), I'd say that we're better off going with the more semantically valid approach.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
Go for it :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wdrexler@benlangfeld@houndci-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Instance methods are not usable inside grammars - #32
Open
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Open
Instance methods are not usable inside grammars#32
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Conversation
@wdrexler
@wdrexlerwdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

It seems that when there is a method inside a class that returns a grammar, and that grammar uses the return values of other methods inside the class, RubySpeech throws an error.
Code looks like this: https://gist.github.com/wdrexler/f0b229d7dfb7a9629dbe

The error returned is:
/Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:277:in `method_missing': undefined local variable or method `my_method' for <item/>:RubySpeech::GRXML::Item (NameError)
from ./rs_test.rb:14:in `block (3 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:14:in `block (2 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:13:in `block in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:25:in `block in draw'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `tap'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `draw'
from ./rs_test.rb:12:in `grammar'
from ./rs_test.rb:4:in `run'
from ./rs_test.rb:20:in `<main>'

This error does not occur when either:
  1. The methods are declared at the top level (i.e. outside of a class) or
  2. If a local variable is assigned to the return value of the method before the RubySpeech::GRXML.draw block starts
This was tested against latest develop.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
So current theory is that while this fails...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doruleid: 'root',scope: 'public'doitem{my_method}endend
...this would work...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doitem{my_method}end
The existing test for this needs to be extended to cover invocation in a nested block.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I've written a new test that covers invocation in a nested block. It fails, as expected. How would we fix this, @benlangfeld?
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
First off, submit the spec as a pull request to replace this issue (or convert this one).
As for a fix, either recursively walk up the tree in method_missing or directly grab the block context from the root of the tree. The latter is more efficient but the former more closely respects normal closure binding semantics. Thoughts?
houndci-bot
houndci-bot
reviewed
Jun 20, 2014
 View reviewed changes

Comment threadspec/ruby_speech/grxml_spec.rb
Outdated

@houndci-bothoundci-botJun 20, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
@wdrexlerwdrexlerJun 20, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go ahead and use 1.9 syntax? The only reason I didn't in the first place was that the existing specs used 1.8 syntax.
@benlangfeldbenlangfeldJun 20, 2014

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all touched lines here, yeah. We should migrate piece by piece.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I'm leaning towards walking up the tree instead of just grabbing the root element. Without knowing the actual performance impact of grabbing the block context of the root element (in, say, an Adhearsion app, is walking up the tree really going to be a bottleneck?), I'd say that we're better off going with the more semantically valid approach.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
Go for it :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wdrexler@benlangfeld@houndci-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Instance methods are not usable inside grammars - #32
Open
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Open
Instance methods are not usable inside grammars#32
wdrexler wants to merge 1 commit into
adhearsion:developfrom 
wdrexler:feature/fix-nested-blocks
Conversation
@wdrexler
@wdrexlerwdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

It seems that when there is a method inside a class that returns a grammar, and that grammar uses the return values of other methods inside the class, RubySpeech throws an error.
Code looks like this: https://gist.github.com/wdrexler/f0b229d7dfb7a9629dbe

The error returned is:
/Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:277:in `method_missing': undefined local variable or method `my_method' for <item/>:RubySpeech::GRXML::Item (NameError)
from ./rs_test.rb:14:in `block (3 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:14:in `block (2 levels) in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:78:in `build'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:57:in `initialize'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `new'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:273:in `method_missing'
from ./rs_test.rb:13:in `block in grammar'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `instance_eval'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/generic_element.rb:126:in `eval_dsl_block'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:25:in `block in draw'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `tap'
from /Users/wdrexler/.rvm/gems/ruby-2.1.2/bundler/gems/ruby_speech-a3a837c0106f/lib/ruby_speech/grxml.rb:23:in `draw'
from ./rs_test.rb:12:in `grammar'
from ./rs_test.rb:4:in `run'
from ./rs_test.rb:20:in `<main>'

This error does not occur when either:
  1. The methods are declared at the top level (i.e. outside of a class) or
  2. If a local variable is assigned to the return value of the method before the RubySpeech::GRXML.draw block starts
This was tested against latest develop.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
So current theory is that while this fails...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doruleid: 'root',scope: 'public'doitem{my_method}endend
...this would work...
RubySpeech::GRXML.drawroot: 'root',tag_format: 'semantics/1.0'doitem{my_method}end
The existing test for this needs to be extended to cover invocation in a nested block.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I've written a new test that covers invocation in a nested block. It fails, as expected. How would we fix this, @benlangfeld?
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
First off, submit the spec as a pull request to replace this issue (or convert this one).
As for a fix, either recursively walk up the tree in method_missing or directly grab the block context from the root of the tree. The latter is more efficient but the former more closely respects normal closure binding semantics. Thoughts?
houndci-bot
houndci-bot
reviewed
Jun 20, 2014
 View reviewed changes

Comment threadspec/ruby_speech/grxml_spec.rb
Outdated

@houndci-bothoundci-botJun 20, 2014

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
@wdrexlerwdrexlerJun 20, 2014

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I go ahead and use 1.9 syntax? The only reason I didn't in the first place was that the existing specs used 1.8 syntax.
@benlangfeldbenlangfeldJun 20, 2014

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all touched lines here, yeah. We should migrate piece by piece.
@wdrexler
wdrexler
commented
Jun 20, 2014

Copy link


Copy Markdown

Author
So I'm leaning towards walking up the tree instead of just grabbing the root element. Without knowing the actual performance impact of grabbing the block context of the root element (in, say, an Adhearsion app, is walking up the tree really going to be a bottleneck?), I'd say that we're better off going with the more semantically valid approach.
@benlangfeld
benlangfeld
commented
Jun 20, 2014

Copy link


Copy Markdown

Member
Go for it :)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wdrexler@benlangfeld@houndci-bot