Uh oh!
There was an error while loading. Please reload this page.
2026.07 - #77
Merged
Merged
Conversation
jakes-adobe
marked this pull request as draft
July 17, 2026 08:20
…eformatUtils (#78) The *SanityTests binaries aborted at process exit on Linux with "double free or corruption (fasttop)". The tests themselves passed; the abort happened during static-destructor teardown (_dl_fini -> libfileformatUtils.so __cxa_finalize -> std::string dtor). Root cause: GoogleTest is statically linked and was embedded into BOTH the shared libfileformatUtils.so (which compiled the test helper test.cpp and linked GTest::gtest PUBLIC) AND every test executable. GoogleTest's global command-line-flag std::strings therefore collapsed to a single address under the ELF flat namespace, but each module registered its own __cxa_atexit finalizer, so the one object's destructor ran twice -> double free. macOS (two-level namespace) and Windows were unaffected, which is why only the ubuntu-22.04 jobs failed. Fix: move the test-only helper (test.cpp/test.h) into a new STATIC library fileformatUtilsTest that links GTest, and stop linking GTest into the shared fileformatUtils runtime library. GTest now lives only in the static helper and the test executables, so there is a single set of GTest globals per process and a single destructor. The test helper gets its own empty USDFFUTILSTEST_API macro since a static library linked directly into each executable needs no import/export decoration (this also keeps Windows /WX happy). All test targets that used the helper now link fileformatUtilsTest, which brings fileformatUtils in transitively. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
fbaba-adobe
approved these changes
Jul 17, 2026
jakes-adobe
marked this pull request as ready for review
July 17, 2026 23:34
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2026.07 July 17th, 2026
Features
all
- Flip writer defaults to native OpenPBR
- Deprecate ASM and UsdPreviewSurface writers in favor of native OpenPBR
- Replace the default ASM material struct with OpenPBR using a feature flag
fbx
- Import OpenPBR materials from Maya and 3ds Max exports
- add support for new SDF_FORMAT_ARGS:importLights option
gltf
- Add various OpenPBR features to glTF import
- add support for new SDF_FORMAT_ARGS:importLights option
sandbox
- added sandbox module alongside ipc and serialization modules
sbsar
- Create shader graph to convert sbsar tangent input to geometry_tangent
- Add API to get resolved path from image cache for SBSAR SAL interop
utils
- UTF-8-aware MakeValidUsdIdentifier prim-name sanitizer
- Per-node custom properties as prim customData
Fixes
all
- Move normalScale from texture reader scale/bias to ND_normalmap scale input
- Use constants to initialize normal scale/bias
fbx
- Preserve material assignment for InstanceProxy models
- Preserve rotation on FBX nodes with near-zero scale
- Resolve sibling textures when GetRelativeFileName returns absolute-looking path
- Work around FBX SDK 2020.3.9 triangulate crash on skinned meshes
- Preserve per-GeomSubset material bindings on export
- Import Phong materials as dielectric by default
- Matte Lambert roughness and reflectivity-gated Phong metalness
- Preserve roughness when converting Phong FBX materials to USD
- Zero specular_weight and transfer Lambert Diffuse weight to base_weight
- Attach materials to every shared-mesh instance node
- Triangulate meshes with untriangulated n-gon polygons
gltf
- Do proper conversion of gltf anisotropy to OpenPBR on import
- Fix for crash caused by failing to check value validity
- Skip UsdLuxDomeLight on export instead of converting to point light
- Reject animation samplers with mismatched accessor counts
- Avoid duplicate tinygltf symbols with Xcode 26 linker
- Author mesh extent on import to keep bbox queries O(1)
- Validate vertex attribute accessor types to prevent heap overflow
- Fold OpenPBR base_weight into baseColorFactor on export
obj
- Fix missing materials with combineGroups and separateGroupsAsSubsets
- Parse ZBrush #MRGB vertex colors in OBJ import
- Defer parser warnings from TBB workers to main thread
- Removing stale obj test
- Derive roughness from Phong shininess on import
- Keep map_Kd texture when Kd is a placeholder zero
- Escape untrusted bytes in OBJ parser diagnostics
ply
- One-liner fix to narrow opacity filtering with std::isnan
- Write per-face color/opacity at submesh offset and guard property size
sbsar
- Various improvements to the SBSAR render thread
- Incorrect mapping of asm 'scatteringColor' and added missing mapping of 'scatteringDistance'
- Fix intermittent null-deref crash in render thread on startup
- Fix mapping of sbsar outputs using OpenPBR material model to openpbr material inputs
- Default-initialize RenderResultCache members and guard against nullptr
- Guard against null mRenderResultImage in _OpenForReading
- Join render thread before static teardown
- Suppress error for empty path in SBSAR image input
- Fix reading of sbsar images
stl
- Reject non-3D-model files sharing the .stl extension
utils
- Uniquify meshes, curves, and child nodes in shared prim namespace
- Post a coding error when authoring duplicate prim children
- Uniquify node names (especially synthesized Materials node)
- Guard Image::allocate/read against integer overflow
Docs
fbx
- Add FBX SDK update process documentation