Fix typescript types - #354
Merged
yangyansong-adbe merged 1 commit intoMay 17, 2024
Merged
Conversation
3 tasks
alanblins
force-pushed
the
fixTypescriptTypes
branch
from
May 14, 2024 18:49
aa7ceed to
1bf79e8
Compare
yangyansong-adbe
self-requested a review
May 17, 2024 20:43
yangyansong-adbe
approved these changes
May 17, 2024
Contributor
|
@alanblins Thank you for the pull request. We will merge the code changes into a feature branch as we still have some cleanup to do before releasing all packages. |
yangyansong-adbe
added a commit
that referenced
this pull request
Jun 6, 2024
yangyansong-adbe
added a commit
that referenced
this pull request
Jun 6, 2024
* Enable strictNullChecks for the package projects + project cleanup (#360) * fix typescript errors (#354) * Enable strictNullChecks (#358) * project cleanup (#359) --------- Co-authored-by: Alan Lins <alanblins@gmail.com> * version bump up (#362) * add a npmignore file to the root directory (#363) --------- Co-authored-by: Alan Lins <alanblins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typescript declaration files on packages
Fix typescript issues of sample app
AEPSampeAppDescription
Fix typescript declaration files on packages
Fixed fields
mainand addtypesfields topackage.jsonfiles ofpackages/*, example:file: packages/campaignclassic/package.json
current
fixed
Fix typescript issues of sample app
AEPSampeAppnullvaluestypes/props.tsRelated Issue
It fixes the issue 353.
How to reproduce
Clone the repo
adobe/aepsdk-react-nativeand compile the typescript ofapps/AEPSampleApp;Motivation and Context
This is causing issues for consumers that has the option
strictNullChecks:trueon their tsconfig when they update to the version 6.0.0 described on the issue 353. This is blocking the consumers to upgrade the library or forcing them to change their tsconfig.The root cause is that the package.json files from all the packages, contain the typescript file itself on
mainfield, rather than javascript and declaration files as described on typescript documentation.current
changed
The bug is also in the sample app of the
aepsdk-react-nativerepo itself when running the commandnpx tscataepsdk-react-native/apps/AEPSampleApp.How Has This Been Tested?
The changes were tested by:
npm run testnpx tsccommand ataepsdk-react-native/apps/AEPSampleAppScreenshots (if appropriate):
Types of changes
Checklist: