#244) * just storing * Solved issue with the data provider * A working solution * Successfull execution of dependencies * Successfull implementation of order * adding missing files * working solution 1 * permutations * permutations * #35 successful creation of permutations * #35 successful creation of permutations - fixing unit tests * #35 First successfull execution of a permutation scenario * #35 Fixing unit tests * Updating jacoco * Updating jacoco * Updating license headers * Updating license headers * Updating license headers * Updating license headers * Revised algorith * Working on issue #34 adding the bricks for perfomring the permutation algorithm * Fixing #35 Add copy constructor and remove step functionalities * Fixing #35 Added an add method to the ScenarioDependencies method * Fixed issue #35 implemented the defined algorithm * New order nie (#184) * Getting interruptive tests working * New order nie (#186) * Solved issue with the java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask during NIE tests * #187 added default use case * Fixed #188 treating errors and exceptions in tests * updated diagrams * Solving license issues * Fixed missing comments * In mutational #183 removing the Phased annotation from the motational tests * Updating phases * Adding license * Fixed #213 Error when using mutational tests * Moved to mutational * Removed phased test from the mutational test for NIE and solved the resulting NULLpointer issue * renaming default method * Updated typos * Adapting execution modes to Mutational Test (#220) * Updated the ConfigValueHandler * Making compatibility work * Adapted tests to the New Execution Mode * Renamed ExecutionType to ExecutionModes, the previous notion of mode is now behavior types * extracted Phases from the MutationListener * Completely removed Phases from Mutational * enriched tests * Preparing the correspondance between phases and executionMode * #204 Extracted the Phases from the PhasedTestListener * #204 Extracted the Phases from the PhasedTestManager * Made non-interruptive compliant with ExecutionModes * #204 Renamed DEFAULT to STANDARD * #204 Updated the docs * Updated README * Integrate new chaos (#221) * Adapting new order to #197 * Solved issue with NIE event failure * Solved issue with failing test * Allowing for synchronous targetted execution in mutational * Fixed #223: We now also run Mutational tests with single run * Adding documentation on events * Fix maven.config argument parsing for --settings flag Maven requires one argument per line in .mvn/maven.config; having "--settings .mvn/settings.xml" on a single line caused it to be parsed as one unrecognized option, breaking mvn clean test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Migrate GitHub Actions to Sonatype Central Portal OSSRH legacy endpoints (oss.sonatype.org) are being sunset; align with the same fix already applied in bridgeService: updated staging/snapshot URLs, renamed GPG_PASSPHRASE to MAVEN_GPG_PASSPHRASE, added a Central promote step to the release workflow, and bumped Action versions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Add missing MIT license headers license:check was failing the Analyze workflow on new-order; these 8 files were added without the standard header. Fixed via mvn license:format. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix reliability and security issues flagged by SonarCloud quality gate - Mutational.java, PhasedTestManager.java: replace Optional#get() with orElseThrow() and a descriptive exception (S3655) - PhasedEventManager.java: re-interrupt the thread on InterruptedException instead of swallowing it (S2142); replace printStackTrace() with proper logging to avoid leaking debug output (S4507, x3) - ScenarioStepDependencies.java: remove a dead collect() call whose result was discarded (S2201); fix a potential NPE in fetchLastStepPosition by checking fetchLastStep()'s result directly instead of re-deriving emptiness from a separate call (S2259, BLOCKER) These were the specific issues failing the new_reliability_rating and new_security_rating quality gate conditions; the remaining ~190 open code-smell issues are pre-existing debt that don't affect the gate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Add hashCode() to RunValues to match equals() Fixes the last open bug (S1206) that was holding new_reliability_rating at B and failing the SonarCloud quality gate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Decouple PhasedTestManager from MutationManager via a MutationMode SPI (#234) * Decouple PhasedTestManager from MutationManager via a MutationMode SPI Introduce a pluggable MutationMode strategy (discovered via ServiceLoader) so PhasedTestManager no longer references MutationManager/MutationListener directly. The legacy interruptive/shuffle logic becomes the built-in PhasedShuffleMode; the permutational logic self-registers from MutationManager. Also splits PhasedDataProvider into PhasedDataProvider (core) and MutationalDataProvider (permutational), and renames MutationRampUpException to ExecutionModeConfigurationException, a generic execution-mode error unrelated to mutational testing. This removes the copy-paste-era coupling between the two testing modes without any Maven module split or public package/class renames, as a groundwork step for GitHub issue #224. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix code coverage gaps flagged on the MutationMode SPI PR Simplify the mutation-mode registry to a plain eagerly-built list instead of double-checked-locking lazy init (the laziness was only ever needed to work around the old classloading-side-effect registration approach, which ServiceLoader-based discovery no longer requires) — this removes an untestable synchronization branch that Codecov flagged as partially covered. Add tests for the two remaining gaps: registerMutationMode (previously never called by any test) and the ITestResult fallback branch in fetchApplicableMode, plus a test for ExecutionModeConfigurationException's message+cause constructor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> * Rename permutational package to stepdependencies, extract PERMUTATIONAL from core (#237) Groundwork for issue #224 (multi-module split), continuing from the merged MutationMode SPI decoupling PR. - Rename com.adobe.campaign.tests.integro.phased.permutational to ...stepdependencies. The package (ScenarioStepDependencies, ScenarioStepDependencyFactory, StepDependencies) was built in 2022 purely for legacy Phased Testing's step-order detection; "permutational" only describes half its purpose and its accidental echo of "Mutational" made it look mutational-owned, when it isn't. - Extract the ExecutionMode.PERMUTATIONAL execution mode out of PhasedTestManager: it was a by-product of the stepdependencies research, but is exclusively consumed by Mutational today, and was hardcoded inline in a core method (the same anti-pattern the merged SPI PR eliminated elsewhere, missed in that sweep since it didn't reference MutationManager by name). PhasedTestManager.fetchProvidersShuffled is restored to its original INTERRUPTIVE/NON_INTERRUPTIVE-only scope; MutationManager gains its own fetchProvidersShuffled that handles PERMUTATIONAL and delegates everything else back to PhasedTestManager. - Move the two PhasedTestManagerTests that exercised this PERMUTATIONAL behavior (and were already reaching into mutational-only test fixtures to do it) into MutationManagerTests, alongside the code they test. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> * Split phased-testing into a multi-module Maven project (closes #224) (#240) * Split phased-testing into a multi-module Maven project (issue #224) Converts the single-module project into a reactor of 4 modules, closing GitHub issue #224: - phased-testing-core (NEW): the shared engine — PhasedTestManager, ExecutionMode, Phases, ConfigValueHandlerPhased, PhasedEventManager, PhaseEvent, the stepdependencies.* engine, the MutationMode SPI, and the PhasedTest/PhaseEvent annotations. No authoring-model opinion. - phased-testing-testng (existing artifactId, kept for backward compatibility): the annotation-driven authoring model — PhasedTestListener, PhasedDataProvider. - phased-testing-mutational (NEW): the inheritance/template-method authoring model — Mutational, MutationManager, MutationListener, MutationalDataProvider. - phased-testing-test-fixtures (NEW, internal, deploy-skipped): test utilities and fixtures genuinely shared by both test suites (MockTestTools, TestTools, and a small number of data.* classes). Dependency direction is a clean DAG: core <- {testng, mutational}. Neither authoring module depends on the other. Consumers who only use the classic @PhasedTest model need no dependency changes beyond the version bump; Mutational users must add a new dependency on phased-testing-mutational. Two real cross-module couplings surfaced and were fixed during the split (both previously invisible in the single-module build): - PhasedTestManager.fetchProvidersStandard/fetchDataProviderValues referenced PhasedDataProvider directly. Introduced a spi.FrameworkDataProvider marker interface so core can recognize any authoring module's built-in data-provider class without a compile-time reference to it, and moved the "phased-default"/"phased-data-provider-single" provider-name constants into PhasedTestManager as the single source of truth. This replaces the narrower MutationMode.ownsDataProviderClass hook added for the same purpose in the prior SPI PR. - MutationListener's STANDARD-execution-mode fallback referenced PhasedDataProvider.SINGLE/DEFAULT directly. Added matching SINGLE/DEFAULT providers to MutationalDataProvider (delegating to the same core methods) so the mutational module no longer needs phased-testing-testng at all. - Several data.* test fixtures were bulk-assumed shareable but actually only work when physically co-located with the test that reads their .java source file for order-detection (ScenarioStepDependencyFactory/ ClassPathParser read source files off disk by relative path); these stay in phased-testing-testng. Only the fixtures genuinely used by both test suites (NormalSeries_A, MyNonInterruptiveEvent, MockTestTools, TestTools) moved to phased-testing-test-fixtures. README updated: dual Maven coordinates in Installation, and a 10.0.0 release notes entry documenting the breaking changes (module split, stepdependencies package rename, ExecutionModeConfigurationException rename from the prior PR). Verified: full reactor `mvn test` green, 438/438 tests passing across phased-testing-testng (414) and phased-testing-mutational (24) — same total as before the split. License header check passes for all new files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix SonarCloud quality gate failure after the multi-module split The multi-module reactor broke JaCoCo/Sonar coverage reporting: phased-testing-core and phased-testing-test-fixtures have no tests of their own by design (their code is exercised entirely by the phased-testing-testng and phased-testing-mutational test suites), so each module's own per-module jacoco.xml report showed them at 0% coverage even though the code is genuinely tested — JaCoCo's report goal only attributes recorded hits to classes physically compiled in that module's own target/classes, discarding hits recorded against sibling-module classes loaded from the reactor classpath. - Add phased-testing-report-aggregate, a jacoco:report-aggregate module depending on all four other modules, producing one combined coverage report across the whole reactor (confirmed: PhasedTestManager.java goes from 0% to ~97% line coverage in the aggregate). - Point sonar.coverage.jacoco.xmlReportPaths at that aggregate report. - Fix the two new_reliability_rating findings (java:S2142, "either re-interrupt this method or rethrow InterruptedException") in MyNonInterruptiveEvent.java, resurfaced by SonarCloud because the file's relocation into phased-testing-test-fixtures made it look like new code, even though only its physical location changed. Verified: mvn clean verify green across the full reactor, aggregate jacoco.xml confirmed to contain real (non-zero) coverage data for phased-testing-core classes, license:check passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> * Reorganize docs for the multi-module split: separate Phased/Mutational sections, extract changelog (#242) Follow-up to the issue #224 module split. The README hadn't caught up with the new architecture: it only ever documented the annotation-driven authoring model in depth, with Mutational Testing woven in as generic branding rather than its own authoring guide, and a ~90-line version history buried at the bottom. - Extract the full Release Notes history into CHANGELOG.md; README now just links to it. - Add an Architecture section up top explaining the 4-module split (phased-testing-core, -testng, -mutational, -test-fixtures) and which module to depend on for which authoring style. - Add a "Writing a Mutational Test" section (new — this authoring style had no dedicated guide before), grounded in Mutational.java/ MutationListener.java: extending Mutational, plain (non-@test) step methods, listener registration, and how it differs from a Phased Test. - Add explicit listener-registration snippets (testng.xml) to both "Writing a Phased Test" and "Writing a Mutational Test" — previously undocumented for either. - Rename "Running a Phased Test" to "Execution Modes and Configuration" and note explicitly that it's shared engine behavior, not phased-only. - Regenerate the Table of Contents to match. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> * Correct next version to 9.0.0, not 10.0.0 (#243) The changelog already had an unreleased "9.0.0 - In-Progress" entry (Execution Mode / Permutation work) predating the module-split work. That work incorrectly bumped to 10.0.0 as if it were a separate release, instead of landing as more entries under the existing in-progress 9.0.0. - Merge the module-split changelog entries into the existing 9.0.0 entry instead of a separate 10.0.0 one. - Set version to 9.0.0-SNAPSHOT in the parent POM and all 5 module POMs. - Update the two "As of version" references and the two dependency snippets in README.md from 10.0.0 to 9.0.0. Verified: mvn clean test green across the full reactor. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> * Rename PHASED.EVENTS.NONINTERRUPTIVE/TARGET to MUTATIONAL.* (#226) Renames PHASED.EVENTS.NONINTERRUPTIVE to MUTATIONAL.EVENTS.NONINTERRUPTIVE and PHASED.EVENTS.TARGET to MUTATIONAL.EVENTS.TARGET for naming consistency, keeping the old property names working via a deprecation fallback in ConfigValueHandlerPhased (mirrors the existing PROP_SELECTED_PHASE/PROP_EXECUTION_MODE precedent). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix isSet() and add test coverage for the deprecated-property fallback isSet() wasn't checking the deprecated system property name, only fetchValue() and reset() were. Adds a test covering the full fallback lifecycle to close the SonarCloud new_coverage gap on PR #244. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Uh oh!

In mutational PHASED.EVENTS.NONINTERRUPTIVE should be renamed to MUTATIONAL.EVENTS.NONINTERRUPTIVE #226

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions