Skip to content

simplify - #1

Merged
aeros merged 1 commit into
aeros:expand-news-entries-sphinxfrom
methane:expand-news-entries-sphinx
Aug 23, 2019
Merged

simplify#1
aeros merged 1 commit into
aeros:expand-news-entries-sphinxfrom
methane:expand-news-entries-sphinx

Conversation

@methane

Copy link
Copy Markdown

No description provided.

@aerosaeros left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @methane for the detailed suggestions! I really appreciate how much you've been able to help with this PR, I think it will definitely pay off since this section applies universally to any contributor since most will end up writing a Misc/NEWS entry at some point.

Overall, I agree with the major changes you made, but I had a few minor recommendations. I don't mind adding them in myself to the orginal PR, but I wanted to make sure that you agreed with them first.

Comment threaddocumenting.rst
Comment threadcommitting.rst
Comment threadcommitting.rst
Comment threadcommitting.rst
Comment threadcommitting.rst
@aeros
aeros merged commit 8f98858 into aeros:expand-news-entries-sphinxAug 23, 2019
@methane
methane deleted the expand-news-entries-sphinx branch August 23, 2019 05:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@methane@aeros