Do NOT fall back to ogles2vk_LookupProcAddr() - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That returns APICALL trampolines (libcall ABI: Self in r3, args in r4-r10) which are only valid when invoked via the AmigaOS interface dispatch. vkGetDeviceProcAddr() is supposed to hand back raw, standard-Vulkan-ABI function pointers that the application calls directly as PFN_vkXxx — feeding a libcall trampoline through that path makes every argument slide by one register slot at call time, which manifests as pCreateInfo/pSwapchain arriving as NULL in downstream functions like ogles2vk_CreateSwapchainKHR.
Match software_vk's behaviour: return NULL for unknown names. The caller can then fall back to its own dispatch (e.g. through IVulkan with proper Self setup) for functions not represented in the RAW table — most notably the WSI swapchain entry points.
Added makefile for cross compilation when not using docker