Skip to content

Do NOT fall back to ogles2vk_LookupProcAddr() - #2

Merged
afxgroup merged 1 commit into
mainfrom
fix/no_fallback_on_ogles2vk_LookupProcAddr
May 11, 2026
Merged

afxgroup merged 1 commit into
mainfrom
fix/no_fallback_on_ogles2vk_LookupProcAddr

Conversation

@afxgroup

Copy link
Copy Markdown
Owner

That returns APICALL trampolines (libcall ABI: Self in r3, args in r4-r10) which are only valid when invoked via the AmigaOS interface dispatch. vkGetDeviceProcAddr() is supposed to hand back raw, standard-Vulkan-ABI function pointers that the application calls directly as PFN_vkXxx — feeding a libcall trampoline through that path makes every argument slide by one register slot at call time, which manifests as pCreateInfo/pSwapchain arriving as NULL in downstream functions like ogles2vk_CreateSwapchainKHR.
Match software_vk's behaviour: return NULL for unknown names. The caller can then fall back to its own dispatch (e.g. through IVulkan with proper Self setup) for functions not represented in the RAW table — most notably the WSI swapchain entry points.

Added makefile for cross compilation when not using docker

@afxgroup
afxgroup merged commit ea2bc56 into main May 11, 2026
@afxgroup
afxgroup deleted the fix/no_fallback_on_ogles2vk_LookupProcAddr branch May 11, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant