Skip to content

feat: add receive_timeout parameter to Connection class#84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PsiACE merged 1 commit into from
May 7, 2026
+5 −1
Merged

feat: add receive_timeout parameter to Connection class #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/acp/connection.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ def __init__(
sender_factory: SenderFactory | None = None,
observers: list[StreamObserver] | None = None,
listening: bool = True,
receive_timeout: float | None = None,
) -> None:
self._handler = handler
self._writer = writer
Expand DownExpand Up@@ -103,6 +104,7 @@ def __init__(
)
self._dispatcher.start()
self._observers: list[StreamObserver] = list(observers or [])
self._receive_timeout = receive_timeout

async def close(self) -> None:
"""Stop the receive loop and cancel any in-flight handler tasks."""
Expand DownExpand Up@@ -151,7 +153,7 @@ async def send_notification(self, method: str, params: JsonValue | None = None)
async def _receive_loop(self) -> None:
try:
while True:
line = await self._reader.readline()
line = await asyncio.wait_for(self._reader.readline(), timeout=self._receive_timeout)
if not line:
break
line = line.strip()
Expand All@@ -166,6 +168,8 @@ async def _receive_loop(self) -> None:
await self._process_message(message)
except asyncio.CancelledError:
return
except asyncio.TimeoutError:
raise RequestError.internal_error({"details": "Agent timeout"}) from None
self._disconnect()

async def _process_message(self, message: dict[str, Any]) -> None:
Expand Down