feat(sdk): add otel support - #177

Merged
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support
May 8, 2026
Merged

feat(sdk): add otel support#177
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support

Conversation

@namrataghadi-galileo

@namrataghadi-galileonamrataghadi-galileo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Added configurable observability sink selection for the Python SDK and server so control events can be routed to the default backend, registered custom sinks, or named sink factories.

Added a built-in OpenTelemetry sink for the SDK, including OTLP configuration via settings/environment variables.

Updated docs and exports so custom sink registration and OTEL usage are available as public integration points.

Scope

User-facing/API changes:

  • Added observability_sink_name and observability_sink_config to SDK initialization/configuration
  • Exposed sink registration helpers and OTEL conversion utilities from the Python SDK public API
  • Added documented support for the SDK otel extra and OTEL-related environment variables
  • Added server observability sink selection/config support for named backends

Internal changes:

  • Introduced shared sink-selection models/registry helpers in telemetry/
  • Refactored SDK observability to resolve active sinks dynamically and support named/custom sinks
  • Refactored server startup/shutdown to resolve observability backends through sink selection
  • Added test coverage for sink selection, lifecycle handling, OTEL sink behavior, and re-init/policy refresh interactions

Out of scope:

  • No changes to core control evaluation semantics
  • No UI changes
  • No new non-OTEL external sink implementation included beyond registration hooks

Risk and Rollout

Risk level: medium

Rollback plan: Revert the sink-selection/OTEL changeset to restore the previous default SDK-to-server observability path only. If needed, disable custom routing by keeping observability_sink_name=default and not installing/configuring the otel extra.

Testing

  • Added or updated automated tests
  • Ran make check — typecheck was attempted but full local make check was not run because uv was unavailable in this environment
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@namrataghadi-galileo
namrataghadi-galileo changed the base branch from main to feature/61576-add-config-driven-sink-selectionApril 16, 2026 22:36
@codecov

codecovBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.20408% with 24 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/otel_sink.py89.50%19 Missing ⚠️
sdks/python/src/agent_control/observability.py93.61%3 Missing ⚠️
...dks/python/src/agent_control/control_decorators.py90.00%1 Missing ⚠️
telemetry/src/agent_control_telemetry/sinks.py50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

lan17
lan17 requested changes Apr 18, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having a built-in OTEL path, but I don't think this version is safe to merge yet. Right now the SDK can tell callers observability is working while the OTEL sink is effectively inert, and the caching logic doesn't compose cleanly with the new otel_* settings. I'd also mark failed control executions as OTEL errors rather than only attaching an exception object.

Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
@namrataghadi-galileo

namrataghadi-galileo commented Apr 19, 2026

Copy link
Copy Markdown
ContributorAuthor

@lan17 Thanks, this was a good catch. I fixed the three unsafe parts you called out:

The built-in otel sink no longer counts as active when it can’t actually export. If OTEL is disabled, deps are missing, or there’s no exporter configuration, we now treat that sink as inert for observability selection instead of reporting observability as working.
The named-sink cache now keys off the effective resolved OTEL config, so changes to otel_enabled / otel_endpoint / otel_headers / otel_service_name rebuild the cached OTEL sink instead of reusing a stale one.
Failed control executions now mark the OTEL span status as ERROR in addition to recording the exception.
I also added regression tests for the inert-sink case, the OTEL settings cache invalidation case, and the error-status span behavior. Targeted SDK observability/OTEL tests are passing locally.

Base automatically changed from feature/61576-add-config-driven-sink-selection to mainApril 22, 2026 20:41
lan17
lan17 requested changes May 7, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tightening up the earlier OTEL issues. I found one remaining opt-out case that I think should be fixed before merge: an explicit observability_enabled=False can still leave the selected OTEL sink active for later writes.

Comment threadsdks/python/src/agent_control/observability.py
lan17
lan17 approved these changes May 8, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the review feedback, Namrata. I did a fresh pass from the latest head, including the opt-out path and the OTEL sink/cache behavior, and this looks good to me now.

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) May 8, 2026 15:02
@namrataghadi-galileo
namrataghadi-galileo merged commit 9530368 into mainMay 8, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/61578-add-otel-support branch May 8, 2026 15:02
@karansohikaransohi mentioned this pull request May 11, 2026
Closed
4 tasks
galileo-automation pushed a commit that referenced this pull request May 28, 2026
@semantic-release-bot
chore(release): ts sdk v2.6.0 [skip ci]
a953da5
## [2.6.0](ts-sdk-v2.5.0...ts-sdk-v2.6.0) (2026-05-28)
### Features
* **evaluators:** add new lluna client ([#213](#213)) ([f65beb9](f65beb9))
* **sdk:** add otel support ([#177](#177)) ([9530368](9530368))
* **sdk:** add runtime token auth ([#215](#215)) ([6cc0f38](6cc0f38))
* **server:** add control clone-and-bind endpoint ([#229](#229)) ([1728bf9](1728bf9))
* **server:** add runtime auth and namespace scoping ([#214](#214)) ([56e44fe](56e44fe))
* **server:** allow host-owned logging setup ([#227](#227)) ([c0fd159](c0fd159))
* **server:** bundle migrations in wheel and add agent-control-migrate ([#209](#209)) ([8c5c35e](8c5c35e))
* **server:** migrate controls routes to auth framework ([#212](#212)) ([764bd4b](764bd4b))
### Bug Fixes
* **examples:** declare local SDK workspace deps ([#222](#222)) ([d22aa1d](d22aa1d))
* **sdk:** Get trace context from provider ([#211](#211)) ([1efe30f](1efe30f))
* **sdk-ts:** normalize generated client ([#231](#231)) ([1c097d2](1c097d2))
* **server:** make observability migration retry-safe ([#226](#226)) ([b9dd00d](b9dd00d))
* **server:** prevent migration lock transactions ([#224](#224)) ([e65a2f4](e65a2f4))
* **server:** scope auth upstream CA to HTTP provider ([#232](#232)) ([7a0ce21](7a0ce21))
* **ui:** fix editing of controls in the UI ([#218](#218)) ([981e33d](981e33d)), closes [#Risk](https://github.com/agentcontrol/agent-control/issues/Risk)
@galileo-automation

galileo-automation commented May 28, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan17lan17lan17 approved these changes
@abhinav-galileoabhinav-galileoAwaiting requested review from abhinav-galileo
@savula15savula15Awaiting requested review from savula15

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namrataghadi-galileo@galileo-automation@lan17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(sdk): add otel support - #177

Merged
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support
May 8, 2026
Merged

feat(sdk): add otel support#177
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support

Conversation

@namrataghadi-galileo

@namrataghadi-galileonamrataghadi-galileo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Added configurable observability sink selection for the Python SDK and server so control events can be routed to the default backend, registered custom sinks, or named sink factories.

Added a built-in OpenTelemetry sink for the SDK, including OTLP configuration via settings/environment variables.

Updated docs and exports so custom sink registration and OTEL usage are available as public integration points.

Scope

User-facing/API changes:

  • Added observability_sink_name and observability_sink_config to SDK initialization/configuration
  • Exposed sink registration helpers and OTEL conversion utilities from the Python SDK public API
  • Added documented support for the SDK otel extra and OTEL-related environment variables
  • Added server observability sink selection/config support for named backends

Internal changes:

  • Introduced shared sink-selection models/registry helpers in telemetry/
  • Refactored SDK observability to resolve active sinks dynamically and support named/custom sinks
  • Refactored server startup/shutdown to resolve observability backends through sink selection
  • Added test coverage for sink selection, lifecycle handling, OTEL sink behavior, and re-init/policy refresh interactions

Out of scope:

  • No changes to core control evaluation semantics
  • No UI changes
  • No new non-OTEL external sink implementation included beyond registration hooks

Risk and Rollout

Risk level: medium

Rollback plan: Revert the sink-selection/OTEL changeset to restore the previous default SDK-to-server observability path only. If needed, disable custom routing by keeping observability_sink_name=default and not installing/configuring the otel extra.

Testing

  • Added or updated automated tests
  • Ran make check — typecheck was attempted but full local make check was not run because uv was unavailable in this environment
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@namrataghadi-galileo
namrataghadi-galileo changed the base branch from main to feature/61576-add-config-driven-sink-selectionApril 16, 2026 22:36
@codecov

codecovBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.20408% with 24 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/otel_sink.py89.50%19 Missing ⚠️
sdks/python/src/agent_control/observability.py93.61%3 Missing ⚠️
...dks/python/src/agent_control/control_decorators.py90.00%1 Missing ⚠️
telemetry/src/agent_control_telemetry/sinks.py50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

lan17
lan17 requested changes Apr 18, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having a built-in OTEL path, but I don't think this version is safe to merge yet. Right now the SDK can tell callers observability is working while the OTEL sink is effectively inert, and the caching logic doesn't compose cleanly with the new otel_* settings. I'd also mark failed control executions as OTEL errors rather than only attaching an exception object.

Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
@namrataghadi-galileo

namrataghadi-galileo commented Apr 19, 2026

Copy link
Copy Markdown
ContributorAuthor

@lan17 Thanks, this was a good catch. I fixed the three unsafe parts you called out:

The built-in otel sink no longer counts as active when it can’t actually export. If OTEL is disabled, deps are missing, or there’s no exporter configuration, we now treat that sink as inert for observability selection instead of reporting observability as working.
The named-sink cache now keys off the effective resolved OTEL config, so changes to otel_enabled / otel_endpoint / otel_headers / otel_service_name rebuild the cached OTEL sink instead of reusing a stale one.
Failed control executions now mark the OTEL span status as ERROR in addition to recording the exception.
I also added regression tests for the inert-sink case, the OTEL settings cache invalidation case, and the error-status span behavior. Targeted SDK observability/OTEL tests are passing locally.

Base automatically changed from feature/61576-add-config-driven-sink-selection to mainApril 22, 2026 20:41
lan17
lan17 requested changes May 7, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tightening up the earlier OTEL issues. I found one remaining opt-out case that I think should be fixed before merge: an explicit observability_enabled=False can still leave the selected OTEL sink active for later writes.

Comment threadsdks/python/src/agent_control/observability.py
lan17
lan17 approved these changes May 8, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the review feedback, Namrata. I did a fresh pass from the latest head, including the opt-out path and the OTEL sink/cache behavior, and this looks good to me now.

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) May 8, 2026 15:02
@namrataghadi-galileo
namrataghadi-galileo merged commit 9530368 into mainMay 8, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/61578-add-otel-support branch May 8, 2026 15:02
@karansohikaransohi mentioned this pull request May 11, 2026
Closed
4 tasks
galileo-automation pushed a commit that referenced this pull request May 28, 2026
@semantic-release-bot
chore(release): ts sdk v2.6.0 [skip ci]
a953da5
## [2.6.0](ts-sdk-v2.5.0...ts-sdk-v2.6.0) (2026-05-28)
### Features
* **evaluators:** add new lluna client ([#213](#213)) ([f65beb9](f65beb9))
* **sdk:** add otel support ([#177](#177)) ([9530368](9530368))
* **sdk:** add runtime token auth ([#215](#215)) ([6cc0f38](6cc0f38))
* **server:** add control clone-and-bind endpoint ([#229](#229)) ([1728bf9](1728bf9))
* **server:** add runtime auth and namespace scoping ([#214](#214)) ([56e44fe](56e44fe))
* **server:** allow host-owned logging setup ([#227](#227)) ([c0fd159](c0fd159))
* **server:** bundle migrations in wheel and add agent-control-migrate ([#209](#209)) ([8c5c35e](8c5c35e))
* **server:** migrate controls routes to auth framework ([#212](#212)) ([764bd4b](764bd4b))
### Bug Fixes
* **examples:** declare local SDK workspace deps ([#222](#222)) ([d22aa1d](d22aa1d))
* **sdk:** Get trace context from provider ([#211](#211)) ([1efe30f](1efe30f))
* **sdk-ts:** normalize generated client ([#231](#231)) ([1c097d2](1c097d2))
* **server:** make observability migration retry-safe ([#226](#226)) ([b9dd00d](b9dd00d))
* **server:** prevent migration lock transactions ([#224](#224)) ([e65a2f4](e65a2f4))
* **server:** scope auth upstream CA to HTTP provider ([#232](#232)) ([7a0ce21](7a0ce21))
* **ui:** fix editing of controls in the UI ([#218](#218)) ([981e33d](981e33d)), closes [#Risk](https://github.com/agentcontrol/agent-control/issues/Risk)
@galileo-automation

galileo-automation commented May 28, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan17lan17lan17 approved these changes
@abhinav-galileoabhinav-galileoAwaiting requested review from abhinav-galileo
@savula15savula15Awaiting requested review from savula15

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namrataghadi-galileo@galileo-automation@lan17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(sdk): add otel support - #177

Merged
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support
May 8, 2026
Merged

feat(sdk): add otel support#177
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support

Conversation

@namrataghadi-galileo

@namrataghadi-galileonamrataghadi-galileo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Added configurable observability sink selection for the Python SDK and server so control events can be routed to the default backend, registered custom sinks, or named sink factories.

Added a built-in OpenTelemetry sink for the SDK, including OTLP configuration via settings/environment variables.

Updated docs and exports so custom sink registration and OTEL usage are available as public integration points.

Scope

User-facing/API changes:

  • Added observability_sink_name and observability_sink_config to SDK initialization/configuration
  • Exposed sink registration helpers and OTEL conversion utilities from the Python SDK public API
  • Added documented support for the SDK otel extra and OTEL-related environment variables
  • Added server observability sink selection/config support for named backends

Internal changes:

  • Introduced shared sink-selection models/registry helpers in telemetry/
  • Refactored SDK observability to resolve active sinks dynamically and support named/custom sinks
  • Refactored server startup/shutdown to resolve observability backends through sink selection
  • Added test coverage for sink selection, lifecycle handling, OTEL sink behavior, and re-init/policy refresh interactions

Out of scope:

  • No changes to core control evaluation semantics
  • No UI changes
  • No new non-OTEL external sink implementation included beyond registration hooks

Risk and Rollout

Risk level: medium

Rollback plan: Revert the sink-selection/OTEL changeset to restore the previous default SDK-to-server observability path only. If needed, disable custom routing by keeping observability_sink_name=default and not installing/configuring the otel extra.

Testing

  • Added or updated automated tests
  • Ran make check — typecheck was attempted but full local make check was not run because uv was unavailable in this environment
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@namrataghadi-galileo
namrataghadi-galileo changed the base branch from main to feature/61576-add-config-driven-sink-selectionApril 16, 2026 22:36
@codecov

codecovBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.20408% with 24 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/otel_sink.py89.50%19 Missing ⚠️
sdks/python/src/agent_control/observability.py93.61%3 Missing ⚠️
...dks/python/src/agent_control/control_decorators.py90.00%1 Missing ⚠️
telemetry/src/agent_control_telemetry/sinks.py50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

lan17
lan17 requested changes Apr 18, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having a built-in OTEL path, but I don't think this version is safe to merge yet. Right now the SDK can tell callers observability is working while the OTEL sink is effectively inert, and the caching logic doesn't compose cleanly with the new otel_* settings. I'd also mark failed control executions as OTEL errors rather than only attaching an exception object.

Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
@namrataghadi-galileo

namrataghadi-galileo commented Apr 19, 2026

Copy link
Copy Markdown
ContributorAuthor

@lan17 Thanks, this was a good catch. I fixed the three unsafe parts you called out:

The built-in otel sink no longer counts as active when it can’t actually export. If OTEL is disabled, deps are missing, or there’s no exporter configuration, we now treat that sink as inert for observability selection instead of reporting observability as working.
The named-sink cache now keys off the effective resolved OTEL config, so changes to otel_enabled / otel_endpoint / otel_headers / otel_service_name rebuild the cached OTEL sink instead of reusing a stale one.
Failed control executions now mark the OTEL span status as ERROR in addition to recording the exception.
I also added regression tests for the inert-sink case, the OTEL settings cache invalidation case, and the error-status span behavior. Targeted SDK observability/OTEL tests are passing locally.

Base automatically changed from feature/61576-add-config-driven-sink-selection to mainApril 22, 2026 20:41
lan17
lan17 requested changes May 7, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tightening up the earlier OTEL issues. I found one remaining opt-out case that I think should be fixed before merge: an explicit observability_enabled=False can still leave the selected OTEL sink active for later writes.

Comment threadsdks/python/src/agent_control/observability.py
lan17
lan17 approved these changes May 8, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the review feedback, Namrata. I did a fresh pass from the latest head, including the opt-out path and the OTEL sink/cache behavior, and this looks good to me now.

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) May 8, 2026 15:02
@namrataghadi-galileo
namrataghadi-galileo merged commit 9530368 into mainMay 8, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/61578-add-otel-support branch May 8, 2026 15:02
@karansohikaransohi mentioned this pull request May 11, 2026
Closed
4 tasks
galileo-automation pushed a commit that referenced this pull request May 28, 2026
@semantic-release-bot
chore(release): ts sdk v2.6.0 [skip ci]
a953da5
## [2.6.0](ts-sdk-v2.5.0...ts-sdk-v2.6.0) (2026-05-28)
### Features
* **evaluators:** add new lluna client ([#213](#213)) ([f65beb9](f65beb9))
* **sdk:** add otel support ([#177](#177)) ([9530368](9530368))
* **sdk:** add runtime token auth ([#215](#215)) ([6cc0f38](6cc0f38))
* **server:** add control clone-and-bind endpoint ([#229](#229)) ([1728bf9](1728bf9))
* **server:** add runtime auth and namespace scoping ([#214](#214)) ([56e44fe](56e44fe))
* **server:** allow host-owned logging setup ([#227](#227)) ([c0fd159](c0fd159))
* **server:** bundle migrations in wheel and add agent-control-migrate ([#209](#209)) ([8c5c35e](8c5c35e))
* **server:** migrate controls routes to auth framework ([#212](#212)) ([764bd4b](764bd4b))
### Bug Fixes
* **examples:** declare local SDK workspace deps ([#222](#222)) ([d22aa1d](d22aa1d))
* **sdk:** Get trace context from provider ([#211](#211)) ([1efe30f](1efe30f))
* **sdk-ts:** normalize generated client ([#231](#231)) ([1c097d2](1c097d2))
* **server:** make observability migration retry-safe ([#226](#226)) ([b9dd00d](b9dd00d))
* **server:** prevent migration lock transactions ([#224](#224)) ([e65a2f4](e65a2f4))
* **server:** scope auth upstream CA to HTTP provider ([#232](#232)) ([7a0ce21](7a0ce21))
* **ui:** fix editing of controls in the UI ([#218](#218)) ([981e33d](981e33d)), closes [#Risk](https://github.com/agentcontrol/agent-control/issues/Risk)
@galileo-automation

galileo-automation commented May 28, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan17lan17lan17 approved these changes
@abhinav-galileoabhinav-galileoAwaiting requested review from abhinav-galileo
@savula15savula15Awaiting requested review from savula15

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namrataghadi-galileo@galileo-automation@lan17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(sdk): add otel support - #177

Merged
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support
May 8, 2026
Merged

feat(sdk): add otel support#177
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support

Conversation

@namrataghadi-galileo

@namrataghadi-galileonamrataghadi-galileo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Added configurable observability sink selection for the Python SDK and server so control events can be routed to the default backend, registered custom sinks, or named sink factories.

Added a built-in OpenTelemetry sink for the SDK, including OTLP configuration via settings/environment variables.

Updated docs and exports so custom sink registration and OTEL usage are available as public integration points.

Scope

User-facing/API changes:

  • Added observability_sink_name and observability_sink_config to SDK initialization/configuration
  • Exposed sink registration helpers and OTEL conversion utilities from the Python SDK public API
  • Added documented support for the SDK otel extra and OTEL-related environment variables
  • Added server observability sink selection/config support for named backends

Internal changes:

  • Introduced shared sink-selection models/registry helpers in telemetry/
  • Refactored SDK observability to resolve active sinks dynamically and support named/custom sinks
  • Refactored server startup/shutdown to resolve observability backends through sink selection
  • Added test coverage for sink selection, lifecycle handling, OTEL sink behavior, and re-init/policy refresh interactions

Out of scope:

  • No changes to core control evaluation semantics
  • No UI changes
  • No new non-OTEL external sink implementation included beyond registration hooks

Risk and Rollout

Risk level: medium

Rollback plan: Revert the sink-selection/OTEL changeset to restore the previous default SDK-to-server observability path only. If needed, disable custom routing by keeping observability_sink_name=default and not installing/configuring the otel extra.

Testing

  • Added or updated automated tests
  • Ran make check — typecheck was attempted but full local make check was not run because uv was unavailable in this environment
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@namrataghadi-galileo
namrataghadi-galileo changed the base branch from main to feature/61576-add-config-driven-sink-selectionApril 16, 2026 22:36
@codecov

codecovBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.20408% with 24 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/otel_sink.py89.50%19 Missing ⚠️
sdks/python/src/agent_control/observability.py93.61%3 Missing ⚠️
...dks/python/src/agent_control/control_decorators.py90.00%1 Missing ⚠️
telemetry/src/agent_control_telemetry/sinks.py50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

lan17
lan17 requested changes Apr 18, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having a built-in OTEL path, but I don't think this version is safe to merge yet. Right now the SDK can tell callers observability is working while the OTEL sink is effectively inert, and the caching logic doesn't compose cleanly with the new otel_* settings. I'd also mark failed control executions as OTEL errors rather than only attaching an exception object.

Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
@namrataghadi-galileo

namrataghadi-galileo commented Apr 19, 2026

Copy link
Copy Markdown
ContributorAuthor

@lan17 Thanks, this was a good catch. I fixed the three unsafe parts you called out:

The built-in otel sink no longer counts as active when it can’t actually export. If OTEL is disabled, deps are missing, or there’s no exporter configuration, we now treat that sink as inert for observability selection instead of reporting observability as working.
The named-sink cache now keys off the effective resolved OTEL config, so changes to otel_enabled / otel_endpoint / otel_headers / otel_service_name rebuild the cached OTEL sink instead of reusing a stale one.
Failed control executions now mark the OTEL span status as ERROR in addition to recording the exception.
I also added regression tests for the inert-sink case, the OTEL settings cache invalidation case, and the error-status span behavior. Targeted SDK observability/OTEL tests are passing locally.

Base automatically changed from feature/61576-add-config-driven-sink-selection to mainApril 22, 2026 20:41
lan17
lan17 requested changes May 7, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tightening up the earlier OTEL issues. I found one remaining opt-out case that I think should be fixed before merge: an explicit observability_enabled=False can still leave the selected OTEL sink active for later writes.

Comment threadsdks/python/src/agent_control/observability.py
lan17
lan17 approved these changes May 8, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the review feedback, Namrata. I did a fresh pass from the latest head, including the opt-out path and the OTEL sink/cache behavior, and this looks good to me now.

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) May 8, 2026 15:02
@namrataghadi-galileo
namrataghadi-galileo merged commit 9530368 into mainMay 8, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/61578-add-otel-support branch May 8, 2026 15:02
@karansohikaransohi mentioned this pull request May 11, 2026
Closed
4 tasks
galileo-automation pushed a commit that referenced this pull request May 28, 2026
@semantic-release-bot
chore(release): ts sdk v2.6.0 [skip ci]
a953da5
## [2.6.0](ts-sdk-v2.5.0...ts-sdk-v2.6.0) (2026-05-28)
### Features
* **evaluators:** add new lluna client ([#213](#213)) ([f65beb9](f65beb9))
* **sdk:** add otel support ([#177](#177)) ([9530368](9530368))
* **sdk:** add runtime token auth ([#215](#215)) ([6cc0f38](6cc0f38))
* **server:** add control clone-and-bind endpoint ([#229](#229)) ([1728bf9](1728bf9))
* **server:** add runtime auth and namespace scoping ([#214](#214)) ([56e44fe](56e44fe))
* **server:** allow host-owned logging setup ([#227](#227)) ([c0fd159](c0fd159))
* **server:** bundle migrations in wheel and add agent-control-migrate ([#209](#209)) ([8c5c35e](8c5c35e))
* **server:** migrate controls routes to auth framework ([#212](#212)) ([764bd4b](764bd4b))
### Bug Fixes
* **examples:** declare local SDK workspace deps ([#222](#222)) ([d22aa1d](d22aa1d))
* **sdk:** Get trace context from provider ([#211](#211)) ([1efe30f](1efe30f))
* **sdk-ts:** normalize generated client ([#231](#231)) ([1c097d2](1c097d2))
* **server:** make observability migration retry-safe ([#226](#226)) ([b9dd00d](b9dd00d))
* **server:** prevent migration lock transactions ([#224](#224)) ([e65a2f4](e65a2f4))
* **server:** scope auth upstream CA to HTTP provider ([#232](#232)) ([7a0ce21](7a0ce21))
* **ui:** fix editing of controls in the UI ([#218](#218)) ([981e33d](981e33d)), closes [#Risk](https://github.com/agentcontrol/agent-control/issues/Risk)
@galileo-automation

galileo-automation commented May 28, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan17lan17lan17 approved these changes
@abhinav-galileoabhinav-galileoAwaiting requested review from abhinav-galileo
@savula15savula15Awaiting requested review from savula15

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namrataghadi-galileo@galileo-automation@lan17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(sdk): add otel support - #177

Merged
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support
May 8, 2026
Merged

feat(sdk): add otel support#177
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support

Conversation

@namrataghadi-galileo

@namrataghadi-galileonamrataghadi-galileo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Added configurable observability sink selection for the Python SDK and server so control events can be routed to the default backend, registered custom sinks, or named sink factories.

Added a built-in OpenTelemetry sink for the SDK, including OTLP configuration via settings/environment variables.

Updated docs and exports so custom sink registration and OTEL usage are available as public integration points.

Scope

User-facing/API changes:

  • Added observability_sink_name and observability_sink_config to SDK initialization/configuration
  • Exposed sink registration helpers and OTEL conversion utilities from the Python SDK public API
  • Added documented support for the SDK otel extra and OTEL-related environment variables
  • Added server observability sink selection/config support for named backends

Internal changes:

  • Introduced shared sink-selection models/registry helpers in telemetry/
  • Refactored SDK observability to resolve active sinks dynamically and support named/custom sinks
  • Refactored server startup/shutdown to resolve observability backends through sink selection
  • Added test coverage for sink selection, lifecycle handling, OTEL sink behavior, and re-init/policy refresh interactions

Out of scope:

  • No changes to core control evaluation semantics
  • No UI changes
  • No new non-OTEL external sink implementation included beyond registration hooks

Risk and Rollout

Risk level: medium

Rollback plan: Revert the sink-selection/OTEL changeset to restore the previous default SDK-to-server observability path only. If needed, disable custom routing by keeping observability_sink_name=default and not installing/configuring the otel extra.

Testing

  • Added or updated automated tests
  • Ran make check — typecheck was attempted but full local make check was not run because uv was unavailable in this environment
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@namrataghadi-galileo
namrataghadi-galileo changed the base branch from main to feature/61576-add-config-driven-sink-selectionApril 16, 2026 22:36
@codecov

codecovBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.20408% with 24 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/otel_sink.py89.50%19 Missing ⚠️
sdks/python/src/agent_control/observability.py93.61%3 Missing ⚠️
...dks/python/src/agent_control/control_decorators.py90.00%1 Missing ⚠️
telemetry/src/agent_control_telemetry/sinks.py50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

lan17
lan17 requested changes Apr 18, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having a built-in OTEL path, but I don't think this version is safe to merge yet. Right now the SDK can tell callers observability is working while the OTEL sink is effectively inert, and the caching logic doesn't compose cleanly with the new otel_* settings. I'd also mark failed control executions as OTEL errors rather than only attaching an exception object.

Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
@namrataghadi-galileo

namrataghadi-galileo commented Apr 19, 2026

Copy link
Copy Markdown
ContributorAuthor

@lan17 Thanks, this was a good catch. I fixed the three unsafe parts you called out:

The built-in otel sink no longer counts as active when it can’t actually export. If OTEL is disabled, deps are missing, or there’s no exporter configuration, we now treat that sink as inert for observability selection instead of reporting observability as working.
The named-sink cache now keys off the effective resolved OTEL config, so changes to otel_enabled / otel_endpoint / otel_headers / otel_service_name rebuild the cached OTEL sink instead of reusing a stale one.
Failed control executions now mark the OTEL span status as ERROR in addition to recording the exception.
I also added regression tests for the inert-sink case, the OTEL settings cache invalidation case, and the error-status span behavior. Targeted SDK observability/OTEL tests are passing locally.

Base automatically changed from feature/61576-add-config-driven-sink-selection to mainApril 22, 2026 20:41
lan17
lan17 requested changes May 7, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tightening up the earlier OTEL issues. I found one remaining opt-out case that I think should be fixed before merge: an explicit observability_enabled=False can still leave the selected OTEL sink active for later writes.

Comment threadsdks/python/src/agent_control/observability.py
lan17
lan17 approved these changes May 8, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the review feedback, Namrata. I did a fresh pass from the latest head, including the opt-out path and the OTEL sink/cache behavior, and this looks good to me now.

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) May 8, 2026 15:02
@namrataghadi-galileo
namrataghadi-galileo merged commit 9530368 into mainMay 8, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/61578-add-otel-support branch May 8, 2026 15:02
@karansohikaransohi mentioned this pull request May 11, 2026
Closed
4 tasks
galileo-automation pushed a commit that referenced this pull request May 28, 2026
@semantic-release-bot
chore(release): ts sdk v2.6.0 [skip ci]
a953da5
## [2.6.0](ts-sdk-v2.5.0...ts-sdk-v2.6.0) (2026-05-28)
### Features
* **evaluators:** add new lluna client ([#213](#213)) ([f65beb9](f65beb9))
* **sdk:** add otel support ([#177](#177)) ([9530368](9530368))
* **sdk:** add runtime token auth ([#215](#215)) ([6cc0f38](6cc0f38))
* **server:** add control clone-and-bind endpoint ([#229](#229)) ([1728bf9](1728bf9))
* **server:** add runtime auth and namespace scoping ([#214](#214)) ([56e44fe](56e44fe))
* **server:** allow host-owned logging setup ([#227](#227)) ([c0fd159](c0fd159))
* **server:** bundle migrations in wheel and add agent-control-migrate ([#209](#209)) ([8c5c35e](8c5c35e))
* **server:** migrate controls routes to auth framework ([#212](#212)) ([764bd4b](764bd4b))
### Bug Fixes
* **examples:** declare local SDK workspace deps ([#222](#222)) ([d22aa1d](d22aa1d))
* **sdk:** Get trace context from provider ([#211](#211)) ([1efe30f](1efe30f))
* **sdk-ts:** normalize generated client ([#231](#231)) ([1c097d2](1c097d2))
* **server:** make observability migration retry-safe ([#226](#226)) ([b9dd00d](b9dd00d))
* **server:** prevent migration lock transactions ([#224](#224)) ([e65a2f4](e65a2f4))
* **server:** scope auth upstream CA to HTTP provider ([#232](#232)) ([7a0ce21](7a0ce21))
* **ui:** fix editing of controls in the UI ([#218](#218)) ([981e33d](981e33d)), closes [#Risk](https://github.com/agentcontrol/agent-control/issues/Risk)
@galileo-automation

galileo-automation commented May 28, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan17lan17lan17 approved these changes
@abhinav-galileoabhinav-galileoAwaiting requested review from abhinav-galileo
@savula15savula15Awaiting requested review from savula15

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namrataghadi-galileo@galileo-automation@lan17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(sdk): add otel support - #177

Merged
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support
May 8, 2026
Merged

feat(sdk): add otel support#177
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support

Conversation

@namrataghadi-galileo

@namrataghadi-galileonamrataghadi-galileo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Added configurable observability sink selection for the Python SDK and server so control events can be routed to the default backend, registered custom sinks, or named sink factories.

Added a built-in OpenTelemetry sink for the SDK, including OTLP configuration via settings/environment variables.

Updated docs and exports so custom sink registration and OTEL usage are available as public integration points.

Scope

User-facing/API changes:

  • Added observability_sink_name and observability_sink_config to SDK initialization/configuration
  • Exposed sink registration helpers and OTEL conversion utilities from the Python SDK public API
  • Added documented support for the SDK otel extra and OTEL-related environment variables
  • Added server observability sink selection/config support for named backends

Internal changes:

  • Introduced shared sink-selection models/registry helpers in telemetry/
  • Refactored SDK observability to resolve active sinks dynamically and support named/custom sinks
  • Refactored server startup/shutdown to resolve observability backends through sink selection
  • Added test coverage for sink selection, lifecycle handling, OTEL sink behavior, and re-init/policy refresh interactions

Out of scope:

  • No changes to core control evaluation semantics
  • No UI changes
  • No new non-OTEL external sink implementation included beyond registration hooks

Risk and Rollout

Risk level: medium

Rollback plan: Revert the sink-selection/OTEL changeset to restore the previous default SDK-to-server observability path only. If needed, disable custom routing by keeping observability_sink_name=default and not installing/configuring the otel extra.

Testing

  • Added or updated automated tests
  • Ran make check — typecheck was attempted but full local make check was not run because uv was unavailable in this environment
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@namrataghadi-galileo
namrataghadi-galileo changed the base branch from main to feature/61576-add-config-driven-sink-selectionApril 16, 2026 22:36
@codecov

codecovBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.20408% with 24 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/otel_sink.py89.50%19 Missing ⚠️
sdks/python/src/agent_control/observability.py93.61%3 Missing ⚠️
...dks/python/src/agent_control/control_decorators.py90.00%1 Missing ⚠️
telemetry/src/agent_control_telemetry/sinks.py50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

lan17
lan17 requested changes Apr 18, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having a built-in OTEL path, but I don't think this version is safe to merge yet. Right now the SDK can tell callers observability is working while the OTEL sink is effectively inert, and the caching logic doesn't compose cleanly with the new otel_* settings. I'd also mark failed control executions as OTEL errors rather than only attaching an exception object.

Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
@namrataghadi-galileo

namrataghadi-galileo commented Apr 19, 2026

Copy link
Copy Markdown
ContributorAuthor

@lan17 Thanks, this was a good catch. I fixed the three unsafe parts you called out:

The built-in otel sink no longer counts as active when it can’t actually export. If OTEL is disabled, deps are missing, or there’s no exporter configuration, we now treat that sink as inert for observability selection instead of reporting observability as working.
The named-sink cache now keys off the effective resolved OTEL config, so changes to otel_enabled / otel_endpoint / otel_headers / otel_service_name rebuild the cached OTEL sink instead of reusing a stale one.
Failed control executions now mark the OTEL span status as ERROR in addition to recording the exception.
I also added regression tests for the inert-sink case, the OTEL settings cache invalidation case, and the error-status span behavior. Targeted SDK observability/OTEL tests are passing locally.

Base automatically changed from feature/61576-add-config-driven-sink-selection to mainApril 22, 2026 20:41
lan17
lan17 requested changes May 7, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tightening up the earlier OTEL issues. I found one remaining opt-out case that I think should be fixed before merge: an explicit observability_enabled=False can still leave the selected OTEL sink active for later writes.

Comment threadsdks/python/src/agent_control/observability.py
lan17
lan17 approved these changes May 8, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the review feedback, Namrata. I did a fresh pass from the latest head, including the opt-out path and the OTEL sink/cache behavior, and this looks good to me now.

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) May 8, 2026 15:02
@namrataghadi-galileo
namrataghadi-galileo merged commit 9530368 into mainMay 8, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/61578-add-otel-support branch May 8, 2026 15:02
@karansohikaransohi mentioned this pull request May 11, 2026
Closed
4 tasks
galileo-automation pushed a commit that referenced this pull request May 28, 2026
@semantic-release-bot
chore(release): ts sdk v2.6.0 [skip ci]
a953da5
## [2.6.0](ts-sdk-v2.5.0...ts-sdk-v2.6.0) (2026-05-28)
### Features
* **evaluators:** add new lluna client ([#213](#213)) ([f65beb9](f65beb9))
* **sdk:** add otel support ([#177](#177)) ([9530368](9530368))
* **sdk:** add runtime token auth ([#215](#215)) ([6cc0f38](6cc0f38))
* **server:** add control clone-and-bind endpoint ([#229](#229)) ([1728bf9](1728bf9))
* **server:** add runtime auth and namespace scoping ([#214](#214)) ([56e44fe](56e44fe))
* **server:** allow host-owned logging setup ([#227](#227)) ([c0fd159](c0fd159))
* **server:** bundle migrations in wheel and add agent-control-migrate ([#209](#209)) ([8c5c35e](8c5c35e))
* **server:** migrate controls routes to auth framework ([#212](#212)) ([764bd4b](764bd4b))
### Bug Fixes
* **examples:** declare local SDK workspace deps ([#222](#222)) ([d22aa1d](d22aa1d))
* **sdk:** Get trace context from provider ([#211](#211)) ([1efe30f](1efe30f))
* **sdk-ts:** normalize generated client ([#231](#231)) ([1c097d2](1c097d2))
* **server:** make observability migration retry-safe ([#226](#226)) ([b9dd00d](b9dd00d))
* **server:** prevent migration lock transactions ([#224](#224)) ([e65a2f4](e65a2f4))
* **server:** scope auth upstream CA to HTTP provider ([#232](#232)) ([7a0ce21](7a0ce21))
* **ui:** fix editing of controls in the UI ([#218](#218)) ([981e33d](981e33d)), closes [#Risk](https://github.com/agentcontrol/agent-control/issues/Risk)
@galileo-automation

galileo-automation commented May 28, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan17lan17lan17 approved these changes
@abhinav-galileoabhinav-galileoAwaiting requested review from abhinav-galileo
@savula15savula15Awaiting requested review from savula15

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namrataghadi-galileo@galileo-automation@lan17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(sdk): add otel support - #177

Merged
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support
May 8, 2026
Merged

feat(sdk): add otel support#177
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support

Conversation

@namrataghadi-galileo

@namrataghadi-galileonamrataghadi-galileo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Added configurable observability sink selection for the Python SDK and server so control events can be routed to the default backend, registered custom sinks, or named sink factories.

Added a built-in OpenTelemetry sink for the SDK, including OTLP configuration via settings/environment variables.

Updated docs and exports so custom sink registration and OTEL usage are available as public integration points.

Scope

User-facing/API changes:

  • Added observability_sink_name and observability_sink_config to SDK initialization/configuration
  • Exposed sink registration helpers and OTEL conversion utilities from the Python SDK public API
  • Added documented support for the SDK otel extra and OTEL-related environment variables
  • Added server observability sink selection/config support for named backends

Internal changes:

  • Introduced shared sink-selection models/registry helpers in telemetry/
  • Refactored SDK observability to resolve active sinks dynamically and support named/custom sinks
  • Refactored server startup/shutdown to resolve observability backends through sink selection
  • Added test coverage for sink selection, lifecycle handling, OTEL sink behavior, and re-init/policy refresh interactions

Out of scope:

  • No changes to core control evaluation semantics
  • No UI changes
  • No new non-OTEL external sink implementation included beyond registration hooks

Risk and Rollout

Risk level: medium

Rollback plan: Revert the sink-selection/OTEL changeset to restore the previous default SDK-to-server observability path only. If needed, disable custom routing by keeping observability_sink_name=default and not installing/configuring the otel extra.

Testing

  • Added or updated automated tests
  • Ran make check — typecheck was attempted but full local make check was not run because uv was unavailable in this environment
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@namrataghadi-galileo
namrataghadi-galileo changed the base branch from main to feature/61576-add-config-driven-sink-selectionApril 16, 2026 22:36
@codecov

codecovBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.20408% with 24 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/otel_sink.py89.50%19 Missing ⚠️
sdks/python/src/agent_control/observability.py93.61%3 Missing ⚠️
...dks/python/src/agent_control/control_decorators.py90.00%1 Missing ⚠️
telemetry/src/agent_control_telemetry/sinks.py50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

lan17
lan17 requested changes Apr 18, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having a built-in OTEL path, but I don't think this version is safe to merge yet. Right now the SDK can tell callers observability is working while the OTEL sink is effectively inert, and the caching logic doesn't compose cleanly with the new otel_* settings. I'd also mark failed control executions as OTEL errors rather than only attaching an exception object.

Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
@namrataghadi-galileo

namrataghadi-galileo commented Apr 19, 2026

Copy link
Copy Markdown
ContributorAuthor

@lan17 Thanks, this was a good catch. I fixed the three unsafe parts you called out:

The built-in otel sink no longer counts as active when it can’t actually export. If OTEL is disabled, deps are missing, or there’s no exporter configuration, we now treat that sink as inert for observability selection instead of reporting observability as working.
The named-sink cache now keys off the effective resolved OTEL config, so changes to otel_enabled / otel_endpoint / otel_headers / otel_service_name rebuild the cached OTEL sink instead of reusing a stale one.
Failed control executions now mark the OTEL span status as ERROR in addition to recording the exception.
I also added regression tests for the inert-sink case, the OTEL settings cache invalidation case, and the error-status span behavior. Targeted SDK observability/OTEL tests are passing locally.

Base automatically changed from feature/61576-add-config-driven-sink-selection to mainApril 22, 2026 20:41
lan17
lan17 requested changes May 7, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tightening up the earlier OTEL issues. I found one remaining opt-out case that I think should be fixed before merge: an explicit observability_enabled=False can still leave the selected OTEL sink active for later writes.

Comment threadsdks/python/src/agent_control/observability.py
lan17
lan17 approved these changes May 8, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the review feedback, Namrata. I did a fresh pass from the latest head, including the opt-out path and the OTEL sink/cache behavior, and this looks good to me now.

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) May 8, 2026 15:02
@namrataghadi-galileo
namrataghadi-galileo merged commit 9530368 into mainMay 8, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/61578-add-otel-support branch May 8, 2026 15:02
@karansohikaransohi mentioned this pull request May 11, 2026
Closed
4 tasks
galileo-automation pushed a commit that referenced this pull request May 28, 2026
@semantic-release-bot
chore(release): ts sdk v2.6.0 [skip ci]
a953da5
## [2.6.0](ts-sdk-v2.5.0...ts-sdk-v2.6.0) (2026-05-28)
### Features
* **evaluators:** add new lluna client ([#213](#213)) ([f65beb9](f65beb9))
* **sdk:** add otel support ([#177](#177)) ([9530368](9530368))
* **sdk:** add runtime token auth ([#215](#215)) ([6cc0f38](6cc0f38))
* **server:** add control clone-and-bind endpoint ([#229](#229)) ([1728bf9](1728bf9))
* **server:** add runtime auth and namespace scoping ([#214](#214)) ([56e44fe](56e44fe))
* **server:** allow host-owned logging setup ([#227](#227)) ([c0fd159](c0fd159))
* **server:** bundle migrations in wheel and add agent-control-migrate ([#209](#209)) ([8c5c35e](8c5c35e))
* **server:** migrate controls routes to auth framework ([#212](#212)) ([764bd4b](764bd4b))
### Bug Fixes
* **examples:** declare local SDK workspace deps ([#222](#222)) ([d22aa1d](d22aa1d))
* **sdk:** Get trace context from provider ([#211](#211)) ([1efe30f](1efe30f))
* **sdk-ts:** normalize generated client ([#231](#231)) ([1c097d2](1c097d2))
* **server:** make observability migration retry-safe ([#226](#226)) ([b9dd00d](b9dd00d))
* **server:** prevent migration lock transactions ([#224](#224)) ([e65a2f4](e65a2f4))
* **server:** scope auth upstream CA to HTTP provider ([#232](#232)) ([7a0ce21](7a0ce21))
* **ui:** fix editing of controls in the UI ([#218](#218)) ([981e33d](981e33d)), closes [#Risk](https://github.com/agentcontrol/agent-control/issues/Risk)
@galileo-automation

galileo-automation commented May 28, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan17lan17lan17 approved these changes
@abhinav-galileoabhinav-galileoAwaiting requested review from abhinav-galileo
@savula15savula15Awaiting requested review from savula15

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namrataghadi-galileo@galileo-automation@lan17
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(sdk): add otel support - #177

Merged
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support
May 8, 2026
Merged

feat(sdk): add otel support#177
namrataghadi-galileo merged 30 commits into
mainfrom
feature/61578-add-otel-support

Conversation

@namrataghadi-galileo

@namrataghadi-galileonamrataghadi-galileo commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Added configurable observability sink selection for the Python SDK and server so control events can be routed to the default backend, registered custom sinks, or named sink factories.

Added a built-in OpenTelemetry sink for the SDK, including OTLP configuration via settings/environment variables.

Updated docs and exports so custom sink registration and OTEL usage are available as public integration points.

Scope

User-facing/API changes:

  • Added observability_sink_name and observability_sink_config to SDK initialization/configuration
  • Exposed sink registration helpers and OTEL conversion utilities from the Python SDK public API
  • Added documented support for the SDK otel extra and OTEL-related environment variables
  • Added server observability sink selection/config support for named backends

Internal changes:

  • Introduced shared sink-selection models/registry helpers in telemetry/
  • Refactored SDK observability to resolve active sinks dynamically and support named/custom sinks
  • Refactored server startup/shutdown to resolve observability backends through sink selection
  • Added test coverage for sink selection, lifecycle handling, OTEL sink behavior, and re-init/policy refresh interactions

Out of scope:

  • No changes to core control evaluation semantics
  • No UI changes
  • No new non-OTEL external sink implementation included beyond registration hooks

Risk and Rollout

Risk level: medium

Rollback plan: Revert the sink-selection/OTEL changeset to restore the previous default SDK-to-server observability path only. If needed, disable custom routing by keeping observability_sink_name=default and not installing/configuring the otel extra.

Testing

  • Added or updated automated tests
  • Ran make check — typecheck was attempted but full local make check was not run because uv was unavailable in this environment
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@namrataghadi-galileo
namrataghadi-galileo changed the base branch from main to feature/61576-add-config-driven-sink-selectionApril 16, 2026 22:36
@codecov

codecovBot commented Apr 16, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.20408% with 24 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
sdks/python/src/agent_control/otel_sink.py89.50%19 Missing ⚠️
sdks/python/src/agent_control/observability.py93.61%3 Missing ⚠️
...dks/python/src/agent_control/control_decorators.py90.00%1 Missing ⚠️
telemetry/src/agent_control_telemetry/sinks.py50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

lan17
lan17 requested changes Apr 18, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having a built-in OTEL path, but I don't think this version is safe to merge yet. Right now the SDK can tell callers observability is working while the OTEL sink is effectively inert, and the caching logic doesn't compose cleanly with the new otel_* settings. I'd also mark failed control executions as OTEL errors rather than only attaching an exception object.

Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
Comment threadsdks/python/src/agent_control/otel_sink.py
@namrataghadi-galileo

namrataghadi-galileo commented Apr 19, 2026

Copy link
Copy Markdown
ContributorAuthor

@lan17 Thanks, this was a good catch. I fixed the three unsafe parts you called out:

The built-in otel sink no longer counts as active when it can’t actually export. If OTEL is disabled, deps are missing, or there’s no exporter configuration, we now treat that sink as inert for observability selection instead of reporting observability as working.
The named-sink cache now keys off the effective resolved OTEL config, so changes to otel_enabled / otel_endpoint / otel_headers / otel_service_name rebuild the cached OTEL sink instead of reusing a stale one.
Failed control executions now mark the OTEL span status as ERROR in addition to recording the exception.
I also added regression tests for the inert-sink case, the OTEL settings cache invalidation case, and the error-status span behavior. Targeted SDK observability/OTEL tests are passing locally.

Base automatically changed from feature/61576-add-config-driven-sink-selection to mainApril 22, 2026 20:41
lan17
lan17 requested changes May 7, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on tightening up the earlier OTEL issues. I found one remaining opt-out case that I think should be fixed before merge: an explicit observability_enabled=False can still leave the selected OTEL sink active for later writes.

Comment threadsdks/python/src/agent_control/observability.py
lan17
lan17 approved these changes May 8, 2026
View reviewed changes

@lan17lan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the review feedback, Namrata. I did a fresh pass from the latest head, including the opt-out path and the OTEL sink/cache behavior, and this looks good to me now.

@namrataghadi-galileo
namrataghadi-galileo enabled auto-merge (squash) May 8, 2026 15:02
@namrataghadi-galileo
namrataghadi-galileo merged commit 9530368 into mainMay 8, 2026
6 checks passed
@namrataghadi-galileo
namrataghadi-galileo deleted the feature/61578-add-otel-support branch May 8, 2026 15:02
@karansohikaransohi mentioned this pull request May 11, 2026
Closed
4 tasks
galileo-automation pushed a commit that referenced this pull request May 28, 2026
@semantic-release-bot
chore(release): ts sdk v2.6.0 [skip ci]
a953da5
## [2.6.0](ts-sdk-v2.5.0...ts-sdk-v2.6.0) (2026-05-28)
### Features
* **evaluators:** add new lluna client ([#213](#213)) ([f65beb9](f65beb9))
* **sdk:** add otel support ([#177](#177)) ([9530368](9530368))
* **sdk:** add runtime token auth ([#215](#215)) ([6cc0f38](6cc0f38))
* **server:** add control clone-and-bind endpoint ([#229](#229)) ([1728bf9](1728bf9))
* **server:** add runtime auth and namespace scoping ([#214](#214)) ([56e44fe](56e44fe))
* **server:** allow host-owned logging setup ([#227](#227)) ([c0fd159](c0fd159))
* **server:** bundle migrations in wheel and add agent-control-migrate ([#209](#209)) ([8c5c35e](8c5c35e))
* **server:** migrate controls routes to auth framework ([#212](#212)) ([764bd4b](764bd4b))
### Bug Fixes
* **examples:** declare local SDK workspace deps ([#222](#222)) ([d22aa1d](d22aa1d))
* **sdk:** Get trace context from provider ([#211](#211)) ([1efe30f](1efe30f))
* **sdk-ts:** normalize generated client ([#231](#231)) ([1c097d2](1c097d2))
* **server:** make observability migration retry-safe ([#226](#226)) ([b9dd00d](b9dd00d))
* **server:** prevent migration lock transactions ([#224](#224)) ([e65a2f4](e65a2f4))
* **server:** scope auth upstream CA to HTTP provider ([#232](#232)) ([7a0ce21](7a0ce21))
* **ui:** fix editing of controls in the UI ([#218](#218)) ([981e33d](981e33d)), closes [#Risk](https://github.com/agentcontrol/agent-control/issues/Risk)
@galileo-automation

galileo-automation commented May 28, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lan17lan17lan17 approved these changes
@abhinav-galileoabhinav-galileoAwaiting requested review from abhinav-galileo
@savula15savula15Awaiting requested review from savula15

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namrataghadi-galileo@galileo-automation@lan17