docker: reduce unnecessary server image tooling - #661
Open
jjj-n wants to merge 1 commit into
Open
Conversation
Signed-off-by: jjj-n <1357598741@qq.com>
Author
|
Hi maintainers, just following up on this server image cleanup for #659. The PR includes Docker Compose validation and uses a TCP health check in place of curl. Is this approach acceptable, or would you prefer any changes before review? Thanks! |
timflannagan
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary tooling from the server image:
makein the Go builder, which invokesgo builddirectly;curlin the runtime image;/dev/tcp, matching the Helm chart probes.Alternative implementation to #660. This version preserves the existing line endings, invokes Bash explicitly for
/dev/tcp, and has been validated end to end with Docker Compose.Fixes #659
Change Type
/kind cleanup
Changelog
Additional Notes
Validated by:
gitandbashremain available whilecurlandmakeare absent from the runtime;/v0/pingreturns{"pong":true};