Uh oh!
There was an error while loading. Please reload this page.
Skill build system - #347
Merged
Merged
Conversation
- Introduce `skill-src/` as the authored source tree with generated `skills/` output - Add Make targets and CI checks to build, verify sync, and prevent discoverable source skills - Document the skill authoring workflow and staged source conventions
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. This review is advisory and does not block merging. |
Uh oh!
There was an error while loading. Please reload this page.
ankitranjan7 added a commit
that referenced
this pull request
Aug 18, 2026
#347 moved published skills to skill-src/*.src.md sources built by litprompt. The rewrite and SKILL.md pointer must live in the sources so 'make verify' passes; the published .md files are regenerated from them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ankitranjan7 added a commit
that referenced
this pull request
Aug 18, 2026
* docs(skills): describe the browser run sandbox as QuickJS The reference called `page`, `context`, `browser`, and `console` "normal Playwright globals" and never used the word QuickJS. That reads as a Node-hosted Playwright script, which is the belief that produces `'Buffer' is not defined` and `'document' is not defined`. Rewrites the reference around the actual model — your code runs in QuickJS, not in the page and not in Node — and replaces "use the vendored Playwright client as the API reference" with tables of what is available and what is blocked, each naming the supported alternative. Also corrects two stale claims, both verified against the transport: - `context.newPage()` is supported; playwright-transport.ts routes `newPage` to `scope.createPage`. The doc said it was unavailable. - `page.$`/`page.$$` are supported; DENIED_METHODS blocks only Browser.*, BrowserContext.close/newCDPSession, Page.close, and Playwright.newRequest. The SKILL.md pointer now states the surprise instead of listing chapters, because a table of contents is skippable and a warning is not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(skills): assert the rewritten QuickJS reference structure The skills content guard pinned the old "Sandbox boundaries" and "Artifact paths" headings, which this branch renamed. Assert the concepts the doc now teaches instead — the QuickJS runtime, the page.evaluate boundary, and artifacts — which is a stronger check than the old heading match. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(skills): move the QuickJS rewrite into the litprompt source tree #347 moved published skills to skill-src/*.src.md sources built by litprompt. The rewrite and SKILL.md pointer must live in the sources so 'make verify' passes; the published .md files are regenerated from them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Agnik47 added a commit
to Agnik47/webcmd
that referenced
this pull request
Aug 18, 2026
The skill pipeline added in agentrhq#347 builds skills/ from skill-src/, and `make verify` rebuilds and compares hashes. My previous commit edited the published skills/webcmd-usage/SKILL.md directly, so a fresh build regenerated it from the untouched source and the hashes diverged. Same text, applied to skill-src/webcmd-usage/SKILL.src.md. The published file already carries it, and the only source-to-published transformation in this file is the trailing author-only <!-- @ --> block litprompt strips, so the two are back in sync.
Agnik47 added a commit
to Agnik47/webcmd
that referenced
this pull request
Aug 18, 2026
The skill pipeline from agentrhq#347 builds skills/ from skill-src/ and `make verify` rebuilds to compare hashes. The report-and-status paragraph was applied to the published skills/webcmd-usage/SKILL.md only, so a fresh build regenerated it from the untouched source and the hashes diverged. Same text, now in skill-src/webcmd-usage/SKILL.src.md. The webcmd-browser skill in this branch already had both halves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.