Feat/npm plugin versions and tests by sreeramakhil · Pull Request #433 · agentrhq/webcmd

sreeramakhil · 2026-08-24T13:04:46Z

Description

Addresses all review feedback on the npm plugin changes and introduces a new premium out-of-the-box feature: Universal Package Search.

1. Refined `npm versions` command:

Consistent Signatures: Dropped the request parameter from npmFetch and versionsNpm in favor of using withFetch globally in tests (matching the other commands).
Prerelease Filtering: Pre-releases and custom build tags are filtered out by default. Added a --prereleases boolean flag (default false) to include them when requested.
Upgraded Tests: Test coverage updated to cover prerelease filtering and new global fetch mocking strategy.

2. Universal Package Search (`omnisearch packages`):

Ecosystems: Searches npm, crates.io (Rust), NuGet (.NET), RubyGems (Ruby), Packagist (PHP), and Maven Central (Java) in parallel.
Robustness: Utilizes Promise.allSettled to isolate failures. If one registry rate-limits or fails, others still return results.
Filters: Added support for --limit and --registries filters.
Schema: Normalizes to a unified row format: registry, name, version, description, url.
Tests: Full suite implemented in plugins/omnisearch/test/packages.test.js.

Related issue: None

Type of Change

Checklist

I ran the checks relevant to this PR
I updated tests or docs if needed
I included output or screenshots when useful
If I edited skill-src/, I ran make build and committed skills/

Adapter Notes

Updated generated or lean docs when command discoverability changed
Used positional args for the command's primary subject unless a named flag is clearly better
Normalized expected adapter failures to CliError subclasses instead of raw Error

Screenshots / Output

$ npx vitest run plugins/npm/test/npm.test.js
✓ plugin plugins/npm/test/npm.test.js (16 tests) 20ms
Test Files 1 passed (1)
Tests 16 passed (16)
$ npx vitest run plugins/omnisearch/test/
✓ plugin plugins/omnisearch/test/research.test.js (1 test) 32ms
✓ plugin plugins/omnisearch/test/packages.test.js (5 tests) 42ms
Test Files 2 passed (2)
Tests 6 passed (6)

- Add webcmd npm versions <name> command that lists all published versions of a package newest-first, with publishedAt, isLatest flag, and a direct npmjs.com URL per version. Mirrors the pypi releases cmd. - Add optional equest parameter to pmFetch in utils.js so commands can inject a fake fetch function in tests without patching globals (matches the pattern used in the pypi plugin). - Add test/npm.test.js with 14 tests covering all four commands: package, versions, downloads, search. Includes happy paths, empty result / 404 handling, input validation, and a contract test asserting browser: false for every registered command. - Expand README.md with a full command table (including the new versions command), argument descriptions, and copy-paste examples for all four commands.

Slicing publishedAt to 10 chars before sorting caused versions published on the same calendar date to lose sub-day precision, producing non-deterministic newest-first ordering. Fix: sort on the raw full timestamp first, then format to date-only inside .map(). Add a regression test with two versions sharing the same date (08:00 and 14:00) to pin the correct ordering.

… entries A version key can exist in body.time without a matching entry in body.versions (e.g. yanked or unpublished releases). The previous code returned bogus rows for those keys with an invalid URL and misleading date. Fix: cross-filter timeMap entries against body.versions so only keys that exist in both are returned. Also guard that the timestamp is a string before sorting. Update the same-day regression fixture to include matching body.versions entries and add a time-only ghost key (0.0.1-ghost) to assert it is excluded from results.

…tests feat(npm): add versions command, test suite, and expanded README

Reddit is one of the most valuable developer discussion platforms (r/programming, r/webdev, r/javascript, r/rust, r/python, etc.) but was missing from the omnisearch aggregator entirely. - Add redditSearch() to sources.js using the free public JSON search API (reddit.com/search.json, no auth or key required). Returns normalized rows: platform/title/author/score/commentCount/createdAt/ url/text — matching the shared schema used by all other sources. Falls back to permalink when the url field is absent (self posts). - Wire redditSearch into research.js: added to the fetchers map and included in the default sources string so every agent using webcmd omnisearch research gets Reddit results automatically. - Wire redditSearch into verdict.js so community sentiment analysis now includes Reddit engagement alongside HN, SO, GitHub, arXiv, Dev.to, and Lobsters. - Expand test/research.test.js from 1 test to 8 tests: - redditSearch: normalized rows, permalink fallback, empty results, correct endpoint URL - research command: Reddit rows returned, default sources includes reddit, Reddit failure isolated via Promise.allSettled - Original HN limit regression test preserved

A non-numeric or out-of-range created_utc value would cause new Date(...).toISOString() to throw, rejecting the entire Reddit result set for that query. Fix: construct the Date object first, then check Number.isNaN on getTime() before calling toISOString() — returning empty string for malformed timestamps so one bad post never kills the whole fetch. Add regression test: a post with created_utc='not-a-number' must produce createdAt='' without throwing.

…tion child?.data ?? {} silently converted null entries and entries missing a data object into fake normalized rows, which downstream research could count or render as real Reddit results. Fix: filter children to only those where child.data is a non-null object before slice/map. Add regression test: a mix of null, no-data, and null-data children alongside one valid entry — only the valid entry must appear in results.

typeof [] === 'object' is true in JavaScript, so {data:[]} passed the previous filter and mapped to a fake row that could displace a valid result when limit was applied after slicing. Fix: add !Array.isArray(child.data) to the filter so only plain objects are accepted as valid post data. Add regression test: one array-data entry + one valid entry with limit=1 asserts the valid result is returned, not the array-shaped fake.

…imeout Without a timeout, a slow or stalled Reddit connection could keep the fetch pending indefinitely, blocking the entire research aggregation. Fix: pass AbortSignal.timeout(10_000) in the get() init options so the request is automatically aborted after 10 seconds. The existing headers and response handling are preserved.

feat(omnisearch): add Reddit as a 7th research source

- Drop the equest parameter from pmFetch and �ersionsNpm. Instead, use withFetch in tests to stub the global etch. - Filter out pre-release and build versions by default. Add a --prereleases boolean flag (default alse) to allow including them when requested. - Update and expand tests in est/npm.test.js to cover the new pre-release filtering behavior and verify that the --prereleases flag works correctly.

…ages) - Create plugins/omnisearch/packages.js to query npm, crates.io, NuGet, RubyGems, Packagist, and Maven Central in parallel using Promise.allSettled for failure isolation. - Add support for --limit and --registries options to customize the search. - Normalize search results to a unified schema: registry, name, version, description, and url. - Create plugins/omnisearch/test/packages.test.js to cover all happy paths, filtering, limits, failure isolation, and browserless compliance. - Re-compile the plugin command manifest to register the new command.

github-actions · 2026-08-24T13:05:16Z

🟠 Maintainer review suggested — low confidence

The automated review could not reach a fully supported conclusion.

This review is advisory and does not block merging.

…-versions-and-tests

…ons-and-tests

…ation order

sreeramakhil · 2026-08-24T13:04:46Z