docs: fiducial markers guide

[MithraGhlm]

Description

Initial draft of documentation for camera frame calibration guide.
This PR closes the camera frame calibration guide #479

This PR solves the issue by adding two stand-alone guides to the documentation.
The guide for intrinsic camera calibration already exists.
One guide is about the configuration and the process of recognizing STag marker (WIP) and a second one would be dedicated to calibrating the robot.

Review guidelines

Estimated Time of Review: 10 minutes

Feedback Needed

• Structure okay?
• Level of detail appropriate?

[SprGrf]

Thanks! First quick review:

[MithraGhlm]

@SprGrf Thanks

[MithraGhlm]

Should there be a stand alone guide to introduce the Robot Camera Calibration component?
Or is it better to have it in the same docs page?

[SprGrf]

Nice! The backbone is here, some first comments I had while reading:

[MithraGhlm]

In order to proceed here, please

2. Remove the hand-eye-calibration guide from this PR. We'll make a separate PR for it.

Before I change anything there, do you want the existing review comments be preserved or is it acceptable to move it to a new branch and create a fresh PR?

This is what I want to do: (Since the name of this PR is already HE calibration, I'll move the Fiducial Markers to a new PR)

1. Make a new branch for Fiducial Markers
2. Delete the fiducial-markers.md file and all media related to it

So the existing PR would be only for HE calibration.

Then I'll open a new PR for the Fiducial Markers and rebase on main.

Is this workflow accepted?

[MithraGhlm]

Unless we have actual guidelines how we want to improve style and formatting, there is no need increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

I'm not against the changes alltogether, but this is not the place to do it. A reformatting PR would be more appropriate

As you correctly commented once on the #485 (This PR contains all commits from #482, could you untangle this?), I untangled #482 from #485.
The initial problem was due to me forgetting to switch to main before making the new branch. But then I rebased it on the main and the problem was resolved. Now #482 and #485 are 2 different PRs.

So I don't understand what you mean by: increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

Since we don't have any specific guidelines yet, how about just merging the small changes and closing #485, instead of reverting it?

[domire8]

All 4 of my previous review comments are still unresolved

[domire8]

Just two last formatting nitpicks. Otherwise all good!

[domire8]

Alright looks good now! Good work with this 👍

[SprGrf]

Nice work, sorry it took me so long to return to this!

[MithraGhlm]

Nice work, sorry it took me so long to return to this!

No worries :) It's nice you're back.

[domire8]

Suggested change

[domire8]

Yes very nice 👍

[MithraGhlm]

Description

Initial draft of documentation for camera frame calibration guide.
This PR closes the camera frame calibration guide #479

This PR solves the issue by adding two stand-alone guides to the documentation.
The guide for intrinsic camera calibration already exists.
One guide is about the configuration and the process of recognizing STag marker (WIP) and a second one would be dedicated to calibrating the robot.

Review guidelines

Estimated Time of Review: 10 minutes

Feedback Needed

• Structure okay?
• Level of detail appropriate?

[SprGrf]

Thanks! First quick review:

[MithraGhlm]

@SprGrf Thanks

[MithraGhlm]

Should there be a stand alone guide to introduce the Robot Camera Calibration component?
Or is it better to have it in the same docs page?

[SprGrf]

Nice! The backbone is here, some first comments I had while reading:

[MithraGhlm]

In order to proceed here, please

2. Remove the hand-eye-calibration guide from this PR. We'll make a separate PR for it.

Before I change anything there, do you want the existing review comments be preserved or is it acceptable to move it to a new branch and create a fresh PR?

This is what I want to do: (Since the name of this PR is already HE calibration, I'll move the Fiducial Markers to a new PR)

1. Make a new branch for Fiducial Markers
2. Delete the fiducial-markers.md file and all media related to it

So the existing PR would be only for HE calibration.

Then I'll open a new PR for the Fiducial Markers and rebase on main.

Is this workflow accepted?

[MithraGhlm]

Unless we have actual guidelines how we want to improve style and formatting, there is no need increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

I'm not against the changes alltogether, but this is not the place to do it. A reformatting PR would be more appropriate

As you correctly commented once on the #485 (This PR contains all commits from #482, could you untangle this?), I untangled #482 from #485.
The initial problem was due to me forgetting to switch to main before making the new branch. But then I rebased it on the main and the problem was resolved. Now #482 and #485 are 2 different PRs.

So I don't understand what you mean by: increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

Since we don't have any specific guidelines yet, how about just merging the small changes and closing #485, instead of reverting it?

[domire8]

All 4 of my previous review comments are still unresolved

[domire8]

Just two last formatting nitpicks. Otherwise all good!

[domire8]

Alright looks good now! Good work with this 👍

[SprGrf]

Nice work, sorry it took me so long to return to this!

[MithraGhlm]

Nice work, sorry it took me so long to return to this!

No worries :) It's nice you're back.

[domire8]

Suggested change

[domire8]

Yes very nice 👍

[MithraGhlm]

Description

Initial draft of documentation for camera frame calibration guide.
This PR closes the camera frame calibration guide #479

This PR solves the issue by adding two stand-alone guides to the documentation.
The guide for intrinsic camera calibration already exists.
One guide is about the configuration and the process of recognizing STag marker (WIP) and a second one would be dedicated to calibrating the robot.

Review guidelines

Estimated Time of Review: 10 minutes

Feedback Needed

• Structure okay?
• Level of detail appropriate?

[SprGrf]

Thanks! First quick review:

[MithraGhlm]

@SprGrf Thanks

[MithraGhlm]

Should there be a stand alone guide to introduce the Robot Camera Calibration component?
Or is it better to have it in the same docs page?

[SprGrf]

Nice! The backbone is here, some first comments I had while reading:

[MithraGhlm]

In order to proceed here, please

2. Remove the hand-eye-calibration guide from this PR. We'll make a separate PR for it.

Before I change anything there, do you want the existing review comments be preserved or is it acceptable to move it to a new branch and create a fresh PR?

This is what I want to do: (Since the name of this PR is already HE calibration, I'll move the Fiducial Markers to a new PR)

1. Make a new branch for Fiducial Markers
2. Delete the fiducial-markers.md file and all media related to it

So the existing PR would be only for HE calibration.

Then I'll open a new PR for the Fiducial Markers and rebase on main.

Is this workflow accepted?

[MithraGhlm]

Unless we have actual guidelines how we want to improve style and formatting, there is no need increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

I'm not against the changes alltogether, but this is not the place to do it. A reformatting PR would be more appropriate

As you correctly commented once on the #485 (This PR contains all commits from #482, could you untangle this?), I untangled #482 from #485.
The initial problem was due to me forgetting to switch to main before making the new branch. But then I rebased it on the main and the problem was resolved. Now #482 and #485 are 2 different PRs.

So I don't understand what you mean by: increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

Since we don't have any specific guidelines yet, how about just merging the small changes and closing #485, instead of reverting it?

[domire8]

All 4 of my previous review comments are still unresolved

[domire8]

Just two last formatting nitpicks. Otherwise all good!

[domire8]

Alright looks good now! Good work with this 👍

[SprGrf]

Nice work, sorry it took me so long to return to this!

[MithraGhlm]

Nice work, sorry it took me so long to return to this!

No worries :) It's nice you're back.

[domire8]

Suggested change

[domire8]

Yes very nice 👍

[MithraGhlm]

Description

Initial draft of documentation for camera frame calibration guide.
This PR closes the camera frame calibration guide #479

This PR solves the issue by adding two stand-alone guides to the documentation.
The guide for intrinsic camera calibration already exists.
One guide is about the configuration and the process of recognizing STag marker (WIP) and a second one would be dedicated to calibrating the robot.

Review guidelines

Estimated Time of Review: 10 minutes

Feedback Needed

• Structure okay?
• Level of detail appropriate?

[SprGrf]

Thanks! First quick review:

[MithraGhlm]

@SprGrf Thanks

[MithraGhlm]

Should there be a stand alone guide to introduce the Robot Camera Calibration component?
Or is it better to have it in the same docs page?

[SprGrf]

Nice! The backbone is here, some first comments I had while reading:

[MithraGhlm]

In order to proceed here, please

2. Remove the hand-eye-calibration guide from this PR. We'll make a separate PR for it.

Before I change anything there, do you want the existing review comments be preserved or is it acceptable to move it to a new branch and create a fresh PR?

This is what I want to do: (Since the name of this PR is already HE calibration, I'll move the Fiducial Markers to a new PR)

1. Make a new branch for Fiducial Markers
2. Delete the fiducial-markers.md file and all media related to it

So the existing PR would be only for HE calibration.

Then I'll open a new PR for the Fiducial Markers and rebase on main.

Is this workflow accepted?

[MithraGhlm]

Unless we have actual guidelines how we want to improve style and formatting, there is no need increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

I'm not against the changes alltogether, but this is not the place to do it. A reformatting PR would be more appropriate

As you correctly commented once on the #485 (This PR contains all commits from #482, could you untangle this?), I untangled #482 from #485.
The initial problem was due to me forgetting to switch to main before making the new branch. But then I rebased it on the main and the problem was resolved. Now #482 and #485 are 2 different PRs.

So I don't understand what you mean by: increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

Since we don't have any specific guidelines yet, how about just merging the small changes and closing #485, instead of reverting it?

[domire8]

All 4 of my previous review comments are still unresolved

[domire8]

Just two last formatting nitpicks. Otherwise all good!

[domire8]

Alright looks good now! Good work with this 👍

[SprGrf]

Nice work, sorry it took me so long to return to this!

[MithraGhlm]

Nice work, sorry it took me so long to return to this!

No worries :) It's nice you're back.

[domire8]

Suggested change

[domire8]

Yes very nice 👍

[MithraGhlm]

Description

Initial draft of documentation for camera frame calibration guide.
This PR closes the camera frame calibration guide #479

This PR solves the issue by adding two stand-alone guides to the documentation.
The guide for intrinsic camera calibration already exists.
One guide is about the configuration and the process of recognizing STag marker (WIP) and a second one would be dedicated to calibrating the robot.

Review guidelines

Estimated Time of Review: 10 minutes

Feedback Needed

• Structure okay?
• Level of detail appropriate?

[SprGrf]

Thanks! First quick review:

[MithraGhlm]

@SprGrf Thanks

[MithraGhlm]

Should there be a stand alone guide to introduce the Robot Camera Calibration component?
Or is it better to have it in the same docs page?

[SprGrf]

Nice! The backbone is here, some first comments I had while reading:

[MithraGhlm]

In order to proceed here, please

2. Remove the hand-eye-calibration guide from this PR. We'll make a separate PR for it.

Before I change anything there, do you want the existing review comments be preserved or is it acceptable to move it to a new branch and create a fresh PR?

This is what I want to do: (Since the name of this PR is already HE calibration, I'll move the Fiducial Markers to a new PR)

1. Make a new branch for Fiducial Markers
2. Delete the fiducial-markers.md file and all media related to it

So the existing PR would be only for HE calibration.

Then I'll open a new PR for the Fiducial Markers and rebase on main.

Is this workflow accepted?

[MithraGhlm]

Unless we have actual guidelines how we want to improve style and formatting, there is no need increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

I'm not against the changes alltogether, but this is not the place to do it. A reformatting PR would be more appropriate

As you correctly commented once on the #485 (This PR contains all commits from #482, could you untangle this?), I untangled #482 from #485.
The initial problem was due to me forgetting to switch to main before making the new branch. But then I rebased it on the main and the problem was resolved. Now #482 and #485 are 2 different PRs.

So I don't understand what you mean by: increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

Since we don't have any specific guidelines yet, how about just merging the small changes and closing #485, instead of reverting it?

[domire8]

All 4 of my previous review comments are still unresolved

[domire8]

Just two last formatting nitpicks. Otherwise all good!

[domire8]

Alright looks good now! Good work with this 👍

[SprGrf]

Nice work, sorry it took me so long to return to this!

[MithraGhlm]

Nice work, sorry it took me so long to return to this!

No worries :) It's nice you're back.

[domire8]

Suggested change

[domire8]

Yes very nice 👍

[MithraGhlm]

Description

Initial draft of documentation for camera frame calibration guide.
This PR closes the camera frame calibration guide #479

This PR solves the issue by adding two stand-alone guides to the documentation.
The guide for intrinsic camera calibration already exists.
One guide is about the configuration and the process of recognizing STag marker (WIP) and a second one would be dedicated to calibrating the robot.

Review guidelines

Estimated Time of Review: 10 minutes

Feedback Needed

• Structure okay?
• Level of detail appropriate?

[SprGrf]

Thanks! First quick review:

[MithraGhlm]

@SprGrf Thanks

[MithraGhlm]

Should there be a stand alone guide to introduce the Robot Camera Calibration component?
Or is it better to have it in the same docs page?

[SprGrf]

Nice! The backbone is here, some first comments I had while reading:

[MithraGhlm]

In order to proceed here, please

2. Remove the hand-eye-calibration guide from this PR. We'll make a separate PR for it.

Before I change anything there, do you want the existing review comments be preserved or is it acceptable to move it to a new branch and create a fresh PR?

This is what I want to do: (Since the name of this PR is already HE calibration, I'll move the Fiducial Markers to a new PR)

1. Make a new branch for Fiducial Markers
2. Delete the fiducial-markers.md file and all media related to it

So the existing PR would be only for HE calibration.

Then I'll open a new PR for the Fiducial Markers and rebase on main.

Is this workflow accepted?

[MithraGhlm]

Unless we have actual guidelines how we want to improve style and formatting, there is no need increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

I'm not against the changes alltogether, but this is not the place to do it. A reformatting PR would be more appropriate

As you correctly commented once on the #485 (This PR contains all commits from #482, could you untangle this?), I untangled #482 from #485.
The initial problem was due to me forgetting to switch to main before making the new branch. But then I rebased it on the main and the problem was resolved. Now #482 and #485 are 2 different PRs.

So I don't understand what you mean by: increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

Since we don't have any specific guidelines yet, how about just merging the small changes and closing #485, instead of reverting it?

[domire8]

All 4 of my previous review comments are still unresolved

[domire8]

Just two last formatting nitpicks. Otherwise all good!

[domire8]

Alright looks good now! Good work with this 👍

[SprGrf]

Nice work, sorry it took me so long to return to this!

[MithraGhlm]

Nice work, sorry it took me so long to return to this!

No worries :) It's nice you're back.

[domire8]

Suggested change

[domire8]

Yes very nice 👍

[MithraGhlm]

Description

Initial draft of documentation for camera frame calibration guide.
This PR closes the camera frame calibration guide #479

This PR solves the issue by adding two stand-alone guides to the documentation.
The guide for intrinsic camera calibration already exists.
One guide is about the configuration and the process of recognizing STag marker (WIP) and a second one would be dedicated to calibrating the robot.

Review guidelines

Estimated Time of Review: 10 minutes

Feedback Needed

• Structure okay?
• Level of detail appropriate?

[SprGrf]

Thanks! First quick review:

[MithraGhlm]

@SprGrf Thanks

[MithraGhlm]

Should there be a stand alone guide to introduce the Robot Camera Calibration component?
Or is it better to have it in the same docs page?

[SprGrf]

Nice! The backbone is here, some first comments I had while reading:

[MithraGhlm]

In order to proceed here, please

2. Remove the hand-eye-calibration guide from this PR. We'll make a separate PR for it.

Before I change anything there, do you want the existing review comments be preserved or is it acceptable to move it to a new branch and create a fresh PR?

This is what I want to do: (Since the name of this PR is already HE calibration, I'll move the Fiducial Markers to a new PR)

1. Make a new branch for Fiducial Markers
2. Delete the fiducial-markers.md file and all media related to it

So the existing PR would be only for HE calibration.

Then I'll open a new PR for the Fiducial Markers and rebase on main.

Is this workflow accepted?

[MithraGhlm]

Unless we have actual guidelines how we want to improve style and formatting, there is no need increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

I'm not against the changes alltogether, but this is not the place to do it. A reformatting PR would be more appropriate

As you correctly commented once on the #485 (This PR contains all commits from #482, could you untangle this?), I untangled #482 from #485.
The initial problem was due to me forgetting to switch to main before making the new branch. But then I rebased it on the main and the problem was resolved. Now #482 and #485 are 2 different PRs.

So I don't understand what you mean by: increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

Since we don't have any specific guidelines yet, how about just merging the small changes and closing #485, instead of reverting it?

[domire8]

All 4 of my previous review comments are still unresolved

[domire8]

Just two last formatting nitpicks. Otherwise all good!

[domire8]

Alright looks good now! Good work with this 👍

[SprGrf]

Nice work, sorry it took me so long to return to this!

[MithraGhlm]

Nice work, sorry it took me so long to return to this!

No worries :) It's nice you're back.

[domire8]

Suggested change

[domire8]

Yes very nice 👍

[MithraGhlm]

Description

Initial draft of documentation for camera frame calibration guide.
This PR closes the camera frame calibration guide #479

This PR solves the issue by adding two stand-alone guides to the documentation.
The guide for intrinsic camera calibration already exists.
One guide is about the configuration and the process of recognizing STag marker (WIP) and a second one would be dedicated to calibrating the robot.

Review guidelines

Estimated Time of Review: 10 minutes

Feedback Needed

• Structure okay?
• Level of detail appropriate?

[SprGrf]

Thanks! First quick review:

[MithraGhlm]

@SprGrf Thanks

[MithraGhlm]

Should there be a stand alone guide to introduce the Robot Camera Calibration component?
Or is it better to have it in the same docs page?

[SprGrf]

Nice! The backbone is here, some first comments I had while reading:

[MithraGhlm]

In order to proceed here, please

2. Remove the hand-eye-calibration guide from this PR. We'll make a separate PR for it.

Before I change anything there, do you want the existing review comments be preserved or is it acceptable to move it to a new branch and create a fresh PR?

This is what I want to do: (Since the name of this PR is already HE calibration, I'll move the Fiducial Markers to a new PR)

1. Make a new branch for Fiducial Markers
2. Delete the fiducial-markers.md file and all media related to it

So the existing PR would be only for HE calibration.

Then I'll open a new PR for the Fiducial Markers and rebase on main.

Is this workflow accepted?

[MithraGhlm]

Unless we have actual guidelines how we want to improve style and formatting, there is no need increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

I'm not against the changes alltogether, but this is not the place to do it. A reformatting PR would be more appropriate

As you correctly commented once on the #485 (This PR contains all commits from #482, could you untangle this?), I untangled #482 from #485.
The initial problem was due to me forgetting to switch to main before making the new branch. But then I rebased it on the main and the problem was resolved. Now #482 and #485 are 2 different PRs.

So I don't understand what you mean by: increasing the scope of this PR to files that are unrelated to hand-eye calibration. It's good practice to keep scopes of PRs narrow.

Since we don't have any specific guidelines yet, how about just merging the small changes and closing #485, instead of reverting it?

[domire8]

All 4 of my previous review comments are still unresolved

[domire8]

Just two last formatting nitpicks. Otherwise all good!

[domire8]

Alright looks good now! Good work with this 👍

[SprGrf]

Nice work, sorry it took me so long to return to this!

[MithraGhlm]

Nice work, sorry it took me so long to return to this!

No worries :) It's nice you're back.

[domire8]

Suggested change

[domire8]

Yes very nice 👍