Uh oh!
There was an error while loading. Please reload this page.
test: review dogfood with npm binary - #12
Merged
Merged
Conversation
- Install CLI in isolated temp dir to avoid monorepo's catalog: protocol breaking npm install (EUNSUPPORTEDPROTOCOL error) - Add --print-logs --log-level DEBUG to diagnose 135ms instant exit - Use GITHUB_PATH to make aictrl binary available across steps Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previous run showed session completing in 129ms with no API call. Debug logs revealed resolveTools completes but session immediately cancels. Hypothesis: monorepo's .aictrl config or tool directories cause an exception during tool initialization that silently aborts the session. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The CI workflow is now confirmed working (run 22810222993). Restore the full code review prompt with gh pr comment integration, and remove the debug flags (--print-logs --log-level DEBUG) that were added during troubleshooting. Key fixes preserved: - Isolated npm install in $RUNNER_TEMP to avoid catalog: protocol conflict - cd $RUNNER_TEMP before running aictrl to avoid monorepo config interference
The agent couldn't read local files when running from $RUNNER_TEMP because the repo checkout is an "external directory" requiring permission. Instead of fighting the permission system, pre-compute the diff with `gh pr diff` and pass it directly in the prompt. This eliminates the need for the agent to read any local files.
Two fixes: 1. Build the review prompt as a file via heredoc instead of inline shell variable expansion. This handles large diffs and special characters. 2. Set GH_REPO env var and include explicit --repo flag in the prompt so the agent's gh commands target the correct repository. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code Review: PR #12SummaryThis PR refactors the aictrl installation and review workflow to avoid monorepo package.json conflicts. The approach is sound overall. Issues Found1. Heredoc Injection Risk (Medium) # Consider using a different approach like:printf'%s'"...">"$RUNNER_TEMP/review-prompt.txt"2. Missing Error Handling (Low) 3. Minor Inconsistency (Low) Good Practices
Reviewed SHA: 0646f9b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing that aictrl CLI from npm can run code reviews.