fix(status): Set a non-zero exit code on both validation branches. Mer... (#984) - #28

Draft
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984
Draft

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984)#28
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984

Conversation

@aidandaly24

Copy link
Copy Markdown
Owner

Refs aws#984

Issues

Root cause

In src/cli/commands/status/command.tsx the two argument-validation branches (--type lines 93-101, --state lines 104-112) render an error then bare-return without setting a non-zero exit code; withCommandRunTelemetry (cli-command-run.ts:94-136) only records telemetry and never exits, so parseAsync (cli.ts:174) resolves and Node exits 0. The real error paths at command.tsx:131/:165/:416 all call process.exit(1).

The fix

Set a non-zero exit code on both validation branches. Merge PR aws#1603 (process.exitCode = 1 before return, adds command.test.ts) — cleaner than a hard process.exit(1) because it lets cli.ts's finally cleanup run. Close PR aws#1169 (duplicate, uses process.exit(1), diff is stale against pre-aws#1317 file and will conflict).

Files touched: src/cli/commands/status/command.tsx — invalid --type branch (set exit signal after the render at line 99, before the return at line 100) and invalid --state branch (after the render at line 110, before the return at line 111). Test: src/cli/commands/status/tests/command.test.ts (new, per PR aws#1603).

Validation evidence

The fix was verified by reproducing the original symptom and re-running after the change:

Reproduced via built CLI (dist/cli/index.mjs by absolute path) against a minimal scratch project (agentcore/agentcore.json so requireProject passes). BEFORE (fix stashed + rebuilt): agentcore status --type bogus printed red "Invalid resource type 'bogus'. Valid types: ..." but exited 0; --state bogus printed "Invalid state 'bogus'. Valid states: ..." and exited 0 — the CI/set -e symptom. AFTER (fix restored + rebuilt): both invalid filters print the SAME validation error AND exit 1. Confirmed bash -c 'set -e; node CLI status --type bogus; echo SHOULD-NOT-PRINT' aborts (SHOULD-NOT-PRINT not emitted; script exit 1). New test command.test.ts asserts process.exitCode===1 for invalid --type and invalid --state (mockRender called) and process.exitCode undefined for valid --type agent; all 3 pass. Status directory 63/63 green.

Test suite: green.


Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.

The status command's --type and --state validation branches rendered an
error then bare-returned without setting a non-zero exit code, so scripts
and CI under set -e could not detect a rejected filter (silent success on
failure). Set process.exitCode = 1 on both branches before returning,
which still lets cli.ts's finally cleanup run.
Adds command.test.ts asserting exit code 1 for invalid --type and
--state, and unset for a valid filter.
Fixesaws#984
@github-actionsgithub-actionsBot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jun 25, 2026
@github-actions

github-actionsBot commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines37.28%13640 / 36579
🔵Statements36.55%14501 / 39669
🔵Functions31.87%2338 / 7336
🔵Branches31.25%9044 / 28932
Generated in workflow #136 for commit 83a709f by the Vitest Coverage Report Action

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aidandaly24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984) - #28

Draft
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984
Draft

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984)#28
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984

Conversation

@aidandaly24

Copy link
Copy Markdown
Owner

Refs aws#984

Issues

Root cause

In src/cli/commands/status/command.tsx the two argument-validation branches (--type lines 93-101, --state lines 104-112) render an error then bare-return without setting a non-zero exit code; withCommandRunTelemetry (cli-command-run.ts:94-136) only records telemetry and never exits, so parseAsync (cli.ts:174) resolves and Node exits 0. The real error paths at command.tsx:131/:165/:416 all call process.exit(1).

The fix

Set a non-zero exit code on both validation branches. Merge PR aws#1603 (process.exitCode = 1 before return, adds command.test.ts) — cleaner than a hard process.exit(1) because it lets cli.ts's finally cleanup run. Close PR aws#1169 (duplicate, uses process.exit(1), diff is stale against pre-aws#1317 file and will conflict).

Files touched: src/cli/commands/status/command.tsx — invalid --type branch (set exit signal after the render at line 99, before the return at line 100) and invalid --state branch (after the render at line 110, before the return at line 111). Test: src/cli/commands/status/tests/command.test.ts (new, per PR aws#1603).

Validation evidence

The fix was verified by reproducing the original symptom and re-running after the change:

Reproduced via built CLI (dist/cli/index.mjs by absolute path) against a minimal scratch project (agentcore/agentcore.json so requireProject passes). BEFORE (fix stashed + rebuilt): agentcore status --type bogus printed red "Invalid resource type 'bogus'. Valid types: ..." but exited 0; --state bogus printed "Invalid state 'bogus'. Valid states: ..." and exited 0 — the CI/set -e symptom. AFTER (fix restored + rebuilt): both invalid filters print the SAME validation error AND exit 1. Confirmed bash -c 'set -e; node CLI status --type bogus; echo SHOULD-NOT-PRINT' aborts (SHOULD-NOT-PRINT not emitted; script exit 1). New test command.test.ts asserts process.exitCode===1 for invalid --type and invalid --state (mockRender called) and process.exitCode undefined for valid --type agent; all 3 pass. Status directory 63/63 green.

Test suite: green.


Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.

The status command's --type and --state validation branches rendered an
error then bare-returned without setting a non-zero exit code, so scripts
and CI under set -e could not detect a rejected filter (silent success on
failure). Set process.exitCode = 1 on both branches before returning,
which still lets cli.ts's finally cleanup run.
Adds command.test.ts asserting exit code 1 for invalid --type and
--state, and unset for a valid filter.
Fixesaws#984
@github-actionsgithub-actionsBot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jun 25, 2026
@github-actions

github-actionsBot commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines37.28%13640 / 36579
🔵Statements36.55%14501 / 39669
🔵Functions31.87%2338 / 7336
🔵Branches31.25%9044 / 28932
Generated in workflow #136 for commit 83a709f by the Vitest Coverage Report Action

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aidandaly24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984) - #28

Draft
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984
Draft

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984)#28
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984

Conversation

@aidandaly24

Copy link
Copy Markdown
Owner

Refs aws#984

Issues

Root cause

In src/cli/commands/status/command.tsx the two argument-validation branches (--type lines 93-101, --state lines 104-112) render an error then bare-return without setting a non-zero exit code; withCommandRunTelemetry (cli-command-run.ts:94-136) only records telemetry and never exits, so parseAsync (cli.ts:174) resolves and Node exits 0. The real error paths at command.tsx:131/:165/:416 all call process.exit(1).

The fix

Set a non-zero exit code on both validation branches. Merge PR aws#1603 (process.exitCode = 1 before return, adds command.test.ts) — cleaner than a hard process.exit(1) because it lets cli.ts's finally cleanup run. Close PR aws#1169 (duplicate, uses process.exit(1), diff is stale against pre-aws#1317 file and will conflict).

Files touched: src/cli/commands/status/command.tsx — invalid --type branch (set exit signal after the render at line 99, before the return at line 100) and invalid --state branch (after the render at line 110, before the return at line 111). Test: src/cli/commands/status/tests/command.test.ts (new, per PR aws#1603).

Validation evidence

The fix was verified by reproducing the original symptom and re-running after the change:

Reproduced via built CLI (dist/cli/index.mjs by absolute path) against a minimal scratch project (agentcore/agentcore.json so requireProject passes). BEFORE (fix stashed + rebuilt): agentcore status --type bogus printed red "Invalid resource type 'bogus'. Valid types: ..." but exited 0; --state bogus printed "Invalid state 'bogus'. Valid states: ..." and exited 0 — the CI/set -e symptom. AFTER (fix restored + rebuilt): both invalid filters print the SAME validation error AND exit 1. Confirmed bash -c 'set -e; node CLI status --type bogus; echo SHOULD-NOT-PRINT' aborts (SHOULD-NOT-PRINT not emitted; script exit 1). New test command.test.ts asserts process.exitCode===1 for invalid --type and invalid --state (mockRender called) and process.exitCode undefined for valid --type agent; all 3 pass. Status directory 63/63 green.

Test suite: green.


Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.

The status command's --type and --state validation branches rendered an
error then bare-returned without setting a non-zero exit code, so scripts
and CI under set -e could not detect a rejected filter (silent success on
failure). Set process.exitCode = 1 on both branches before returning,
which still lets cli.ts's finally cleanup run.
Adds command.test.ts asserting exit code 1 for invalid --type and
--state, and unset for a valid filter.
Fixesaws#984
@github-actionsgithub-actionsBot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jun 25, 2026
@github-actions

github-actionsBot commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines37.28%13640 / 36579
🔵Statements36.55%14501 / 39669
🔵Functions31.87%2338 / 7336
🔵Branches31.25%9044 / 28932
Generated in workflow #136 for commit 83a709f by the Vitest Coverage Report Action

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aidandaly24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984) - #28

Draft
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984
Draft

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984)#28
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984

Conversation

@aidandaly24

Copy link
Copy Markdown
Owner

Refs aws#984

Issues

Root cause

In src/cli/commands/status/command.tsx the two argument-validation branches (--type lines 93-101, --state lines 104-112) render an error then bare-return without setting a non-zero exit code; withCommandRunTelemetry (cli-command-run.ts:94-136) only records telemetry and never exits, so parseAsync (cli.ts:174) resolves and Node exits 0. The real error paths at command.tsx:131/:165/:416 all call process.exit(1).

The fix

Set a non-zero exit code on both validation branches. Merge PR aws#1603 (process.exitCode = 1 before return, adds command.test.ts) — cleaner than a hard process.exit(1) because it lets cli.ts's finally cleanup run. Close PR aws#1169 (duplicate, uses process.exit(1), diff is stale against pre-aws#1317 file and will conflict).

Files touched: src/cli/commands/status/command.tsx — invalid --type branch (set exit signal after the render at line 99, before the return at line 100) and invalid --state branch (after the render at line 110, before the return at line 111). Test: src/cli/commands/status/tests/command.test.ts (new, per PR aws#1603).

Validation evidence

The fix was verified by reproducing the original symptom and re-running after the change:

Reproduced via built CLI (dist/cli/index.mjs by absolute path) against a minimal scratch project (agentcore/agentcore.json so requireProject passes). BEFORE (fix stashed + rebuilt): agentcore status --type bogus printed red "Invalid resource type 'bogus'. Valid types: ..." but exited 0; --state bogus printed "Invalid state 'bogus'. Valid states: ..." and exited 0 — the CI/set -e symptom. AFTER (fix restored + rebuilt): both invalid filters print the SAME validation error AND exit 1. Confirmed bash -c 'set -e; node CLI status --type bogus; echo SHOULD-NOT-PRINT' aborts (SHOULD-NOT-PRINT not emitted; script exit 1). New test command.test.ts asserts process.exitCode===1 for invalid --type and invalid --state (mockRender called) and process.exitCode undefined for valid --type agent; all 3 pass. Status directory 63/63 green.

Test suite: green.


Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.

The status command's --type and --state validation branches rendered an
error then bare-returned without setting a non-zero exit code, so scripts
and CI under set -e could not detect a rejected filter (silent success on
failure). Set process.exitCode = 1 on both branches before returning,
which still lets cli.ts's finally cleanup run.
Adds command.test.ts asserting exit code 1 for invalid --type and
--state, and unset for a valid filter.
Fixesaws#984
@github-actionsgithub-actionsBot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jun 25, 2026
@github-actions

github-actionsBot commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines37.28%13640 / 36579
🔵Statements36.55%14501 / 39669
🔵Functions31.87%2338 / 7336
🔵Branches31.25%9044 / 28932
Generated in workflow #136 for commit 83a709f by the Vitest Coverage Report Action

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aidandaly24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984) - #28

Draft
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984
Draft

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984)#28
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984

Conversation

@aidandaly24

Copy link
Copy Markdown
Owner

Refs aws#984

Issues

Root cause

In src/cli/commands/status/command.tsx the two argument-validation branches (--type lines 93-101, --state lines 104-112) render an error then bare-return without setting a non-zero exit code; withCommandRunTelemetry (cli-command-run.ts:94-136) only records telemetry and never exits, so parseAsync (cli.ts:174) resolves and Node exits 0. The real error paths at command.tsx:131/:165/:416 all call process.exit(1).

The fix

Set a non-zero exit code on both validation branches. Merge PR aws#1603 (process.exitCode = 1 before return, adds command.test.ts) — cleaner than a hard process.exit(1) because it lets cli.ts's finally cleanup run. Close PR aws#1169 (duplicate, uses process.exit(1), diff is stale against pre-aws#1317 file and will conflict).

Files touched: src/cli/commands/status/command.tsx — invalid --type branch (set exit signal after the render at line 99, before the return at line 100) and invalid --state branch (after the render at line 110, before the return at line 111). Test: src/cli/commands/status/tests/command.test.ts (new, per PR aws#1603).

Validation evidence

The fix was verified by reproducing the original symptom and re-running after the change:

Reproduced via built CLI (dist/cli/index.mjs by absolute path) against a minimal scratch project (agentcore/agentcore.json so requireProject passes). BEFORE (fix stashed + rebuilt): agentcore status --type bogus printed red "Invalid resource type 'bogus'. Valid types: ..." but exited 0; --state bogus printed "Invalid state 'bogus'. Valid states: ..." and exited 0 — the CI/set -e symptom. AFTER (fix restored + rebuilt): both invalid filters print the SAME validation error AND exit 1. Confirmed bash -c 'set -e; node CLI status --type bogus; echo SHOULD-NOT-PRINT' aborts (SHOULD-NOT-PRINT not emitted; script exit 1). New test command.test.ts asserts process.exitCode===1 for invalid --type and invalid --state (mockRender called) and process.exitCode undefined for valid --type agent; all 3 pass. Status directory 63/63 green.

Test suite: green.


Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.

The status command's --type and --state validation branches rendered an
error then bare-returned without setting a non-zero exit code, so scripts
and CI under set -e could not detect a rejected filter (silent success on
failure). Set process.exitCode = 1 on both branches before returning,
which still lets cli.ts's finally cleanup run.
Adds command.test.ts asserting exit code 1 for invalid --type and
--state, and unset for a valid filter.
Fixesaws#984
@github-actionsgithub-actionsBot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jun 25, 2026
@github-actions

github-actionsBot commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines37.28%13640 / 36579
🔵Statements36.55%14501 / 39669
🔵Functions31.87%2338 / 7336
🔵Branches31.25%9044 / 28932
Generated in workflow #136 for commit 83a709f by the Vitest Coverage Report Action

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aidandaly24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984) - #28

Draft
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984
Draft

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984)#28
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984

Conversation

@aidandaly24

Copy link
Copy Markdown
Owner

Refs aws#984

Issues

Root cause

In src/cli/commands/status/command.tsx the two argument-validation branches (--type lines 93-101, --state lines 104-112) render an error then bare-return without setting a non-zero exit code; withCommandRunTelemetry (cli-command-run.ts:94-136) only records telemetry and never exits, so parseAsync (cli.ts:174) resolves and Node exits 0. The real error paths at command.tsx:131/:165/:416 all call process.exit(1).

The fix

Set a non-zero exit code on both validation branches. Merge PR aws#1603 (process.exitCode = 1 before return, adds command.test.ts) — cleaner than a hard process.exit(1) because it lets cli.ts's finally cleanup run. Close PR aws#1169 (duplicate, uses process.exit(1), diff is stale against pre-aws#1317 file and will conflict).

Files touched: src/cli/commands/status/command.tsx — invalid --type branch (set exit signal after the render at line 99, before the return at line 100) and invalid --state branch (after the render at line 110, before the return at line 111). Test: src/cli/commands/status/tests/command.test.ts (new, per PR aws#1603).

Validation evidence

The fix was verified by reproducing the original symptom and re-running after the change:

Reproduced via built CLI (dist/cli/index.mjs by absolute path) against a minimal scratch project (agentcore/agentcore.json so requireProject passes). BEFORE (fix stashed + rebuilt): agentcore status --type bogus printed red "Invalid resource type 'bogus'. Valid types: ..." but exited 0; --state bogus printed "Invalid state 'bogus'. Valid states: ..." and exited 0 — the CI/set -e symptom. AFTER (fix restored + rebuilt): both invalid filters print the SAME validation error AND exit 1. Confirmed bash -c 'set -e; node CLI status --type bogus; echo SHOULD-NOT-PRINT' aborts (SHOULD-NOT-PRINT not emitted; script exit 1). New test command.test.ts asserts process.exitCode===1 for invalid --type and invalid --state (mockRender called) and process.exitCode undefined for valid --type agent; all 3 pass. Status directory 63/63 green.

Test suite: green.


Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.

The status command's --type and --state validation branches rendered an
error then bare-returned without setting a non-zero exit code, so scripts
and CI under set -e could not detect a rejected filter (silent success on
failure). Set process.exitCode = 1 on both branches before returning,
which still lets cli.ts's finally cleanup run.
Adds command.test.ts asserting exit code 1 for invalid --type and
--state, and unset for a valid filter.
Fixesaws#984
@github-actionsgithub-actionsBot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jun 25, 2026
@github-actions

github-actionsBot commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines37.28%13640 / 36579
🔵Statements36.55%14501 / 39669
🔵Functions31.87%2338 / 7336
🔵Branches31.25%9044 / 28932
Generated in workflow #136 for commit 83a709f by the Vitest Coverage Report Action

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aidandaly24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984) - #28

Draft
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984
Draft

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984)#28
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984

Conversation

@aidandaly24

Copy link
Copy Markdown
Owner

Refs aws#984

Issues

Root cause

In src/cli/commands/status/command.tsx the two argument-validation branches (--type lines 93-101, --state lines 104-112) render an error then bare-return without setting a non-zero exit code; withCommandRunTelemetry (cli-command-run.ts:94-136) only records telemetry and never exits, so parseAsync (cli.ts:174) resolves and Node exits 0. The real error paths at command.tsx:131/:165/:416 all call process.exit(1).

The fix

Set a non-zero exit code on both validation branches. Merge PR aws#1603 (process.exitCode = 1 before return, adds command.test.ts) — cleaner than a hard process.exit(1) because it lets cli.ts's finally cleanup run. Close PR aws#1169 (duplicate, uses process.exit(1), diff is stale against pre-aws#1317 file and will conflict).

Files touched: src/cli/commands/status/command.tsx — invalid --type branch (set exit signal after the render at line 99, before the return at line 100) and invalid --state branch (after the render at line 110, before the return at line 111). Test: src/cli/commands/status/tests/command.test.ts (new, per PR aws#1603).

Validation evidence

The fix was verified by reproducing the original symptom and re-running after the change:

Reproduced via built CLI (dist/cli/index.mjs by absolute path) against a minimal scratch project (agentcore/agentcore.json so requireProject passes). BEFORE (fix stashed + rebuilt): agentcore status --type bogus printed red "Invalid resource type 'bogus'. Valid types: ..." but exited 0; --state bogus printed "Invalid state 'bogus'. Valid states: ..." and exited 0 — the CI/set -e symptom. AFTER (fix restored + rebuilt): both invalid filters print the SAME validation error AND exit 1. Confirmed bash -c 'set -e; node CLI status --type bogus; echo SHOULD-NOT-PRINT' aborts (SHOULD-NOT-PRINT not emitted; script exit 1). New test command.test.ts asserts process.exitCode===1 for invalid --type and invalid --state (mockRender called) and process.exitCode undefined for valid --type agent; all 3 pass. Status directory 63/63 green.

Test suite: green.


Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.

The status command's --type and --state validation branches rendered an
error then bare-returned without setting a non-zero exit code, so scripts
and CI under set -e could not detect a rejected filter (silent success on
failure). Set process.exitCode = 1 on both branches before returning,
which still lets cli.ts's finally cleanup run.
Adds command.test.ts asserting exit code 1 for invalid --type and
--state, and unset for a valid filter.
Fixesaws#984
@github-actionsgithub-actionsBot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jun 25, 2026
@github-actions

github-actionsBot commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines37.28%13640 / 36579
🔵Statements36.55%14501 / 39669
🔵Functions31.87%2338 / 7336
🔵Branches31.25%9044 / 28932
Generated in workflow #136 for commit 83a709f by the Vitest Coverage Report Action

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aidandaly24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984) - #28

Draft
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984
Draft

fix(status): Set a non-zero exit code on both validation branches. Mer... (#984)#28
aidandaly24 wants to merge 2 commits into
mainfrom
fix/984

Conversation

@aidandaly24

Copy link
Copy Markdown
Owner

Refs aws#984

Issues

Root cause

In src/cli/commands/status/command.tsx the two argument-validation branches (--type lines 93-101, --state lines 104-112) render an error then bare-return without setting a non-zero exit code; withCommandRunTelemetry (cli-command-run.ts:94-136) only records telemetry and never exits, so parseAsync (cli.ts:174) resolves and Node exits 0. The real error paths at command.tsx:131/:165/:416 all call process.exit(1).

The fix

Set a non-zero exit code on both validation branches. Merge PR aws#1603 (process.exitCode = 1 before return, adds command.test.ts) — cleaner than a hard process.exit(1) because it lets cli.ts's finally cleanup run. Close PR aws#1169 (duplicate, uses process.exit(1), diff is stale against pre-aws#1317 file and will conflict).

Files touched: src/cli/commands/status/command.tsx — invalid --type branch (set exit signal after the render at line 99, before the return at line 100) and invalid --state branch (after the render at line 110, before the return at line 111). Test: src/cli/commands/status/tests/command.test.ts (new, per PR aws#1603).

Validation evidence

The fix was verified by reproducing the original symptom and re-running after the change:

Reproduced via built CLI (dist/cli/index.mjs by absolute path) against a minimal scratch project (agentcore/agentcore.json so requireProject passes). BEFORE (fix stashed + rebuilt): agentcore status --type bogus printed red "Invalid resource type 'bogus'. Valid types: ..." but exited 0; --state bogus printed "Invalid state 'bogus'. Valid states: ..." and exited 0 — the CI/set -e symptom. AFTER (fix restored + rebuilt): both invalid filters print the SAME validation error AND exit 1. Confirmed bash -c 'set -e; node CLI status --type bogus; echo SHOULD-NOT-PRINT' aborts (SHOULD-NOT-PRINT not emitted; script exit 1). New test command.test.ts asserts process.exitCode===1 for invalid --type and invalid --state (mockRender called) and process.exitCode undefined for valid --type agent; all 3 pass. Status directory 63/63 green.

Test suite: green.


Staged on the fork as a draft for human review. Promote to aws/agentcore-cli after vetting.

The status command's --type and --state validation branches rendered an
error then bare-returned without setting a non-zero exit code, so scripts
and CI under set -e could not detect a rejected filter (silent success on
failure). Set process.exitCode = 1 on both branches before returning,
which still lets cli.ts's finally cleanup run.
Adds command.test.ts asserting exit code 1 for invalid --type and
--state, and unset for a valid filter.
Fixesaws#984
@github-actionsgithub-actionsBot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jun 25, 2026
@github-actions

github-actionsBot commented Jun 25, 2026

Copy link
Copy Markdown

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines37.28%13640 / 36579
🔵Statements36.55%14501 / 39669
🔵Functions31.87%2338 / 7336
🔵Branches31.25%9044 / 28932
Generated in workflow #136 for commit 83a709f by the Vitest Coverage Report Action

@github-actionsgithub-actionsBot added size/s PR size: S and removed size/s PR size: S labels Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sPR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aidandaly24