fix: make isElement compatible with iframe elements - #3
Open
LynnDolly wants to merge 3 commits into
Open
Conversation
…-is-element fix: make isElement compatible with iframe elements
@LynnDolly is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instanceof Elementcan fail for elements created in a different browsing context (e.g. iframe),because each window has its own
Elementconstructor.This change updates
isElementto support cross-iframe elements by:node instanceof Elementnode.ownerDocument.defaultView.Elementnode instanceof ElementConstructorWhy
element-sourcemay receive nodes from embedded documents.Without this fallback, valid iframe elements may be treated as non-elements.
Scope
packages/element-source/src/utils/is-element.ts