Uh oh!
There was an error while loading. Please reload this page.
feat(application): Add option to summarize run describe. - #414
Conversation
3e986b0 to
394b89bCompareCodecov Report✅ All modified and coverable lines are covered by tests.
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
PR #414 Review: feat(application): Add option to summarize run describeExecutive SummaryStatus: ❌ BLOCKING ISSUES FOUND This PR adds a ✅ Strengths
🚫 BLOCKING ISSUES (Must Fix)1. Ruff Linting Failure (CRITICAL)Location: Issue: Complexity check violation - compound condition should use set membership # CURRENT (line 188):if (state.value==RunState.TERMINATEDorstate.value==ItemState.TERMINATED) andtermination_reason:
returnf"{state.value} ({termination_reason})"Linting Error: Fix: Refactor to use set membership for cleaner comparison: # OPTION 1 (Recommended - Most Pythonic):ifstate.valuein {RunState.TERMINATED.value, ItemState.TERMINATED.value} andtermination_reason:
returnf"{state.value} ({termination_reason})"# OPTION 2 (Alternative - Direct enum comparison):ifstatein {RunState.TERMINATED, ItemState.TERMINATED} andtermination_reason:
returnf"{state.value} ({termination_reason})"Why This Matters: This is medical device software. Linting rules enforce code quality standards that prevent bugs.
Verify Fix: make lint💡 SUGGESTIONS (Non-Blocking)1. Help Text ImprovementLocation: # CURRENT:help="Show only run and item status summary (external ID, state, error message)"# SUGGESTION (more explicit about what's hidden):help="Show concise status summary (omits artifact download URLs and metadata)"This makes it clearer what the flag does (omits verbose output) rather than what it shows. ✅ Architecture Compliance
🎯 Testing VerificationTest Markers Check# Verified: All tests have required markers
uv run pytest tests/aignostics/application/utils_test.py -m "not unit and not integration and not e2e" --collect-only
# Result: 61 collected / 61 deselected / 0 selected ✅Coverage Impact
📋 Required Actions Before MergeMUST FIX (Blocking)
RECOMMENDED (Non-Blocking)
🔍 Final Verification CommandsAfter fixing the linting issue, run: # Full validation pipeline
make lint && make test_unit
# Or the complete suite
make allExpected result: All checks pass ✅ 🎖️ Excellent Work On
Once the linting issue is fixed, this PR will be ready to merge. 🚀 Reviewed by: Claude Code (AI-powered code review) |
olivermeyer
commented
Feb 5, 2026
The core changes look good! Ready to go when the checks pass. |
Co-authored-by: Oliver Meyer <42039965+olivermeyer@users.noreply.github.com>
e43e09b to
8916868Compare
|
olivermeyer
left a comment
There was a problem hiding this comment.
Looks good!
The failing test on MacOS runner is known as flaky; slight duplication in test code is not critical.
Uh oh!
There was an error while loading. Please reload this page.


To facilitate overview of run progress for users, specially for runs with large numbers of items, add a
--sumarizeoption toapplication run describethat just outputs run status and item status + error message, if given.