Uh oh!
There was an error while loading. Please reload this page.
fix(docs): correct skip:test:long_running label name in CLAUDE.md - #564
Closed
helmut-hoffer-von-ankershoffen wants to merge 1 commit into
Closed
fix(docs): correct skip:test:long_running label name in CLAUDE.md#564helmut-hoffer-von-ankershoffen wants to merge 1 commit into
helmut-hoffer-von-ankershoffen wants to merge 1 commit into
Conversation
The label uses colons as separators, not underscores. The wrong name caused the label to not be found when creating PRs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilotstarted reviewing on behalf of helmut-hoffer-von-ankershoffenApril 24, 2026 08:51 View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s root CLAUDE.md documentation to use the correct GitHub label name for skipping long-running tests, aligning it with the label used elsewhere (notably .github/CLAUDE.md) and preventing gh pr edit --add-label failures during automated PR creation.
Changes:
- Replace
skip:test_long_runningwithskip:test:long_runningin the contributor PR instructions. - Update two
gh pr edit --add-labelcommand examples to use the correct label.
| If you you are creating a pull request yourself: | ||
| * Add a label skip:test_long_running, to skip running long running tests. This is important because some tests in this repository are marked as long_running and can take a significant amount of time to complete. By adding this label, you help ensure that the CI pipeline runs efficiently and avoids unnecessary delays. | ||
| * Add a label skip:test:long_running, to skip running long running tests. This is important because some tests in this repository are marked as long_running and can take a significant amount of time to complete. By adding this label, you help ensure that the CI pipeline runs efficiently and avoids unnecessary delays. |
There was a problem hiding this comment.
For consistency with the rest of this doc (e.g., the later references that wrap labels in backticks), consider formatting the label as skip:test:long_running and removing the comma after it ("label … to …"). Also consider using consistent hyphenation ("long-running") in this sentence.
Suggested change
| * Add a label skip:test:long_running, to skip running longrunning tests. This is important because some tests in this repository are marked as long_running and can take a significant amount of time to complete. By adding this label, you help ensure that the CI pipeline runs efficiently and avoids unnecessary delays. | |
| * Add the label `skip:test:long_running` to skip running long-running tests. This is important because some tests in this repository are marked as `long_running` and can take a significant amount of time to complete. By adding this label, you help ensure that the CI pipeline runs efficiently and avoids unnecessary delays. |
helmut-hoffer-von-ankershoffen
deleted the
fix/claude-md-skip-label-name
branch
April 24, 2026 18:29
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛡️ Resolves PYSDK-89 following PR-SOP-01 Problem Resolution and Non-Conforming Products, part of our ISO 13485-certified QMS | Ketryx Project
Summary
skip:test_long_running(underscores) →skip:test:long_running(colons) inCLAUDE.mdgh pr edit --add-labelto fail with "label not found" when Claude Code created PRs.github/CLAUDE.mdalready used the correct colon form throughoutRoot cause
Implementation error: the label name in
CLAUDE.mdwas written with underscores when the PR label naming convention was established..github/CLAUDE.mdhad the correct form butCLAUDE.mdwas not kept in sync.Test plan
gh pr edit --add-label "skip:test:long_running"succeeds on a test PRCLAUDE.mdno longer containsskip:test_long_running🤖 Generated with Claude Code