Skip to content

chore(dev): update scalene profile target for v2 API [PYSDK-91]#579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helmut-hoffer-von-ankershoffen merged 2 commits into from
Apr 24, 2026
Merged

chore(dev): update scalene profile target for v2 API [PYSDK-91] #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ecbc43
fix(dev): update scalene profile target for v2 API
helmut-hoffer-von-ankershoffen Apr 24, 2026
86ffda5
fix(dev): create tmp/ dir before writing scalene profile output
helmut-hoffer-von-ankershoffen Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -86,6 +86,8 @@ CLAUDE.local.md
# Scalene
profile.json
profile.html
scalene-profile.json
scalene-profile.html

# Nicegui
.nicegui
Expand Down
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -162,7 +162,8 @@ gui_watch:
uv run runner/gui_watch.py

profile:
uv run --all-extras python -m scalene runner/scalene.py
mkdir -p tmp
uv run --all-extras python -m scalene run runner/scalene.py --outfile tmp/scalene-profile.json && uv run --all-extras python -m scalene view tmp/scalene-profile.json

CopilotAIApr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--outfile is placed after runner/scalene.py, which is likely treated as an argument to the profiled program (Typer CLI) rather than to Scalene. Since the SDK CLI doesn’t define --outfile, make profile will fail with an “unknown option” error. Pass Scalene options before the target program, and use -- to separate Scalene args from the program being profiled (if Scalene expects that).

Suggested change
uv run --all-extras python -m scalene run runner/scalene.py --outfile tmp/scalene-profile.json && uv run --all-extras python -m scalene view tmp/scalene-profile.json
uv run --all-extras python -m scalene run --outfile tmp/scalene-profile.json -- runner/scalene.py && uv run --all-extras python -m scalene view tmp/scalene-profile.json

Copilot uses AI. Check for mistakes.

# Signing: https://gist.github.com/bpteague/750906b9a02094e7389427d308ba1002
dist_native:
Expand Down
Loading