Skip to content

test: add slim smoke tests and verify test suite for aignostics-sdk split [PYSDK-141] - #659

Closed
ari-nz wants to merge 1 commit into
feat/PYSDK-136/import-rewritefrom
feat/PYSDK-141/tests
Closed

test: add slim smoke tests and verify test suite for aignostics-sdk split [PYSDK-141]#659
ari-nz wants to merge 1 commit into
feat/PYSDK-136/import-rewritefrom
feat/PYSDK-141/tests

Conversation

@ari-nz

@ari-nzari-nz commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Release Train — PYSDK-133

Verify wiring on the integration branch first: #661 (draft, targets main)

StepPRJiraPhaseNotes
1#653PYSDK-134Workspace scaffoldingMerge first — gates everything below
2a#656PYSDK-135Source migrationAfter #653
2b#655PYSDK-138Dependency splitAfter #653, parallel with 2a
2c#654PYSDK-139Tooling updatesAfter #653, parallel with 2a
3#657PYSDK-136Import rewriteAfter #656
4a#658PYSDK-137Slim CLIAfter #657
4b#659PYSDK-141TestsAfter #657, parallel with 4a
#651PYSDK-140CI/CD pipelineIndependent — merge any time
#652PYSDK-142Docs & migrationIndependent — merge any time

Retargeting: each PR currently targets its predecessor branch. After the predecessor merges into feat/PYSDK-133/python-sdk-slim, retarget this PR to feat/PYSDK-133/python-sdk-slim before merging it.


This PR — Step 4b: Merge after #657 (import rewrite), parallel with #658. Retarget to feat/PYSDK-133/python-sdk-slim first.

Summary

  • Registers the slim pytest marker in pyproject.toml for tests targeting the aignostics-sdk slim package distribution
  • Creates tests/aignostics_sdk/__init__.py and tests/aignostics_sdk/smoke_test.py with 6 tests (5 passing, 1 xfail)
  • Verifies test collection is clean: 904 tests collected, 0 collection errors, no stale from aignostics.platform / from aignostics.utils imports in test files

Smoke test coverage

TestResultNotes
test_platform_client_importablePASSaignostics_sdk.platform.Client resolves
test_utils_importablePASSaignostics_sdk.utils.{BaseService,Health} resolve
test_aignx_codegen_importablePASSaignx.codegen.exceptions.ApiException resolves
test_project_name_preservedPASS__project_name__ == "aignostics" for backward compat
test_version_availablePASS__version__ is non-empty
test_slim_cli_entry_pointXFAIL (strict)aignostics_sdk.cli module pending PYSDK-137

Known pre-existing failures (not introduced here)

The base branch feat/PYSDK-136/import-rewrite already has 116 failing unit tests and 93 errors from stale patch("aignostics.platform._authentication...") and similar mock paths that were not updated when PYSDK-136 rewrote the from aignostics.* imports. These will be addressed in a follow-up fix to PYSDK-136 and are not in scope for this PR.

Deferred work

  • PYSDK-137: aignostics_sdk.cli module carve-out — test_slim_cli_entry_point will flip from xfail to green once that lands
  • PYSDK-138: Dependency slimming — heavy deps (openslide, nicegui, etc.) are still present in aignostics-sdk; the "heavy deps not present" assertions from the original task spec are deferred until PYSDK-138 merges

This PR was created by Claude (claude-sonnet-4-6) on behalf of Ari Angelo (ari@aignostics.com).

…plit [PYSDK-141]
- Add `slim` pytest marker to pyproject.toml for aignostics-sdk package tests
- Create tests/aignostics_sdk/__init__.py and smoke_test.py
- 5 smoke tests verify importability of aignostics_sdk.platform.Client,
aignostics_sdk.utils.{BaseService,Health}, aignx.codegen.exceptions.ApiException,
__project_name__ backward-compat constant, and __version__ availability
- 1 xfail test documents missing aignostics_sdk.cli module (pending PYSDK-137)
- No stale `from aignostics.platform` / `from aignostics.utils` imports in tests/
- Collection: 904 tests collected (0 collection errors)
- Pre-existing failures in base branch (stale patch() paths from PYSDK-136
import rewrite) are not introduced by this PR; they will be tracked separately
CopilotAI review requested due to automatic review settings May 28, 2026 11:44
@ari-nz
ari-nz requested a review from a team as a code ownerMay 28, 2026 11:44
@ari-nzari-nz added skip:test:long_running Skip long-running tests (≥5min) sop:cc-sop-01 CC-SOP-01 Change Control (feature / planned change) type:test Test-only change scope:dev-only Affects only our dev/CI env; consumers unaffected labels May 28, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds initial smoke-test coverage for the new aignostics-sdk slim distribution path and registers a dedicated pytest marker so these tests can be selected under strict marker validation.

Changes:

  • Adds the slim pytest marker.
  • Adds smoke tests for core aignostics_sdk and bundled aignx imports, constants, version availability, and pending CLI behavior.
  • Adds a package marker file for the new tests/aignostics_sdk test area.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
pyproject.tomlRegisters the new slim pytest marker.
tests/aignostics_sdk/__init__.pyAdds the test package docstring for slim SDK tests.
tests/aignostics_sdk/smoke_test.pyAdds slim SDK smoke tests for imports, constants, version, and pending CLI entry behavior.

assert ApiException is not None


@pytest.mark.unit
Comment on lines +64 to +65
result = subprocess.run(
[sys.executable, "-m", "aignostics_sdk.cli", "--help"],
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:dev-onlyAffects only our dev/CI env; consumers unaffectedskip:test:long_runningSkip long-running tests (≥5min)sop:cc-sop-01CC-SOP-01 Change Control (feature / planned change)type:testTest-only change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ari-nz