Skip to content

Blacklist confusing globals - #1420

Merged
ljharb merged 1 commit into
airbnb:masterfrom
sidoshi:blacklist-globals
May 20, 2017
Merged

Blacklist confusing globals#1420
ljharb merged 1 commit into
airbnb:masterfrom
sidoshi:blacklist-globals

Conversation

@sidoshi

Copy link
Copy Markdown
Contributor

Blacklist confusing global variables set by browser env as discussed here.

@ljharbljharb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb
ljharb merged commit 0dd3dbd into airbnb:masterMay 20, 2017
@sidoshi

Copy link
Copy Markdown
ContributorAuthor

We have changed the name to confusing-browser-globals at CRA. see here
Will send an update once that PR gets merged. So both has same data source as you wanted.

@ljharb

Copy link
Copy Markdown
Collaborator

Sounds good, thanks!

ljharb added a commit to ljharb/javascript that referenced this pull request Jul 23, 2017
jaylaw81 pushed a commit to appirio-digital/ads-best-practices that referenced this pull request Sep 19, 2017
rafiquecudjoe pushed a commit to rafiquecudjoe/javascript that referenced this pull request Jun 7, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sidoshi@ljharb