docs: give Windows a working install command - #4
Open
Abdul-Omira wants to merge 1 commit into
Open
Conversation
The Install section offered only `curl … | bash`, which cannot work in PowerShell — the shell Windows users get. It fails with "the term 'bash' is not recognized", or, where WSL is installed, with "Invoke-WebRequest: A parameter cannot be found that matches parameter name 'fsSL'", because PowerShell 5.1 aliases curl to Invoke-WebRequest. Both reproduced on Windows 11 / PowerShell 5.1. Adds the PowerShell one-liner, and the scriptblock form for passing options. Platform support also claimed "the shell installer above is for macOS and Linux" and sent Windows users to a manual tarball download. That was wrong: `install` has handled Windows for months. What it cannot do is run outside a bash, or put koder on a PATH that PowerShell and cmd can see — which is what install.ps1 is for. Says that instead, and keeps the manual download as the fallback it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to aixplain/aixplainCode#754, which adds
install.ps1to the release. This is the page customers actually read.What's wrong today
The Install section offers one command —
curl -fsSL … | bash— and the platform badge advertises Windows. A Windows user pastes the only thing on offer and it cannot work. Reproduced both variants on Windows 11 / PowerShell 5.1:The term 'bash' is not recognizedInvoke-WebRequest : A parameter cannot be found that matches parameter name 'fsSL'The second is the common one: PowerShell 5.1 aliases
curltoInvoke-WebRequest, so it dies on the flags beforebashis even reached.Platform support then says:
That's false.
installhas detectedMINGW*|MSYS*|CYGWIN*and installedkoder.exefor months. What it genuinely cannot do is run outside a bash, or write a PATH entry that PowerShell and cmd can see — it writes to~/.bashrc. So even a successful Git Bash install leaveskoder"not found" in PowerShell.This PR
[scriptblock]::Createform for-Version/-NoModifyPath(a pipediexhas nowhere to put options).Merge order
install.ps1is published by aixplain/aixplainCode#754, so merge that first and cut a release — until then theinstall.ps1URL 404s. #754 also adds a check that fails our sync job if this README ever stops teaching an installer we publish, which is how the wrong paragraph survived this long.