Split 0041 into phantom-cleanup (0041) + table-view (0042) - #747
Merged
Merged
Conversation
…grations The original 0041_browser_table_view.py was a consolidation born of develop and browser-table-view both adding a migration numbered 0041 to a shared 0040 parent — the consolidation merged the phantom-Comic cleanup ``RunPython`` (originally develop's standalone 0041) into the table-view schema migration to keep history linear. Re-split now that main has shipped 0041_cleanup_phantom_comic_as_folder_rows in its own right. develop should mirror main on 0041 verbatim, then add the table-view operations as 0042 on top: - 0041_cleanup_phantom_comic_as_folder_rows.py is now byte-identical to main's copy. Same docstring, same helpers (``_is_comic_path``, ``_comics_fs_reachable``, ``_stat_says_directory``, ``_path_says_directory``, ``_find_corrupt_comic_pks``, ``_cleanup_phantom_comic_as_folder_rows``, ``_noop``), and the single ``RunPython`` operation. - 0042_browser_table_view.py carries only the table-view schema work: the four ``AddField``s (``view_mode``, ``table_columns``, ``table_cover_size``, ``order_extra_keys``) and the ``order_by`` ``AlterField`` that refreshes the choice list to the post- table-view set. Depends on 0041_cleanup. Verified: ``makemigrations --check --dry-run`` reports no drift, ``showmigrations`` prints 0040 → 0041 → 0042 linearly, and the full test suite (193 tests) still passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-splits the consolidated
0041_browser_table_view.pyinto two migrations so develop mirrors main on the phantom-cleanup migration verbatim.0041_cleanup_phantom_comic_as_folder_rows.py— byte-identical to main's copy.0042_browser_table_view.py— depends on 0041; carries only the table-view schema work.Why
The original consolidation was born of develop and browser-table-view both adding a migration numbered 0041 to a shared 0040 parent — the merge merged develop's standalone 0041 (phantom-Comic cleanup
RunPython) into browser-table-view's schema migration to keep the history linear. Now that main has shipped its own 0041 separately, develop should match: 0041 stays as the cleanup migration (same hash as main), and the table-view schema work moves to 0042.What changed
codex/migrations/0041_browser_table_view.py— deleted.codex/migrations/0041_cleanup_phantom_comic_as_folder_rows.py— added, byte-identical to main's copy. Same docstring, same helpers (_is_comic_path,_comics_fs_reachable,_stat_says_directory,_path_says_directory,_find_corrupt_comic_pks,_cleanup_phantom_comic_as_folder_rows,_noop), singleRunPythonoperation.codex/migrations/0042_browser_table_view.py— added. Depends on0041_cleanup_phantom_comic_as_folder_rows. Operations:AddFieldview_mode,table_columns,table_cover_size,order_extra_keysAlterFieldorder_bywith the post-table-view choice listTest plan
makemigrations --check --dry-runreports no driftshowmigrations codexprints 0040 → 0041 → 0042 linearlyruff checkcleancomplexipycleanReviewer notes
cmpconfirms 0041 here is byte-identical to main's copy.🤖 Generated with Claude Code