chore: disentangle npm listing from the unrelated create-wp-plugin package - #19
Merged
Conversation
…ckage
- README: H1 -> create-wp-plugin-cli (matches the package name; bare
create-wp-plugin is a separate, unrelated package), add npm/CI/license
badges, drop the "name was already taken" blockquote
- package.json: replace the stale v2 description ("Container + Service
Providers", removed in v3.0.0) with the current static-bootloader
wording; remove the create-wp-plugin bin alias so installing this no
longer shadows the other package on PATH; add keywords
(wordpress-plugin, wp-cli, gutenberg, phpunit)
- BACKLOG: close NEW-56 (add create-wp-plugin bin alias) as rejected --
it contradicts the disentangling intentUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
create-wp-plugin(no-cli) is a separate, unrelated npm package (by David Gwyer / wpgoplugins). Our metadata was helping it and misdescribing us.Changes
README.md# create-wp-plugin→# create-wp-plugin-cli— matches the actual package name (the mismatch was just confusing; npm/GitHub render the H1 as the title).create-wp-pluginname was already taken" blockquote — it was the last bare reference to the other package and framed ours as the runner-up.package.jsonSOLID/DI architecture (Container + Service Providers), removed in v3.0.0) →static bootloader with a Services locator, …, matching the current architecture (src/Services.phpis literally a "Static service locator";src/Plugin.phpsays "Not a service container").bin— removed thecreate-wp-pluginalias. Installing this no longer drops acreate-wp-pluginexecutable onPATHthat shadows the unrelated package.create-wp-plugin-cliis the sole bin;npm create wp-plugin-cli/npx create-wp-plugin-cliunaffected.package-lock.jsonalready only listed the-clibin, so no lockfile change.wordpress-plugin,wp-cli,gutenberg,phpunit.BACKLOG.mdcreate-wp-pluginbin alias") as rejected — it directly contradicts the disentangling intent.Done separately (live repo metadata, not in this diff)
nodejs/scaffold/generator/php; addedscaffolding,boilerplate-generator,npm-package,wordpress-vip,playwright,php82,wp-env,dev-tooling.Verification
npm test→ 70/70 passgit difftouches exactly these 3 files