ci: add self-consumption job (ubuntu + macos) - #4
Merged
Conversation
…gressions Both P0s fixed in 1.0.2 -- mixed CRLF/LF breaking `composer lint`, and the symlink main-guard silently no-op'ing on macOS/Linux -- were invisible from inside this repo. They only surfaced by actually installing the packed tarball and running the real bin on the platforms that matter (Windows never exercises the POSIX symlink install path, and `node index.js` never exercises the bin-resolution path at all). New `self-consumption` job, matrix [ubuntu-latest, macos-latest]: 1. npm pack + global install the tarball (real bin, not `node index.js`) 2. generate a real scaffold via the installed bin (all modules + React) 3. explicit check that the plugin file actually exists (fails loudly with a pointer to isRunAsScript() if the symlink main-guard ever regresses, instead of failing opaquely a few steps later) 4. composer validate --strict / install / lint / test against the output 5. npm install && npm run build for the React admin pipeline No version bump -- .github/workflows/ isn't in package.json's "files" field, so this never reaches the published tarball.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
self-consumptionCI job that packs the CLI, installs it globally (real bin, notnode index.js), generates a real scaffold, and runscomposer validate/install/lint/test+npm install/buildagainst it on both ubuntu-latest and macos-latest.This is the check that would have caught both P0s fixed in 1.0.2 pre-publish:
composer lint(184 cascading errors)No version bump --
.github/workflows/isn't in package.json'sfilesfield, doesn't touch the published tarball.