⚡ Bolt: [performance improvement] optimize bnglWriter membership test - #26
Conversation
Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Uh oh!
There was an error while loading. Please reload this page.
💡 What: Replaced the inner list comprehensions used for membership tests in
bionetgen/atomizer/writer/bnglWriter.pywith precomputed sets (pMolecule_component_namesandrMolecule_component_names).🎯 Why: The previous implementation evaluated$O(N \times M)$ complexity and redundant memory allocations. Precomputing a set changes the membership check to $O(1)$ and brings the overall complexity down to $O(N + M)$ .
[y.name for y in rMolecule.components](and vice versa) for every element in the outer list comprehension. This resulted in unnecessary📊 Measured Improvement:
Using a custom benchmark simulating molecules with 100 components, the optimization yielded a massive improvement:
Linting (black, flake8) and relevant test suite (
tests/test_bng_atomizer.py) passed successfully.PR created automatically by Jules for task 3773139331906415621 started by @akutuva21